[Analyzers][CPP] Turn on warning 4458 (#22265)

* Turn on warning 4458

Fix the errors by changing variable names and
supressing the warning on winRT GDI headers

* explaining the warning disables

src/modules/fancyzones/FancyZonesLib/WindowUtils.h

@@ -2,7 +2,13 @@
 
 #include <Windows.h>
 
+// disabling warning 4458 - declaration of 'identifier' hides class member
+// to avoid warnings from GDI files - can't add winRT directory to external code
+// in the Cpp.Build.props
+#pragma warning(push)
+#pragma warning(disable : 4458)
 #include "gdiplus.h"
+#pragma warning(pop)
 
 #include <string>
 #include <vector>