From 668820cf2c9d81ed9a4d4fb79d39b5d694803922 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ji=C5=99=C3=AD=20Pol=C3=A1=C5=A1ek?= Date: Wed, 8 Oct 2025 22:36:05 +0200 Subject: [PATCH] Spellchecker: resolve warnings (#42202) ## Summary of the Pull Request This PR resolves lingering spell-check warnings and other minor issues, allowing us to focus on newly emerging problems. **Changes:** - Excludes empty and binary files - Converts invalid dictionary entries into patterns - Since dictionary entries can only contain letters, `0x6f677548` was previously ignored - Removes unused words - Adds a pattern marker to ignore all code on a line - `/* #no-spell-check-line */` - `// #no-spell-check` This should reduce outstanding spellchecker warnings and suggestions to zero. ## PR Checklist - [ ] Closes: #xxx - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed --- .github/actions/spell-check/allow/names.txt | 2 - .github/actions/spell-check/excludes.txt | 4 ++ .github/actions/spell-check/expect.txt | 41 --------------------- .github/actions/spell-check/patterns.txt | 9 +++++ 4 files changed, 13 insertions(+), 43 deletions(-) diff --git a/.github/actions/spell-check/allow/names.txt b/.github/actions/spell-check/allow/names.txt index f1216a159d..ab2446f8ae 100644 --- a/.github/actions/spell-check/allow/names.txt +++ b/.github/actions/spell-check/allow/names.txt @@ -29,8 +29,6 @@ shortcutguide # 8LWXpg is user name but user folder causes a flag LWXpg -# 0x6f677548 is user name but user folder causes a flag -x6f677548 Adoumie Advaith alekhyareddy diff --git a/.github/actions/spell-check/excludes.txt b/.github/actions/spell-check/excludes.txt index d29b18e9ce..c6f1225788 100644 --- a/.github/actions/spell-check/excludes.txt +++ b/.github/actions/spell-check/excludes.txt @@ -121,6 +121,10 @@ ^src/modules/MouseWithoutBorders/App/Helper/.*\.resx$ ^src/modules/MouseWithoutBorders/ModuleInterface/generateSecurityDescriptor\.h$ ^src/modules/peek/Peek.Common/NativeMethods\.txt$ +^src/modules/peek/Peek.UITests/TestAssets/4\.qoi$ +^src/modules/powerrename/PowerRenameUITest/testItems/folder1/testCase2\.txt$ +^src/modules/powerrename/PowerRenameUITest/testItems/folder2/SpecialCase\.txt$ +^src/modules/powerrename/PowerRenameUITest/testItems/testCase1\.txt$ ^src/modules/previewpane/SvgPreviewHandler/SvgHTMLPreviewGenerator\.cs$ ^src/modules/previewpane/UnitTests-MarkdownPreviewHandler/HelperFiles/MarkdownWithHTMLImageTag\.txt$ ^src/modules/registrypreview/RegistryPreviewUILib/Controls/HexBox/.*$ diff --git a/.github/actions/spell-check/expect.txt b/.github/actions/spell-check/expect.txt index b4c01efeb9..c89141a8c5 100644 --- a/.github/actions/spell-check/expect.txt +++ b/.github/actions/spell-check/expect.txt @@ -26,8 +26,6 @@ ADMINS adml admx advancedpaste -advancedpasteui -advancedpasteuishortcut advapi advfirewall AFeature @@ -45,7 +43,6 @@ ALLINPUT Allman Allmodule ALLOWUNDO -allpc ALLVIEW ALPHATYPE AModifier @@ -136,7 +133,6 @@ bla BLACKFRAME BLENDFUNCTION Blockquotes -blogs Blt BLURBEHIND BLURREGION @@ -512,7 +508,6 @@ FANCYZONESDRAWLAYOUTTEST FANCYZONESEDITOR FARPROC fesf -fff FFFF FILEEXPLORER fileexploreraddons @@ -672,11 +667,7 @@ Hostx hotfixes hotkeycontrol HOTKEYF -hotkeylockmachine -hotkeyreconnect hotkeys -hotkeyswitch -hotkeytoggleeasymouse hotlight hotspot HPAINTBUFFER @@ -735,8 +726,6 @@ IMAGERESIZERCONTEXTMENU IMAGERESIZEREXT imageresizerinput imageresizersettings -imagetotext -imagetotextshortcut imagingdevices ime imgflip @@ -868,7 +857,6 @@ localappdata localpackage LOCALSYSTEM LOCATIONCHANGE -LOCKMACHINE LOCKTYPE LOGFONT LOGFONTW @@ -877,7 +865,6 @@ LOGMSG LOGPIXELSX LOGPIXELSY lng -LOn lon longdate LONGNAMES @@ -934,7 +921,6 @@ LWA lwin LZero MAGTRANSFORM -MAJORMINOR MAKEINTRESOURCE MAKEINTRESOURCEA MAKEINTRESOURCEW @@ -959,7 +945,6 @@ MDL mdtext mdtxt mdwn -measuretool meme memicmp MENUITEMINFO @@ -1009,7 +994,6 @@ MOUSEHWHEEL MOUSEINPUT mousejump mousepointer -mousepointercrosshairs mouseutils MOVESIZEEND MOVESIZESTART @@ -1054,7 +1038,6 @@ MWBEx MYICON NAMECHANGE namespaceanddescendants -Namotion nao NCACTIVATE ncc @@ -1092,7 +1075,6 @@ NEWPLUSSHELLEXTENSIONWIN newrow nicksnettravels NIF -NJson NLog NLSTEXT NMAKE @@ -1219,18 +1201,6 @@ PARENTRELATIVEFORUI PARENTRELATIVEPARSING parray PARTIALCONFIRMATIONDIALOGTITLE -pasteashtmlfile -pasteashtmlfileshortcut -pasteasjson -pasteasjsonshortcut -pasteasmarkdown -pasteasmarkdownshortcut -pasteasplaintext -pasteasplaintextshortcut -pasteaspngfile -pasteaspngfileshortcut -pasteastxtfile -pasteastxtfileshortcut PATCOPY PATHMUSTEXIST PATINVERT @@ -1301,7 +1271,6 @@ Pomodoro Popups POPUPWINDOW POSITIONITEM -powerocr POWERRENAMECONTEXTMENU powerrenameinput POWERRENAMETEST @@ -1352,7 +1321,6 @@ PRODUCTVERSION Progman programdata projectname -projitems PROPERTYKEY Propset PROPVARIANT @@ -1445,7 +1413,6 @@ Removelnk renamable RENAMEONCOLLISION reparented -reparenthotkey reparenting reportfileaccesses requery @@ -1471,7 +1438,6 @@ RIDEV RIGHTSCROLLBAR riid RKey -Rns RNumber rop ROUNDSMALL @@ -1695,7 +1661,6 @@ STYLECHANGED STYLECHANGING subkeys sublang -Subdomain SUBMODULEUPDATE subresource Superbar @@ -1768,7 +1733,6 @@ THICKFRAME THEMECHANGED THISCOMPONENT throughs -thumbnailhotkey TILEDWINDOW TILLSON timedate @@ -1784,9 +1748,7 @@ tlbimp tlc tmain TNP -TOGGLEEASYMOUSE Toolhelp -toolkitconverters toolwindow TOPDOWNDIB TOUCHEVENTF @@ -1798,11 +1760,9 @@ tracelogging tracerpt trackbar trafficmanager -transcodetomp transicc TRAYMOUSEMESSAGE triaging -Tru trl trx tsa @@ -1838,7 +1798,6 @@ ULONGLONG ums uncompilable UNCPRIORITY -undefining UNDNAME UNICODETEXT unins diff --git a/.github/actions/spell-check/patterns.txt b/.github/actions/spell-check/patterns.txt index 255a7f984c..cb303a10ad 100644 --- a/.github/actions/spell-check/patterns.txt +++ b/.github/actions/spell-check/patterns.txt @@ -1,5 +1,10 @@ # See https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns +# marker to ignore all code on line +^.*/\* #no-spell-check-line \*/.*$ +# marker for ignoring a comment to the end of the line +// #no-spell-check.*$ + # Gaelic Gàidhlig @@ -264,3 +269,7 @@ St&yle # This matches a relative clause where the relative pronoun "that" is omitted. # Example: "Gets or sets the window the TitleBar should configure." \bthe\s+\w+\s+the\b + +# Usernames with numbers +# 0x6f677548 is user name but user folder causes a flag +\bx6f677548\b