Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-05 18:57:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

[Analyzers][CPP] Turn on warning 26403 (#22795)

Browse Source
This commit is contained in:
sosssego
2023-01-03 09:16:27 -03:00
committed by GitHub
parent dd62dab831
commit 6287460614
3 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/modules/videoconference/VideoConferenceModule/VideoConferenceModule.cpp
View File

@@ -319,7 +319,14 @@ VideoConferenceModule::VideoConferenceModule()
if (_settingsUpdateChannel)
{
_settingsUpdateChannel->access([](auto memory) {
// Suppress warning 26403 - Reset or explicitly delete an owner<T> pointer 'variable' (r.3)
// the video conference class should be only instantiated once and it is using placement new
// the access to the data can be done through memory._data
#pragma warning(push)
#pragma warning(disable : 26403)
auto updatesChannel = new (memory._data) CameraSettingsUpdateChannel{};
#pragma warning(pop)
});
}
sendSourceCameraNameUpdate();
@@ -520,11 +527,11 @@ void VideoConferenceModule::enable()
{
if (!_enabled)
{
_generalSettingsWatcher = std::make_unique<FileWatcher> (
_generalSettingsWatcher = std::make_unique<FileWatcher>(
PTSettingsHelper::get_powertoys_general_save_file_location(), [this] {
toolbar.scheduleGeneralSettingsUpdate();
toolbar.scheduleGeneralSettingsUpdate();
});
_moduleSettingsWatcher = std::make_unique<FileWatcher> (
_moduleSettingsWatcher = std::make_unique<FileWatcher>(
PTSettingsHelper::get_module_save_file_location(get_key()), [this] {
toolbar.scheduleModuleSettingsUpdate();
});