Made Plugin Folder Unit tests & Expanding enviroment search (#6600)

* Made Plugin Folder Unit tests. Fixes '>' not recursive searching (with max). Added that paths with an UnauthorizedAccessException are ignored. Added expanding enviroment search. * Fixed some merging errors * Added feedback from review * Made the change that ryanbodrug-microsoft suggested * Stupid merge request... fixed Co-authored-by: p-storm <paul.de.man@gmail.com>
2026-04-07 11:46:30 +02:00 · 2020-10-01 05:37:46 +02:00
parent b2c00b1e1a
commit 5c84de5400
31 changed files with 1264 additions and 296 deletions
--- a/src/modules/launcher/Plugins/Microsoft.Plugin.Folder.UnitTests/DriveOrSharedFolderTests.cs
+++ b/src/modules/launcher/Plugins/Microsoft.Plugin.Folder.UnitTests/DriveOrSharedFolderTests.cs
@@ -0,0 +1,97 @@
+// Copyright (c) Microsoft Corporation
+// The Microsoft Corporation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using System;
+using System.Collections.Generic;
+using Microsoft.Plugin.Folder.Sources;
+using Microsoft.Plugin.Folder.Sources.Result;
+using Moq;
+using NUnit.Framework;
+
+namespace Microsoft.Plugin.Folder.UnitTests
+{
+    public class DriveOrSharedFolderTests
+    {
+        [TestCase(@"\\test-server\testdir", true)]
+        [TestCase(@"c:", true)]
+        [TestCase(@"c:\", true)]
+        [TestCase(@"C:\", true)]
+        [TestCase(@"d:\", true)]
+        [TestCase(@"z:\", false)]
+        [TestCase(@"nope.exe", false)]
+        [TestCase(@"win32\test.dll", false)]
+        [TestCase(@"a\b\c\d", false)]
+        [TestCase(@"D", false)]
+        [TestCase(@"ZZ:\test", false)]
+        public void IsDriveOrSharedFolder_WhenCalled(string search, bool expectedSuccess)
+        {
+            // Setup
+            var driveInformationMock = new Mock<IDriveInformation>();
+
+            driveInformationMock.Setup(r => r.GetDriveNames())
+                .Returns(() => new[] { "c:", "d:" });
+
+            var folderLinksMock = new Mock<IFolderLinks>();
+            var folderHelper = new FolderHelper(driveInformationMock.Object, folderLinksMock.Object);
+
+            // Act
+            var isDriveOrSharedFolder = folderHelper.IsDriveOrSharedFolder(search);
+
+            // Assert
+            Assert.AreEqual(expectedSuccess, isDriveOrSharedFolder);
+        }
+
+        [TestCase('A', true)]
+        [TestCase('C', true)]
+        [TestCase('c', true)]
+        [TestCase('Z', true)]
+        [TestCase('z', true)]
+        [TestCase('ª', false)]
+        [TestCase('α', false)]
+        [TestCase('Ω', false)]
+        [TestCase('ɀ', false)]
+        public void ValidDriveLetter_WhenCalled(char letter, bool expectedSuccess)
+        {
+            // Setup
+            // Act
+            var isDriveOrSharedFolder = FolderHelper.ValidDriveLetter(letter);
+
+            // Assert
+            Assert.AreEqual(expectedSuccess, isDriveOrSharedFolder);
+        }
+
+        [TestCase("C:", true)]
+        [TestCase("C:\test", true)]
+        [TestCase("D:", false)]
+        [TestCase("INVALID", false)]
+        public void GenerateMaxFiles_WhenCalled(string search, bool hasValues)
+        {
+            // Setup
+            var folderHelperMock = new Mock<IFolderHelper>();
+            folderHelperMock.Setup(r => r.IsDriveOrSharedFolder(It.IsAny<string>()))
+                .Returns<string>(s => s.StartsWith("C:", StringComparison.CurrentCultureIgnoreCase));
+
+            var itemResultMock = new Mock<IItemResult>();
+
+            var internalDirectoryMock = new Mock<IQueryInternalDirectory>();
+            internalDirectoryMock.Setup(r => r.Query(It.IsAny<string>()))
+                .Returns(new List<IItemResult>() { itemResultMock.Object });
+
+            var processor = new InternalDirectoryProcessor(folderHelperMock.Object, internalDirectoryMock.Object);
+
+            // Act
+            var results = processor.Results(string.Empty, search);
+
+            // Assert
+            if (hasValues)
+            {
+                CollectionAssert.IsNotEmpty(results);
+            }
+            else
+            {
+                CollectionAssert.IsEmpty(results);
+            }
+        }
+    }
+}