Add telemetry event for PowerRename settings (#1279)

* moved MAX_INPUT_STRING_LEN constant
* added settings changed event log
This commit is contained in:
Seraphima
2020-02-13 12:44:03 +03:00
committed by GitHub
parent 49fa1b6762
commit 59d218d623
5 changed files with 27 additions and 5 deletions

View File

@@ -6,6 +6,7 @@
#include <helpers.h>
#include <settings.h>
#include <windowsx.h>
#include <trace.h>
extern HINSTANCE g_hInst;
@@ -77,8 +78,6 @@ inline int RECT_HEIGHT(RECT& r)
return r.bottom - r.top;
}
#define MAX_INPUT_STRING_LEN 1024
// IUnknown
IFACEMETHODIMP CPowerRenameUI::QueryInterface(__in REFIID riid, __deref_out void** ppv)
{
@@ -391,7 +390,7 @@ HRESULT CPowerRenameUI::_ReadSettings()
flags = CSettings::GetFlags();
m_spsrm->put_flags(flags);
wchar_t buffer[MAX_INPUT_STRING_LEN];
wchar_t buffer[CSettings::MAX_INPUT_STRING_LEN];
buffer[0] = L'\0';
CSettings::GetSearchText(buffer, ARRAYSIZE(buffer));
SetDlgItemText(m_hwnd, IDC_EDIT_SEARCHFOR, buffer);
@@ -419,7 +418,7 @@ HRESULT CPowerRenameUI::_WriteSettings()
m_spsrm->get_flags(&flags);
CSettings::SetFlags(flags);
wchar_t buffer[MAX_INPUT_STRING_LEN];
wchar_t buffer[CSettings::MAX_INPUT_STRING_LEN];
buffer[0] = L'\0';
GetDlgItemText(m_hwnd, IDC_EDIT_SEARCHFOR, buffer, ARRAYSIZE(buffer));
CSettings::SetSearchText(buffer);
@@ -445,6 +444,8 @@ HRESULT CPowerRenameUI::_WriteSettings()
spReplaceMRU->AddMRUString(buffer);
}
}
Trace::SettingsChanged();
}
return S_OK;
@@ -825,7 +826,7 @@ void CPowerRenameUI::_OnSearchReplaceChanged()
CComPtr<IPowerRenameRegEx> spRegEx;
if (m_spsrm && SUCCEEDED(m_spsrm->get_renameRegEx(&spRegEx)))
{
wchar_t buffer[MAX_INPUT_STRING_LEN];
wchar_t buffer[CSettings::MAX_INPUT_STRING_LEN];
buffer[0] = L'\0';
GetDlgItemText(m_hwnd, IDC_EDIT_SEARCHFOR, buffer, ARRAYSIZE(buffer));
spRegEx->put_searchTerm(buffer);