diff --git a/src/modules/keyboardmanager/common/KeyboardManagerState.cpp b/src/modules/keyboardmanager/common/KeyboardManagerState.cpp index 5c8dca1f6c..f17f400946 100644 --- a/src/modules/keyboardmanager/common/KeyboardManagerState.cpp +++ b/src/modules/keyboardmanager/common/KeyboardManagerState.cpp @@ -153,8 +153,8 @@ void KeyboardManagerState::AddKeyToLayout(const StackPanel& panel, const hstring border.Padding({ 20, 10, 20, 10 }); border.Margin({ 0, 0, 10, 0 }); - border.Background(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::LightGray() }); - remapKey.Foreground(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::Black() }); + // Use the base low brush to be consistent with the theme + border.Background(Windows::UI::Xaml::Application::Current().Resources().Lookup(box_value(L"SystemControlBackgroundBaseLowBrush")).as()); remapKey.FontSize(20); border.HorizontalAlignment(HorizontalAlignment::Left); border.Child(remapKey); diff --git a/src/modules/keyboardmanager/ui/EditKeyboardWindow.cpp b/src/modules/keyboardmanager/ui/EditKeyboardWindow.cpp index 0d862c890f..722383d7a5 100644 --- a/src/modules/keyboardmanager/ui/EditKeyboardWindow.cpp +++ b/src/modules/keyboardmanager/ui/EditKeyboardWindow.cpp @@ -75,7 +75,6 @@ void createEditKeyboardWindow(HINSTANCE hInst, KeyboardManagerState& keyboardMan // Creating the Xaml content. xamlContainer is the parent UI element Windows::UI::Xaml::Controls::StackPanel xamlContainer; - xamlContainer.Background(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::LightGray() }); // Header for the window Windows::UI::Xaml::Controls::StackPanel header; @@ -86,14 +85,11 @@ void createEditKeyboardWindow(HINSTANCE hInst, KeyboardManagerState& keyboardMan // Header text TextBlock headerText; headerText.Text(winrt::to_hstring("Remap Keyboard")); - headerText.Foreground(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::Black() }); headerText.FontSize(30); headerText.Margin({ 0, 0, 1000, 0 }); // Header Cancel button Button cancelButton; - cancelButton.Background(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::LightGray() }); - cancelButton.Foreground(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::Black() }); cancelButton.Content(winrt::box_value(winrt::to_hstring("Cancel"))); cancelButton.Click([&](winrt::Windows::Foundation::IInspectable const& sender, RoutedEventArgs const&) { // Close the window since settings do not need to be saved @@ -103,25 +99,21 @@ void createEditKeyboardWindow(HINSTANCE hInst, KeyboardManagerState& keyboardMan // Text block for information about remap key section. TextBlock keyRemapInfoHeader; keyRemapInfoHeader.Text(winrt::to_hstring("Select the key you want to remap, original key, and it's new output when pressed, the new key")); - keyRemapInfoHeader.Foreground(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::Black() }); keyRemapInfoHeader.Margin({ 10, 0, 0, 10 }); // Table to display the key remaps Windows::UI::Xaml::Controls::StackPanel keyRemapTable; - keyRemapTable.Background(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::LightGray() }); keyRemapTable.Margin({ 10, 10, 10, 20 }); keyRemapTable.Spacing(10); // Header row of the keys remap table Windows::UI::Xaml::Controls::StackPanel tableHeaderRow; - tableHeaderRow.Background(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::LightGray() }); tableHeaderRow.Spacing(100); tableHeaderRow.Orientation(Windows::UI::Xaml::Controls::Orientation::Horizontal); // First header textblock in the header row of the keys remap table TextBlock originalKeyRemapHeader; originalKeyRemapHeader.Text(winrt::to_hstring("Original Key:")); - originalKeyRemapHeader.Foreground(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::Black() }); originalKeyRemapHeader.FontWeight(Text::FontWeights::Bold()); originalKeyRemapHeader.Margin({ 0, 0, 0, 10 }); tableHeaderRow.Children().Append(originalKeyRemapHeader); @@ -129,7 +121,6 @@ void createEditKeyboardWindow(HINSTANCE hInst, KeyboardManagerState& keyboardMan // Second header textblock in the header row of the keys remap table TextBlock newKeyRemapHeader; newKeyRemapHeader.Text(winrt::to_hstring("New Key:")); - newKeyRemapHeader.Foreground(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::Black() }); newKeyRemapHeader.FontWeight(Text::FontWeights::Bold()); newKeyRemapHeader.Margin({ 0, 0, 0, 10 }); tableHeaderRow.Children().Append(newKeyRemapHeader); @@ -195,8 +186,6 @@ void createEditKeyboardWindow(HINSTANCE hInst, KeyboardManagerState& keyboardMan // Main Header Apply button Button applyButton; - applyButton.Background(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::LightGray() }); - applyButton.Foreground(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::Black() }); applyButton.Content(winrt::box_value(winrt::to_hstring("Apply"))); applyButton.Flyout(applyFlyout); applyButton.Click([&](winrt::Windows::Foundation::IInspectable const& sender, RoutedEventArgs const&) { @@ -269,8 +258,6 @@ void createEditKeyboardWindow(HINSTANCE hInst, KeyboardManagerState& keyboardMan // Add remap key button Windows::UI::Xaml::Controls::Button addRemapKey; - addRemapKey.Background(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::LightGray() }); - addRemapKey.Foreground(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::Black() }); FontIcon plusSymbol; plusSymbol.FontFamily(Xaml::Media::FontFamily(L"Segoe MDL2 Assets")); plusSymbol.Glyph(L"\xE109"); diff --git a/src/modules/keyboardmanager/ui/EditShortcutsWindow.cpp b/src/modules/keyboardmanager/ui/EditShortcutsWindow.cpp index c30d12de49..f04e854759 100644 --- a/src/modules/keyboardmanager/ui/EditShortcutsWindow.cpp +++ b/src/modules/keyboardmanager/ui/EditShortcutsWindow.cpp @@ -76,11 +76,9 @@ void createEditShortcutsWindow(HINSTANCE hInst, KeyboardManagerState& keyboardMa // Creating the Xaml content. xamlContainer is the parent UI element Windows::UI::Xaml::Controls::StackPanel xamlContainer; - xamlContainer.Background(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::LightGray() }); // Header for the window Windows::UI::Xaml::Controls::StackPanel header; - header.Background(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::LightGray() }); header.Orientation(Windows::UI::Xaml::Controls::Orientation::Horizontal); header.Margin({ 10, 10, 10, 30 }); header.Spacing(10); @@ -101,13 +99,11 @@ void createEditShortcutsWindow(HINSTANCE hInst, KeyboardManagerState& keyboardMa // Table to display the shortcuts Windows::UI::Xaml::Controls::StackPanel shortcutTable; - shortcutTable.Background(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::LightGray() }); shortcutTable.Margin({ 10, 10, 10, 20 }); shortcutTable.Spacing(10); // Header row of the shortcut table Windows::UI::Xaml::Controls::StackPanel tableHeaderRow; - tableHeaderRow.Background(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::LightGray() }); tableHeaderRow.Spacing(100); tableHeaderRow.Orientation(Windows::UI::Xaml::Controls::Orientation::Horizontal); diff --git a/src/modules/keyboardmanager/ui/ShortcutControl.cpp b/src/modules/keyboardmanager/ui/ShortcutControl.cpp index 2bb2d7eeca..bb380d80f8 100644 --- a/src/modules/keyboardmanager/ui/ShortcutControl.cpp +++ b/src/modules/keyboardmanager/ui/ShortcutControl.cpp @@ -13,7 +13,6 @@ void ShortcutControl::AddNewShortcutControlRow(StackPanel& parent, std::vectorgetShortcutControl()); - // Delete row button Windows::UI::Xaml::Controls::Button deleteShortcut; FontIcon deleteSymbol; @@ -61,7 +59,6 @@ void ShortcutControl::AddNewShortcutControlRow(StackPanel& parent, std::vector{ Shortcut(), Shortcut() }); } - } // Function to add a shortcut to the shortcut control as combo boxes @@ -106,8 +103,6 @@ void ShortcutControl::createDetectShortcutWindow(winrt::Windows::Foundation::IIn // ContentDialog for detecting shortcuts. This is the parent UI element. ContentDialog detectShortcutBox; - // TODO: Hardcoded light theme, since the app is not theme aware ATM. - detectShortcutBox.RequestedTheme(ElementTheme::Light); // ContentDialog requires manually setting the XamlRoot (https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.contentdialog#contentdialog-in-appwindow-or-xaml-islands) detectShortcutBox.XamlRoot(xamlRoot); detectShortcutBox.Title(box_value(L"Press the keys in shortcut:")); @@ -172,7 +167,8 @@ void ShortcutControl::createDetectShortcutWindow(winrt::Windows::Foundation::IIn detectShortcutBox.Dispatcher().RunAsync( Windows::UI::Core::CoreDispatcherPriority::Normal, [primaryButton] { - primaryButton.Background(Windows::UI::Xaml::Media::SolidColorBrush{ Windows::UI::Colors::DarkGray() }); + // Use the base medium low brush to be consistent with the theme + primaryButton.Background(Windows::UI::Xaml::Application::Current().Resources().Lookup(box_value(L"SystemControlBackgroundBaseMediumLowBrush")).as()); }); }, [onAccept, detectShortcutBox](DWORD) { diff --git a/src/modules/keyboardmanager/ui/ShortcutControl.h b/src/modules/keyboardmanager/ui/ShortcutControl.h index 246bac1901..ecdfaee5bc 100644 --- a/src/modules/keyboardmanager/ui/ShortcutControl.h +++ b/src/modules/keyboardmanager/ui/ShortcutControl.h @@ -31,7 +31,6 @@ public: ShortcutControl(const size_t rowIndex, const size_t colIndex) { - shortcutDropDownStackPanel.RequestedTheme(ElementTheme::Light); shortcutDropDownStackPanel.Spacing(10); shortcutDropDownStackPanel.Orientation(Windows::UI::Xaml::Controls::Orientation::Horizontal); KeyDropDownControl::AddDropDown(shortcutDropDownStackPanel, rowIndex, colIndex, shortcutRemapBuffer, keyDropDownControlObjects); @@ -43,7 +42,6 @@ public: createDetectShortcutWindow(sender, sender.as