Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2025-12-16 19:57:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

[stylecop] program plugin unit tests part2 (#5925)

Browse Source 
* Another batch

* Commenting out stylecop
This commit is contained in:
Clint Rutkas
2020-08-13 11:10:55 -07:00
committed by GitHub
parent 9592fab414
commit 5079ee67c3
4 changed files with 63 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/Programs/UWPTests.cs
View File

@@ -13,39 +13,36 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
[TestFixture] [TestFixture]
public class UWPTests public class UWPTests
{ {
static readonly PackageWrapper developmentModeApp = new PackageWrapper( private static readonly PackageWrapper DevelopmentModeApp = new PackageWrapper(
"DevelopmentApp", "DevelopmentApp",
"DevelopmentApp", "DevelopmentApp",
"DevelopmentApp", "DevelopmentApp",
false, false,
true, true,
"AppxManifests/DevelopmentApp" "AppxManifests/DevelopmentApp");
);
static readonly PackageWrapper frameworkApp = new PackageWrapper( private static readonly PackageWrapper FrameworkApp = new PackageWrapper(
"FrameworkApp", "FrameworkApp",
"FrameworkApp", "FrameworkApp",
"FrameworkApp", "FrameworkApp",
true, true,
false, false,
"AppxManifests/FrameworkApp" "AppxManifests/FrameworkApp");
);
static readonly PackageWrapper packagedApp = new PackageWrapper( private static readonly PackageWrapper PackagedApp = new PackageWrapper(
"PackagedApp", "PackagedApp",
"PackagedApp", "PackagedApp",
"PackagedApp", "PackagedApp",
false, false,
false, false,
"AppxManifests/PackagedApp" "AppxManifests/PackagedApp");
);
[Test] [Test]
public void AllShouldReturnPackagesWithDevelopmentModeWhenCalled() public void AllShouldReturnPackagesWithDevelopmentModeWhenCalled()
{ {
// Arrange // Arrange
Main._settings = new ProgramPluginSettings(); Main._settings = new ProgramPluginSettings();
List<IPackage> packages = new List<IPackage>() { developmentModeApp, packagedApp }; List<IPackage> packages = new List<IPackage>() { DevelopmentModeApp, PackagedApp };
var mock = new Mock<IPackageManager>(); var mock = new Mock<IPackageManager>();
mock.Setup(x => x.FindPackagesForCurrentUser()).Returns(packages); mock.Setup(x => x.FindPackagesForCurrentUser()).Returns(packages);
UWP.PackageManagerWrapper = mock.Object; UWP.PackageManagerWrapper = mock.Object;
@@ -64,7 +61,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
{ {
// Arrange // Arrange
Main._settings = new ProgramPluginSettings(); Main._settings = new ProgramPluginSettings();
List<IPackage> packages = new List<IPackage>() { frameworkApp, packagedApp }; List<IPackage> packages = new List<IPackage>() { FrameworkApp, PackagedApp };
var mock = new Mock<IPackageManager>(); var mock = new Mock<IPackageManager>();
mock.Setup(x => x.FindPackagesForCurrentUser()).Returns(packages); mock.Setup(x => x.FindPackagesForCurrentUser()).Returns(packages);
UWP.PackageManagerWrapper = mock.Object; UWP.PackageManagerWrapper = mock.Object;

77
src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/Programs/Win32Tests.cs
View File

@@ -17,7 +17,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
[TestFixture] [TestFixture]
public class Win32Tests public class Win32Tests
{ {
static Win32Program notepad_appdata = new Win32Program private static Win32Program notepad_appdata = new Win32Program
{ {
Name = "Notepad", Name = "Notepad",
ExecutableName = "notepad.exe", ExecutableName = "notepad.exe",
@@ -26,7 +26,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 2, AppType = 2,
}; };
static Win32Program notepad_users = new Win32Program private static Win32Program notepad_users = new Win32Program
{ {
Name = "Notepad", Name = "Notepad",
ExecutableName = "notepad.exe", ExecutableName = "notepad.exe",
@@ -35,7 +35,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 2, AppType = 2,
}; };
static Win32Program azure_command_prompt = new Win32Program private static Win32Program azure_command_prompt = new Win32Program
{ {
Name = "Microsoft Azure Command Prompt - v2.9", Name = "Microsoft Azure Command Prompt - v2.9",
ExecutableName = "cmd.exe", ExecutableName = "cmd.exe",
@@ -44,7 +44,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 2, AppType = 2,
}; };
static Win32Program visual_studio_command_prompt = new Win32Program private static Win32Program visual_studio_command_prompt = new Win32Program
{ {
Name = "x64 Native Tools Command Prompt for VS 2019", Name = "x64 Native Tools Command Prompt for VS 2019",
ExecutableName = "cmd.exe", ExecutableName = "cmd.exe",
@@ -53,7 +53,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 2, AppType = 2,
}; };
static Win32Program command_prompt = new Win32Program private static Win32Program command_prompt = new Win32Program
{ {
Name = "Command Prompt", Name = "Command Prompt",
ExecutableName = "cmd.exe", ExecutableName = "cmd.exe",
@@ -62,7 +62,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 2, AppType = 2,
}; };
static Win32Program file_explorer = new Win32Program private static Win32Program file_explorer = new Win32Program
{ {
Name = "File Explorer", Name = "File Explorer",
ExecutableName = "File Explorer.lnk", ExecutableName = "File Explorer.lnk",
@@ -71,7 +71,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 2, AppType = 2,
}; };
static Win32Program wordpad = new Win32Program private static Win32Program wordpad = new Win32Program
{ {
Name = "Wordpad", Name = "Wordpad",
ExecutableName = "wordpad.exe", ExecutableName = "wordpad.exe",
@@ -80,7 +80,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 2, AppType = 2,
}; };
static Win32Program wordpad_duplicate = new Win32Program private static Win32Program wordpad_duplicate = new Win32Program
{ {
Name = "WORDPAD", Name = "WORDPAD",
ExecutableName = "WORDPAD.EXE", ExecutableName = "WORDPAD.EXE",
@@ -89,7 +89,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 2, AppType = 2,
}; };
static Win32Program twitter_pwa = new Win32Program private static Win32Program twitter_pwa = new Win32Program
{ {
Name = "Twitter", Name = "Twitter",
FullPath = "c:\\program files (x86)\\google\\chrome\\application\\chrome_proxy.exe", FullPath = "c:\\program files (x86)\\google\\chrome\\application\\chrome_proxy.exe",
@@ -98,7 +98,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 0, AppType = 0,
}; };
static Win32Program pinned_webpage = new Win32Program private static Win32Program pinned_webpage = new Win32Program
{ {
Name = "Web page", Name = "Web page",
FullPath = "c:\\program files (x86)\\microsoft\\edge\\application\\msedge_proxy.exe", FullPath = "c:\\program files (x86)\\microsoft\\edge\\application\\msedge_proxy.exe",
@@ -107,7 +107,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 0, AppType = 0,
}; };
static Win32Program edge_named_pinned_webpage = new Win32Program private static Win32Program edge_named_pinned_webpage = new Win32Program
{ {
Name = "edge - Bing", Name = "edge - Bing",
FullPath = "c:\\program files (x86)\\microsoft\\edge\\application\\msedge_proxy.exe", FullPath = "c:\\program files (x86)\\microsoft\\edge\\application\\msedge_proxy.exe",
@@ -116,7 +116,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 0, AppType = 0,
}; };
static Win32Program msedge = new Win32Program private static Win32Program msedge = new Win32Program
{ {
Name = "Microsoft Edge", Name = "Microsoft Edge",
ExecutableName = "msedge.exe", ExecutableName = "msedge.exe",
@@ -125,7 +125,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 2, AppType = 2,
}; };
static Win32Program chrome = new Win32Program private static Win32Program chrome = new Win32Program
{ {
Name = "Google Chrome", Name = "Google Chrome",
ExecutableName = "chrome.exe", ExecutableName = "chrome.exe",
@@ -134,7 +134,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 2, AppType = 2,
}; };
static Win32Program dummy_proxy_app = new Win32Program private static Win32Program dummy_proxy_app = new Win32Program
{ {
Name = "Proxy App", Name = "Proxy App",
ExecutableName = "test_proxy.exe", ExecutableName = "test_proxy.exe",
@@ -143,7 +143,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 2, AppType = 2,
}; };
static Win32Program cmd_run_command = new Win32Program private static Win32Program cmd_run_command = new Win32Program
{ {
Name = "cmd", Name = "cmd",
ExecutableName = "cmd.exe", ExecutableName = "cmd.exe",
@@ -152,7 +152,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 3, // Run command AppType = 3, // Run command
}; };
static Win32Program cmder_run_command = new Win32Program private static Win32Program cmder_run_command = new Win32Program
{ {
Name = "Cmder", Name = "Cmder",
Description = "Cmder: Lovely Console Emulator", Description = "Cmder: Lovely Console Emulator",
@@ -162,7 +162,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 3, // Run command AppType = 3, // Run command
}; };
static Win32Program dummy_internetShortcut_app = new Win32Program private static Win32Program dummy_internetShortcut_app = new Win32Program
{ {
Name = "Shop Titans", Name = "Shop Titans",
ExecutableName = "Shop Titans.url", ExecutableName = "Shop Titans.url",
@@ -172,7 +172,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
AppType = 1, AppType = 1,
}; };
static Win32Program dummy_internetShortcut_app_duplicate = new Win32Program private static Win32Program dummy_internetShortcut_app_duplicate = new Win32Program
{ {
Name = "Shop Titans", Name = "Shop Titans",
ExecutableName = "Shop Titans.url", ExecutableName = "Shop Titans.url",
@@ -186,9 +186,11 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
public void DedupFunctionWhenCalledMustRemoveDuplicateNotepads() public void DedupFunctionWhenCalledMustRemoveDuplicateNotepads()
{ {
// Arrange // Arrange
List<Win32Program> prgms = new List<Win32Program>(); List<Win32Program> prgms = new List<Win32Program>
prgms.Add(notepad_appdata); {
prgms.Add(notepad_users); notepad_appdata,
notepad_users
};
// Act // Act
Win32Program[] apps = Win32Program.DeduplicatePrograms(prgms.AsParallel()); Win32Program[] apps = Win32Program.DeduplicatePrograms(prgms.AsParallel());
@@ -201,9 +203,11 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
public void DedupFunctionWhenCalledMustRemoveInternetShortcuts() public void DedupFunctionWhenCalledMustRemoveInternetShortcuts()
{ {
// Arrange // Arrange
List<Win32Program> prgms = new List<Win32Program>(); List<Win32Program> prgms = new List<Win32Program>
prgms.Add(dummy_internetShortcut_app); {
prgms.Add(dummy_internetShortcut_app_duplicate); dummy_internetShortcut_app,
dummy_internetShortcut_app_duplicate
};
// Act // Act
Win32Program[] apps = Win32Program.DeduplicatePrograms(prgms.AsParallel()); Win32Program[] apps = Win32Program.DeduplicatePrograms(prgms.AsParallel());
@@ -216,8 +220,10 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
public void DedupFunctionWhenCalledMustNotRemovelnkWhichdoesNotHaveExe() public void DedupFunctionWhenCalledMustNotRemovelnkWhichdoesNotHaveExe()
{ {
// Arrange // Arrange
List<Win32Program> prgms = new List<Win32Program>(); List<Win32Program> prgms = new List<Win32Program>
prgms.Add(file_explorer); {
file_explorer
};
// Act // Act
Win32Program[] apps = Win32Program.DeduplicatePrograms(prgms.AsParallel()); Win32Program[] apps = Win32Program.DeduplicatePrograms(prgms.AsParallel());
@@ -230,9 +236,11 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
public void DedupFunctionMustRemoveDuplicatesForExeExtensionsWithoutLnkResolvedPath() public void DedupFunctionMustRemoveDuplicatesForExeExtensionsWithoutLnkResolvedPath()
{ {
// Arrange // Arrange
List<Win32Program> prgms = new List<Win32Program>(); List<Win32Program> prgms = new List<Win32Program>
prgms.Add(wordpad); {
prgms.Add(wordpad_duplicate); wordpad,
wordpad_duplicate
};
// Act // Act
Win32Program[] apps = Win32Program.DeduplicatePrograms(prgms.AsParallel()); Win32Program[] apps = Win32Program.DeduplicatePrograms(prgms.AsParallel());
@@ -246,10 +254,12 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
public void DedupFunctionMustNotRemoveProgramsWithSameExeNameAndFullPath() public void DedupFunctionMustNotRemoveProgramsWithSameExeNameAndFullPath()
{ {
// Arrange // Arrange
List<Win32Program> prgms = new List<Win32Program>(); List<Win32Program> prgms = new List<Win32Program>
prgms.Add(azure_command_prompt); {
prgms.Add(visual_studio_command_prompt); azure_command_prompt,
prgms.Add(command_prompt); visual_studio_command_prompt,
command_prompt
};
// Act // Act
Win32Program[] apps = Win32Program.DeduplicatePrograms(prgms.AsParallel()); Win32Program[] apps = Win32Program.DeduplicatePrograms(prgms.AsParallel());
@@ -328,6 +338,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Programs
{ {
return edge_named_pinned_webpage.FilterWebApplication(query); return edge_named_pinned_webpage.FilterWebApplication(query);
} }
// unreachable code // unreachable code
return true; return true;
} }

7
src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/Storage/ListRepositoryTests.cs
View File

@@ -11,7 +11,6 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
[TestFixture] [TestFixture]
public class ListRepositoryTests public class ListRepositoryTests
{ {
[Test] [Test]
public void ContainsShouldReturnTrueWhenListIsInitializedWithItem() public void ContainsShouldReturnTrueWhenListIsInitializedWithItem()
{ {
@@ -76,11 +75,10 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
foreach (var item in repository) foreach (var item in repository)
{ {
// keep iterating // keep iterating
} }
--remainingIterations; --remainingIterations;
} }
}); });
// Act - Insert on another thread // Act - Insert on another thread
@@ -116,11 +114,10 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
foreach (var item in repository) foreach (var item in repository)
{ {
// keep iterating // keep iterating
} }
--remainingIterations; --remainingIterations;
} }
}); });
// Act - Remove on another thread // Act - Remove on another thread

21
src/modules/launcher/Plugins/Microsoft.Plugin.Program.UnitTests/Storage/Win32ProgramRepositoryTest.cs
View File

@@ -2,7 +2,6 @@
// The Microsoft Corporation licenses this file to you under the MIT license. // The Microsoft Corporation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information. // See the LICENSE file in the project root for more information.
using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Diagnostics; using System.Diagnostics;
using System.IO; using System.IO;
@@ -13,18 +12,17 @@ using Moq;
using NUnit.Framework; using NUnit.Framework;
using Wox.Infrastructure.FileSystemHelper; using Wox.Infrastructure.FileSystemHelper;
using Wox.Infrastructure.Storage; using Wox.Infrastructure.Storage;
using Win32Program = Microsoft.Plugin.Program.Programs.Win32Program;
namespace Microsoft.Plugin.Program.UnitTests.Storage namespace Microsoft.Plugin.Program.UnitTests.Storage
{ {
using Win32Program = Program.Programs.Win32Program;
[TestFixture] [TestFixture]
public class Win32ProgramRepositoryTest public class Win32ProgramRepositoryTest
{ {
List<IFileSystemWatcherWrapper> _fileSystemWatchers; private List<IFileSystemWatcherWrapper> _fileSystemWatchers;
ProgramPluginSettings _settings = new ProgramPluginSettings(); private ProgramPluginSettings _settings = new ProgramPluginSettings();
string[] _pathsToWatch = new string[] { "location1", "location2" }; private string[] _pathsToWatch = new string[] { "location1", "location2" };
List<Mock<IFileSystemWatcherWrapper>> _fileSystemMocks; private List<Mock<IFileSystemWatcherWrapper>> _fileSystemMocks;
[SetUp] [SetUp]
public void SetFileSystemWatchers() public void SetFileSystemWatchers()
@@ -259,7 +257,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
// ShellLinkHelper must be mocked for lnk applications // ShellLinkHelper must be mocked for lnk applications
var mockShellLink = new Mock<IShellLinkHelper>(); var mockShellLink = new Mock<IShellLinkHelper>();
mockShellLink.Setup(m => m.RetrieveTargetPath(It.IsAny<string>())).Returns(String.Empty); mockShellLink.Setup(m => m.RetrieveTargetPath(It.IsAny<string>())).Returns(string.Empty);
Win32Program.Helper = mockShellLink.Object; Win32Program.Helper = mockShellLink.Object;
// Act // Act
@@ -320,7 +318,6 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
Assert.IsFalse(_win32ProgramRepository.Contains(olditem)); Assert.IsFalse(_win32ProgramRepository.Contains(olditem));
} }
[TestCase("path.lnk")] [TestCase("path.lnk")]
public void Win32ProgramRepositoryMustCallOnAppCreatedForLnkAppsWhenCreatedEventIsRaised(string path) public void Win32ProgramRepositoryMustCallOnAppCreatedForLnkAppsWhenCreatedEventIsRaised(string path)
{ {
@@ -330,7 +327,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
// ShellLinkHelper must be mocked for lnk applications // ShellLinkHelper must be mocked for lnk applications
var mockShellLink = new Mock<IShellLinkHelper>(); var mockShellLink = new Mock<IShellLinkHelper>();
mockShellLink.Setup(m => m.RetrieveTargetPath(It.IsAny<string>())).Returns(String.Empty); mockShellLink.Setup(m => m.RetrieveTargetPath(It.IsAny<string>())).Returns(string.Empty);
Win32Program.Helper = mockShellLink.Object; Win32Program.Helper = mockShellLink.Object;
// Act // Act
@@ -350,7 +347,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
// ShellLinkHelper must be mocked for lnk applications // ShellLinkHelper must be mocked for lnk applications
var mockShellLink = new Mock<IShellLinkHelper>(); var mockShellLink = new Mock<IShellLinkHelper>();
mockShellLink.Setup(m => m.RetrieveTargetPath(It.IsAny<string>())).Returns(String.Empty); mockShellLink.Setup(m => m.RetrieveTargetPath(It.IsAny<string>())).Returns(string.Empty);
Win32Program.Helper = mockShellLink.Object; Win32Program.Helper = mockShellLink.Object;
string fullPath = directory + "\\" + path; string fullPath = directory + "\\" + path;
@@ -383,7 +380,7 @@ namespace Microsoft.Plugin.Program.UnitTests.Storage
// ShellLinkHelper must be mocked for lnk applications // ShellLinkHelper must be mocked for lnk applications
var mockShellLink = new Mock<IShellLinkHelper>(); var mockShellLink = new Mock<IShellLinkHelper>();
mockShellLink.Setup(m => m.RetrieveTargetPath(It.IsAny<string>())).Returns(String.Empty); mockShellLink.Setup(m => m.RetrieveTargetPath(It.IsAny<string>())).Returns(string.Empty);
Win32Program.Helper = mockShellLink.Object; Win32Program.Helper = mockShellLink.Object;
// old item and new item are the actual items when they are in existence // old item and new item are the actual items when they are in existence