[PT Run] System plugin: Add IP and MAC (#17023)

* first test and changes

* last changes

* last changes

* last changes

* improve exception

* fix spellings

* spell fixes

* search improvements, installer, tests, code cleanup

* remove left-over

* update dev docs

* fix spelling

* update namings

* improve scoring

* spell checker

* dev docs

* update images

* update expect.txt for this pr

src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.System/Properties/Resources.Designer.cs

@@ -19,7 +19,7 @@ namespace Microsoft.PowerToys.Run.Plugin.System.Properties {
     // class via a tool like ResGen or Visual Studio.
     // To add or remove a member, edit your .ResX file then rerun ResGen
     // with the /str option, or rebuild your VS project.
-    [global::System.CodeDom.Compiler.GeneratedCodeAttribute("System.Resources.Tools.StronglyTypedResourceBuilder", "16.0.0.0")]
+    [global::System.CodeDom.Compiler.GeneratedCodeAttribute("System.Resources.Tools.StronglyTypedResourceBuilder", "17.0.0.0")]
     [global::System.Diagnostics.DebuggerNonUserCodeAttribute()]
     [global::System.Runtime.CompilerServices.CompilerGeneratedAttribute()]
     internal class Resources {
@@ -69,6 +69,33 @@ namespace Microsoft.PowerToys.Run.Plugin.System.Properties {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to Adapter details.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_AdapterDetails {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_AdapterDetails", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Adapter name.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_AdapterName {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_AdapterName", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Cable.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Cable {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Cable", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Please confirm..
         /// </summary>
@@ -78,6 +105,69 @@ namespace Microsoft.PowerToys.Run.Plugin.System.Properties {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to Connected.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Connected {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Connected", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Connection details.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_ConnectionDetails {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_ConnectionDetails", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Connection name.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_ConnectionName {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_ConnectionName", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Copy details (Ctrl+C).
+        /// </summary>
+        internal static string Microsoft_plugin_sys_CopyDetails {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_CopyDetails", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to DHCP servers.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Dhcp {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Dhcp", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Disconnected.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Disconnected {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Disconnected", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to DNS servers.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Dns {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Dns", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Empty Recycle Bin.
         /// </summary>
@@ -96,6 +186,24 @@ namespace Microsoft.PowerToys.Run.Plugin.System.Properties {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to Default Gateway.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Gateways {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Gateways", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to {0} Gbps.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Gbps {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Gbps", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Hibernate.
         /// </summary>
@@ -123,6 +231,87 @@ namespace Microsoft.PowerToys.Run.Plugin.System.Properties {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to IPv4 address of {0}.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_ip4_description {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_ip4_description", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to IPv4 address.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Ip4Address {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Ip4Address", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to IPv4 subnet mask.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Ip4SubnetMask {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Ip4SubnetMask", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to IPv6 address of {0}.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_ip6_description {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_ip6_description", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to IPv6 Address.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Ip6Address {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Ip6Address", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to IPv6 link-local address.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Ip6Link {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Ip6Link", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to IPv6 site-local address.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Ip6Site {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Ip6Site", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to IPv6 temporary address.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Ip6Temp {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Ip6Temp", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to IPv6 unique local address.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Ip6Unique {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Ip6Unique", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Lock.
         /// </summary>
@@ -150,6 +339,51 @@ namespace Microsoft.PowerToys.Run.Plugin.System.Properties {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to Loopback.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Loopback {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Loopback", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to MAC address of {0} ({1}).
+        /// </summary>
+        internal static string Microsoft_plugin_sys_mac_description {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_mac_description", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to {0} Mbps.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Mbps {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Mbps", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Mobile broadband.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_MobileBroadband {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_MobileBroadband", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Physical address (MAC).
+        /// </summary>
+        internal static string Microsoft_plugin_sys_PhysicalAddress {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_PhysicalAddress", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Executes system commands (e.g. &apos;shutdown&apos;, &apos;lock&apos;, &apos;sleep&apos;)..
         /// </summary>
@@ -195,6 +429,15 @@ namespace Microsoft.PowerToys.Run.Plugin.System.Properties {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to ip; mac; address.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Search_NetworkKeywordList {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Search_NetworkKeywordList", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Shutdown.
         /// </summary>
@@ -276,6 +519,60 @@ namespace Microsoft.PowerToys.Run.Plugin.System.Properties {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to Speed.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Speed {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Speed", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to State.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_State {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_State", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Select to copy.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_SubTitle_CopyHint {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_SubTitle_CopyHint", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to DNS Suffix.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Suffix {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Suffix", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Tunnel.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_TunnelConnection {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_TunnelConnection", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Type.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Type {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Type", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to UEFI Firmware Settings.
         /// </summary>
@@ -303,6 +600,43 @@ namespace Microsoft.PowerToys.Run.Plugin.System.Properties {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to Unknown.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Unknown {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Unknown", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to WINS servers.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_Wins {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_Wins", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Wireless LAN.
+        /// </summary>
+        internal static string Microsoft_plugin_sys_WirelessLan {
+            get {
+                return ResourceManager.GetString("Microsoft_plugin_sys_WirelessLan", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Reduce the priority of &apos;IP&apos; and &apos;MAC&apos; results to improve the order in the global results
+        ///(With this setting enabled, you have to type more characters to find the results.).
+        /// </summary>
+        internal static string Reduce_Network_Result_Score {
+            get {
+                return ResourceManager.GetString("Reduce_Network_Result_Score", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Use localized system commands instead of English ones.
         /// </summary>

src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.System/Properties/Resources.resx

@@ -120,10 +120,41 @@
   <data name="confirm_system_commands" xml:space="preserve">
     <value>Show a dialog to confirm system commands</value>
   </data>
+  <data name="Microsoft_plugin_sys_AdapterDetails" xml:space="preserve">
+    <value>Adapter details</value>
+  </data>
+  <data name="Microsoft_plugin_sys_AdapterName" xml:space="preserve">
+    <value>Adapter name</value>
+  </data>
+  <data name="Microsoft_plugin_sys_Cable" xml:space="preserve">
+    <value>Cable</value>
+  </data>
   <data name="Microsoft_plugin_sys_confirmation" xml:space="preserve">
     <value>Please confirm.</value>
     <comment>Request confirmation</comment>
   </data>
+  <data name="Microsoft_plugin_sys_Connected" xml:space="preserve">
+    <value>Connected</value>
+  </data>
+  <data name="Microsoft_plugin_sys_ConnectionDetails" xml:space="preserve">
+    <value>Connection details</value>
+  </data>
+  <data name="Microsoft_plugin_sys_ConnectionName" xml:space="preserve">
+    <value>Connection name</value>
+  </data>
+  <data name="Microsoft_plugin_sys_CopyDetails" xml:space="preserve">
+    <value>Copy details (Ctrl+C)</value>
+    <comment>'Ctrl+C' is a shortcut</comment>
+  </data>
+  <data name="Microsoft_plugin_sys_Dhcp" xml:space="preserve">
+    <value>DHCP servers</value>
+  </data>
+  <data name="Microsoft_plugin_sys_Disconnected" xml:space="preserve">
+    <value>Disconnected</value>
+  </data>
+  <data name="Microsoft_plugin_sys_Dns" xml:space="preserve">
+    <value>DNS servers</value>
+  </data>
   <data name="Microsoft_plugin_sys_emptyrecyclebin" xml:space="preserve">
     <value>Empty Recycle Bin</value>
     <comment>This should align to the action in Windows of emptying the recycle bin on your computer.</comment>
@@ -132,6 +163,13 @@
     <value>Empty Recycle Bin</value>
     <comment>This should align to the action in Windows of emptying the recycle bin on your computer.</comment>
   </data>
+  <data name="Microsoft_plugin_sys_Gateways" xml:space="preserve">
+    <value>Default Gateway</value>
+  </data>
+  <data name="Microsoft_plugin_sys_Gbps" xml:space="preserve">
+    <value>{0} Gbps</value>
+    <comment>Abbreviation of 'Gbits per seconds'. Don't translate the placeholder '{0}' as it is replaced in code.</comment>
+  </data>
   <data name="Microsoft_plugin_sys_hibernate" xml:space="preserve">
     <value>Hibernate</value>
     <comment>This should align to the action in Windows of a hibernating your computer.</comment>
@@ -144,6 +182,35 @@
     <value>Hibernate computer</value>
     <comment>This should align to the action in Windows of a hibernating your computer.</comment>
   </data>
+  <data name="Microsoft_plugin_sys_Ip4Address" xml:space="preserve">
+    <value>IPv4 address</value>
+  </data>
+  <data name="Microsoft_plugin_sys_Ip4SubnetMask" xml:space="preserve">
+    <value>IPv4 subnet mask</value>
+  </data>
+  <data name="Microsoft_plugin_sys_ip4_description" xml:space="preserve">
+    <value>IPv4 address of {0}</value>
+    <comment>Don't translate the placeholder '{0}' as it is replaced in code.</comment>
+  </data>
+  <data name="Microsoft_plugin_sys_Ip6Address" xml:space="preserve">
+    <value>IPv6 Address</value>
+  </data>
+  <data name="Microsoft_plugin_sys_Ip6Link" xml:space="preserve">
+    <value>IPv6 link-local address</value>
+  </data>
+  <data name="Microsoft_plugin_sys_Ip6Site" xml:space="preserve">
+    <value>IPv6 site-local address</value>
+  </data>
+  <data name="Microsoft_plugin_sys_Ip6Temp" xml:space="preserve">
+    <value>IPv6 temporary address</value>
+  </data>
+  <data name="Microsoft_plugin_sys_Ip6Unique" xml:space="preserve">
+    <value>IPv6 unique local address</value>
+  </data>
+  <data name="Microsoft_plugin_sys_ip6_description" xml:space="preserve">
+    <value>IPv6 address of {0}</value>
+    <comment>Don't translate the placeholder '{0}' as it is replaced in code.</comment>
+  </data>
   <data name="Microsoft_plugin_sys_lock" xml:space="preserve">
     <value>Lock</value>
     <comment>This should align to the action in Windows of a locking your computer.</comment>
@@ -156,6 +223,23 @@
     <value>Lock computer</value>
     <comment>This should align to the action in Windows of a locking your computer.</comment>
   </data>
+  <data name="Microsoft_plugin_sys_Loopback" xml:space="preserve">
+    <value>Loopback</value>
+  </data>
+  <data name="Microsoft_plugin_sys_mac_description" xml:space="preserve">
+    <value>MAC address of {0} ({1})</value>
+    <comment>Don't translate the placeholders '{0}' and '{1}' as they are replaced in code.</comment>
+  </data>
+  <data name="Microsoft_plugin_sys_Mbps" xml:space="preserve">
+    <value>{0} Mbps</value>
+    <comment>Abbreviation of 'Mbits per seconds'. Don't translate the placeholder '{0}' as it is replaced in code.</comment>
+  </data>
+  <data name="Microsoft_plugin_sys_MobileBroadband" xml:space="preserve">
+    <value>Mobile broadband</value>
+  </data>
+  <data name="Microsoft_plugin_sys_PhysicalAddress" xml:space="preserve">
+    <value>Physical address (MAC)</value>
+  </data>
   <data name="Microsoft_plugin_sys_plugin_description" xml:space="preserve">
     <value>Executes system commands (e.g. 'shutdown', 'lock', 'sleep').</value>
     <comment>This should align to the actions in Windows relating to shutting down, signing out, locking, sleeping, restarting, emptying the recycle bin, and hibernating your computer. </comment>
@@ -176,6 +260,10 @@
     <value>Restart computer</value>
     <comment>This should align to the action in Windows of a restarting your computer.</comment>
   </data>
+  <data name="Microsoft_plugin_sys_Search_NetworkKeywordList" xml:space="preserve">
+    <value>ip; mac; address</value>
+    <comment>Translate 'ip' as 'ip' and not as 'ip address'. Same for 'mac'.)</comment>
+  </data>
   <data name="Microsoft_plugin_sys_shutdown_computer" xml:space="preserve">
     <value>Shutdown</value>
     <comment>This should align to the action in Windows of a shutting down your computer.</comment>
@@ -212,6 +300,24 @@
     <value>Put computer to sleep</value>
     <comment>This should align to the action in Windows of a making your computer go to sleep.</comment>
   </data>
+  <data name="Microsoft_plugin_sys_Speed" xml:space="preserve">
+    <value>Speed</value>
+  </data>
+  <data name="Microsoft_plugin_sys_State" xml:space="preserve">
+    <value>State</value>
+  </data>
+  <data name="Microsoft_plugin_sys_SubTitle_CopyHint" xml:space="preserve">
+    <value>Select to copy</value>
+  </data>
+  <data name="Microsoft_plugin_sys_Suffix" xml:space="preserve">
+    <value>DNS Suffix</value>
+  </data>
+  <data name="Microsoft_plugin_sys_TunnelConnection" xml:space="preserve">
+    <value>Tunnel</value>
+  </data>
+  <data name="Microsoft_plugin_sys_Type" xml:space="preserve">
+    <value>Type</value>
+  </data>
   <data name="Microsoft_plugin_sys_uefi" xml:space="preserve">
     <value>UEFI Firmware Settings</value>
     <comment>This should align to the action in Windows Recovery Environment that restart into uefi settings.</comment>
@@ -224,6 +330,19 @@
     <value>Reboot computer into UEFI Firmware Settings (Requires administrative permissions.)</value>
     <comment>This should align to the action in Windows Recovery Environment that restart into uefi settings.</comment>
   </data>
+  <data name="Microsoft_plugin_sys_Unknown" xml:space="preserve">
+    <value>Unknown</value>
+  </data>
+  <data name="Microsoft_plugin_sys_Wins" xml:space="preserve">
+    <value>WINS servers</value>
+  </data>
+  <data name="Microsoft_plugin_sys_WirelessLan" xml:space="preserve">
+    <value>Wireless LAN</value>
+  </data>
+  <data name="Reduce_Network_Result_Score" xml:space="preserve">
+    <value>Reduce the priority of 'IP' and 'MAC' results to improve the order in the global results
+(With this setting enabled, you have to type more characters to find the results.)</value>
+  </data>
   <data name="Use_localized_system_commands" xml:space="preserve">
     <value>Use localized system commands instead of English ones</value>
   </data>