From 403060e10982efbb91cbd06f5e4fe2811cb58165 Mon Sep 17 00:00:00 2001 From: Heiko <61519853+htcfreek@users.noreply.github.com> Date: Sun, 19 Jan 2025 15:32:46 +0100 Subject: [PATCH] [Settings]Update GPO infobar icon, improve some pages and fix bugs (#33703) * changes part 1 * fix xaml code * changes part 2 * fix cmdNotFound page * Update PowerOcrPage * More Pages changed * More Pages changed * revert temporary change * fix spelling * add resw comment * add resw comment * Update MouseWihtoutBorderPage.xaml * PowerPreview page * workspaces page * fix awake page gpo handling * NewPlus page * update new+ page! * AdvancedPaste.xaml: Move Info bar. * Update MouseJumpPanel.xaml * Update GeneralPage.xaml * fix position of info bar and some ui quirks * fix xaml style * fix string resources * string changes * prepare megre main * update new+ page * zoomit page * various fixes --- .../SettingsXAML/Panels/MouseJumpPanel.xaml | 8 +++- .../SettingsXAML/Views/AdvancedPaste.xaml | 33 ++++++++++----- .../SettingsXAML/Views/AlwaysOnTopPage.xaml | 6 ++- .../SettingsXAML/Views/AwakePage.xaml | 6 ++- .../SettingsXAML/Views/AwakePage.xaml.cs | 2 +- .../SettingsXAML/Views/CmdNotFoundPage.xaml | 40 ++++++++++++++----- .../SettingsXAML/Views/ColorPickerPage.xaml | 6 ++- .../SettingsXAML/Views/CropAndLockPage.xaml | 6 ++- .../Views/EnvironmentVariablesPage.xaml | 6 ++- .../SettingsXAML/Views/FancyZonesPage.xaml | 6 ++- .../SettingsXAML/Views/FileLocksmithPage.xaml | 6 ++- .../SettingsXAML/Views/GeneralPage.xaml | 37 ++++++++++------- .../SettingsXAML/Views/HostsPage.xaml | 6 ++- .../SettingsXAML/Views/ImageResizerPage.xaml | 6 ++- .../Views/KeyboardManagerPage.xaml | 6 ++- .../SettingsXAML/Views/MeasureToolPage.xaml | 6 ++- .../SettingsXAML/Views/MouseUtilsPage.xaml | 18 +++++++-- .../Views/MouseWithoutBordersPage.xaml | 22 +++++----- .../SettingsXAML/Views/NewPlusPage.xaml | 11 +++-- .../SettingsXAML/Views/PeekPage.xaml | 6 ++- .../SettingsXAML/Views/PowerAccentPage.xaml | 6 ++- .../SettingsXAML/Views/PowerLauncherPage.xaml | 12 +++++- .../SettingsXAML/Views/PowerOcrPage.xaml | 19 +++++---- .../SettingsXAML/Views/PowerPreviewPage.xaml | 12 +++++- .../SettingsXAML/Views/PowerRenamePage.xaml | 6 ++- .../Views/RegistryPreviewPage.xaml | 6 ++- .../SettingsXAML/Views/ShortcutGuidePage.xaml | 6 ++- .../SettingsXAML/Views/WorkspacesPage.xaml | 6 ++- .../SettingsXAML/Views/ZoomItPage.xaml | 26 ++++++------ .../Settings.UI/Strings/en-us/Resources.resw | 11 +++++ .../Settings.UI/ViewModels/AwakeViewModel.cs | 27 ++++++++++++- .../ViewModels/CmdNotFoundViewModel.cs | 19 +++++---- .../ViewModels/PowerOcrViewModel.cs | 6 +++ 33 files changed, 305 insertions(+), 100 deletions(-) diff --git a/src/settings-ui/Settings.UI/SettingsXAML/Panels/MouseJumpPanel.xaml b/src/settings-ui/Settings.UI/SettingsXAML/Panels/MouseJumpPanel.xaml index b92cf4d458..22d996efb2 100644 --- a/src/settings-ui/Settings.UI/SettingsXAML/Panels/MouseJumpPanel.xaml +++ b/src/settings-ui/Settings.UI/SettingsXAML/Panels/MouseJumpPanel.xaml @@ -35,7 +35,11 @@ IsClosable="False" IsOpen="{x:Bind ViewModel.IsJumpEnabledGpoConfigured, Mode=OneWay}" IsTabStop="{x:Bind ViewModel.IsJumpEnabledGpoConfigured, Mode=OneWay}" - Severity="Informational" /> + Severity="Informational"> + + + + - \ No newline at end of file + diff --git a/src/settings-ui/Settings.UI/SettingsXAML/Views/AdvancedPaste.xaml b/src/settings-ui/Settings.UI/SettingsXAML/Views/AdvancedPaste.xaml index 391a974efc..f6308feba6 100644 --- a/src/settings-ui/Settings.UI/SettingsXAML/Views/AdvancedPaste.xaml +++ b/src/settings-ui/Settings.UI/SettingsXAML/Views/AdvancedPaste.xaml @@ -56,9 +56,23 @@ IsClosable="False" IsOpen="{x:Bind ViewModel.IsEnabledGpoConfigured, Mode=OneWay}" IsTabStop="{x:Bind ViewModel.IsEnabledGpoConfigured, Mode=OneWay}" - Severity="Informational" /> + Severity="Informational"> + + + + + + + + + @@ -81,12 +95,6 @@ - - + Severity="Informational"> + + + + + + + + diff --git a/src/settings-ui/Settings.UI/SettingsXAML/Views/AlwaysOnTopPage.xaml b/src/settings-ui/Settings.UI/SettingsXAML/Views/AlwaysOnTopPage.xaml index aead2cb5eb..66cf570af0 100644 --- a/src/settings-ui/Settings.UI/SettingsXAML/Views/AlwaysOnTopPage.xaml +++ b/src/settings-ui/Settings.UI/SettingsXAML/Views/AlwaysOnTopPage.xaml @@ -27,7 +27,11 @@ IsClosable="False" IsOpen="{x:Bind ViewModel.IsEnabledGpoConfigured, Mode=OneWay}" IsTabStop="{x:Bind ViewModel.IsEnabledGpoConfigured, Mode=OneWay}" - Severity="Informational" /> + Severity="Informational"> + + + + + Severity="Informational"> + + + + diff --git a/src/settings-ui/Settings.UI/SettingsXAML/Views/AwakePage.xaml.cs b/src/settings-ui/Settings.UI/SettingsXAML/Views/AwakePage.xaml.cs index 49861c3c0b..3399f425cc 100644 --- a/src/settings-ui/Settings.UI/SettingsXAML/Views/AwakePage.xaml.cs +++ b/src/settings-ui/Settings.UI/SettingsXAML/Views/AwakePage.xaml.cs @@ -164,7 +164,7 @@ namespace Microsoft.PowerToys.Settings.UI.Views { // Get the enabled state from GPO. ViewModel.IsEnabledGpoConfigured = true; - ViewModel.IsEnabled = enabledGpoRuleConfiguration == GpoRuleConfigured.Enabled; + ViewModel.EnabledGPOConfiguration = enabledGpoRuleConfiguration == GpoRuleConfigured.Enabled; } else { diff --git a/src/settings-ui/Settings.UI/SettingsXAML/Views/CmdNotFoundPage.xaml b/src/settings-ui/Settings.UI/SettingsXAML/Views/CmdNotFoundPage.xaml index 649d306226..5c4a09a9c4 100644 --- a/src/settings-ui/Settings.UI/SettingsXAML/Views/CmdNotFoundPage.xaml +++ b/src/settings-ui/Settings.UI/SettingsXAML/Views/CmdNotFoundPage.xaml @@ -21,16 +21,29 @@ + IsOpen="{x:Bind ViewModel.IsModuleGpoEnabled, Mode=OneWay}" + IsTabStop="{x:Bind ViewModel.IsModuleGpoEnabled, Mode=OneWay}" + Severity="Informational"> + + + + + + + + + @@ -45,13 +58,17 @@ AutomationProperties.AccessibilityView="Raw" Foreground="{ThemeResource SystemFillColorSuccessBrush}" Glyph="" /> - +