New Utility: New+ (#33136)

Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>
Co-authored-by: Stefan Markovic <stefan@janeasystems.com>

src/common/Themes/theme_helpers.cpp

@@ -3,13 +3,23 @@
 #include "dwmapi.h"
 #include <windows.h>
 #include <vector>
-#pragma comment (lib,"Dwmapi.lib")
+#pragma comment(lib, "Dwmapi.lib")
 
 #define DWMWA_USE_IMMERSIVE_DARK_MODE 20
 #define HKEY_WINDOWS_THEME L"Software\\Microsoft\\Windows\\CurrentVersion\\Themes\\Personalize"
 
 // based on https://stackoverflow.com/questions/51334674/how-to-detect-windows-10-light-dark-mode-in-win32-application
-AppTheme ThemeHelpers::GetAppTheme()
+Theme ThemeHelpers::GetAppTheme()
+{
+    return ThemeRegistryHelper(L"AppsUseLightTheme");
+}
+
+Theme ThemeHelpers::GetSystemTheme()
+{
+    return ThemeRegistryHelper(L"SystemUsesLightTheme");
+}
+
+Theme ThemeHelpers::ThemeRegistryHelper(LPCWSTR theme_key)
 {
     // The value is expected to be a REG_DWORD, which is a signed 32-bit little-endian
     auto buffer = std::vector<char>(4);
@@ -17,21 +27,22 @@ AppTheme ThemeHelpers::GetAppTheme()
     auto res = RegGetValueW(
         HKEY_CURRENT_USER,
         HKEY_WINDOWS_THEME,
-        L"AppsUseLightTheme",
-        RRF_RT_REG_DWORD, // expected value type
+        theme_key,
+        RRF_RT_REG_DWORD,
         nullptr,
         buffer.data(),
         &cbData);
 
     if (res != ERROR_SUCCESS)
     {
-        return AppTheme::Light;
+        // Defaulting to Light
+        return Theme::Light;
     }
 
     // convert bytes written to our buffer to an int, assuming little-endian
     auto i = static_cast<int>(buffer[3] << 24 | buffer[2] << 16 | buffer[1] << 8 | buffer[0]);
 
-    return AppTheme(i);
+    return Theme(i);
 }
 
 void ThemeHelpers::SetImmersiveDarkMode(HWND window, bool enabled)

src/common/Themes/theme_helpers.h

@@ -1,7 +1,7 @@
 #pragma once
 #include <windows.h>
 
-enum class AppTheme
+enum class Theme
 {
     Dark = 0,
     Light = 1
@@ -9,6 +9,10 @@ enum class AppTheme
 
 struct ThemeHelpers
 {
-    static AppTheme GetAppTheme();
-    static void ThemeHelpers::SetImmersiveDarkMode(HWND window, bool enabled);
+    static Theme GetAppTheme();
+    static Theme GetSystemTheme();
+    static void SetImmersiveDarkMode(HWND window, bool enabled);
+
+protected:
+    static Theme ThemeRegistryHelper(LPCWSTR theme_key);
 };

src/common/Themes/theme_listener.h

@@ -22,7 +22,7 @@ public:
         dwThreadId = 0;
     }
 
-    AppTheme AppTheme;
+    Theme AppTheme;
     void ThemeListener::AddChangedHandler(THEME_HANDLE handle);
     void ThemeListener::DelChangedHandler(THEME_HANDLE handle);
     void CheckTheme();

src/common/Themes/windows_colors.cpp

@@ -66,7 +66,7 @@ WindowsColors::Color WindowsColors::get_background_color()
 
 bool WindowsColors::is_dark_mode()
 {
-    return ThemeHelpers::GetAppTheme() == AppTheme::Dark;
+    return ThemeHelpers::GetAppTheme() == Theme::Dark;
 }
 
 bool WindowsColors::update()