From 3e0d62d10137977cf45cc685ffbc5f830beebac1 Mon Sep 17 00:00:00 2001 From: Alex Mihaiuc <69110671+foxmsft@users.noreply.github.com> Date: Thu, 9 Oct 2025 16:55:44 +0200 Subject: [PATCH] Reinstate ZoomIt branding (#42230) This pull request restores dynamic branding and versioning for the ZoomIt subproject. ## Summary of the Pull Request ## PR Checklist - [ ] Closes: #xxx - [x] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments It was deleted by mistake in the previous commit. ## Validation Steps Performed What was broken and this PR changes: image Fixed behavior now, in PowerToys (official version up, with the changes this commit overrides down): image Fixed behavior now, standalone: image --- src/modules/ZoomIt/ZoomIt/ZoomIt.rc | 31 ++++++++++++++++++----------- 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/src/modules/ZoomIt/ZoomIt/ZoomIt.rc b/src/modules/ZoomIt/ZoomIt/ZoomIt.rc index 8b8cab11eb..382c93208e 100644 --- a/src/modules/ZoomIt/ZoomIt/ZoomIt.rc +++ b/src/modules/ZoomIt/ZoomIt/ZoomIt.rc @@ -2,6 +2,13 @@ // #include "resource.h" +// version.h and branding.h are different in the Sysinternals repository, +// keep the includes as such, here. +// From $(MSBuildThisFileDirectory)..\..\..\common\version +#include "version.h" +// From $(MSBuildThisFileDirectory)PowerToys +#include "branding.h" + #define APSTUDIO_READONLY_SYMBOLS ///////////////////////////////////////////////////////////////////////////// // @@ -68,8 +75,8 @@ APPICON ICON "appicon.ico" // VS_VERSION_INFO VERSIONINFO - FILEVERSION 9,10,0,0 - PRODUCTVERSION 9,10,0,0 + FILEVERSION FILE_VERSION + PRODUCTVERSION PRODUCT_VERSION FILEFLAGSMASK 0x3fL #ifdef _DEBUG FILEFLAGS 0x1L @@ -84,14 +91,14 @@ BEGIN BEGIN BLOCK "040904b0" BEGIN - VALUE "CompanyName", "Microsoft Corporation" - VALUE "FileDescription", "Sysinternals Screen Magnifier" - VALUE "FileVersion", "9.10" - VALUE "InternalName", "ZoomIt" - VALUE "LegalCopyright", "Copyright (C) Microsoft Corporation. All rights reserved." - VALUE "OriginalFilename", "PowerToys.ZoomIt.exe" - VALUE "ProductName", "PowerToys Sysinternals ZoomIt" - VALUE "ProductVersion", "9.10" + VALUE "CompanyName", COMPANY_NAME + VALUE "FileDescription", FILE_DESCRIPTION + VALUE "FileVersion", FILE_VERSION_STRING + VALUE "InternalName", INTERNAL_NAME + VALUE "LegalCopyright", COPYRIGHT_NOTE + VALUE "OriginalFilename", ORIGINAL_FILENAME + VALUE "ProductName", ZOOMIT_PRODUCT_NAME + VALUE "ProductVersion", PRODUCT_VERSION_STRING END END BLOCK "VarFileInfo" @@ -114,8 +121,8 @@ FONT 8, "MS Shell Dlg", 0, 0, 0x0 BEGIN DEFPUSHBUTTON "OK",IDOK,166,306,50,14 PUSHBUTTON "Cancel",IDCANCEL,223,306,50,14 - LTEXT "ZoomIt v9.01",IDC_VERSION,42,7,73,10 - LTEXT "Copyright � 2006-2025 Mark Russinovich",IDC_COPYRIGHT,42,17,231,8 + LTEXT "ZoomIt v9.10",IDC_VERSION,42,7,73,10 + LTEXT "Copyright © 2006-2025 Mark Russinovich",IDC_COPYRIGHT,42,17,231,8 CONTROL "Sysinternals - www.sysinternals.com",IDC_LINK, "SysLink",WS_TABSTOP,42,26,150,9 ICON "APPICON",IDC_STATIC,12,9,20,20