From 3cc7c4da0b2468230849fec2054669d8628fa0c9 Mon Sep 17 00:00:00 2001
From: Clint Rutkas <clint@rutkas.com>
Date: Wed, 22 Nov 2023 09:52:32 -0800
Subject: [PATCH] [Build][CI]SDL and SHA tweaks for dll creation (#29973)

* Shifting to versions.prop so everyone has it by default

* Forcing SDL check on

* specter should be in the props file
---
 Cpp.Build.props   | 4 ++--
 src/Version.props | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/Cpp.Build.props b/Cpp.Build.props
index 3279750b33..b98ae459a6 100644
--- a/Cpp.Build.props
+++ b/Cpp.Build.props
@@ -63,6 +63,7 @@
       <!-- CLR + CFG are not compatible >:{ -->
       <ControlFlowGuard Condition="'$(CLRSupport)' == ''">Guard</ControlFlowGuard>
       <DebugInformationFormat Condition="'%(ControlFlowGuard)' == 'Guard'">ProgramDatabase</DebugInformationFormat>
+      <SDLCheck>true</SDLCheck>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>
@@ -77,7 +78,6 @@
     <ClCompile>
       <PreprocessorDefinitions>_DEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <Optimization>Disabled</Optimization>
-      <SDLCheck>true</SDLCheck>
       <RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
     </ClCompile>
     <Link>
@@ -88,7 +88,6 @@
     <ClCompile>
       <PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <Optimization>MaxSpeed</Optimization>
-      <SDLCheck>false</SDLCheck>
       <RuntimeLibrary>MultiThreaded</RuntimeLibrary>
       <FunctionLevelLinking>true</FunctionLevelLinking>
       <IntrinsicFunctions>true</IntrinsicFunctions>
@@ -113,6 +112,7 @@
     <PlatformToolset Condition="'$(OverridePlatformToolset)'!='True'">v143</PlatformToolset>
     <CharacterSet>Unicode</CharacterSet>
     <DesktopCompatible>true</DesktopCompatible>
+    <SpectreMitigation>Spectre</SpectreMitigation>
   </PropertyGroup>
 
   <!-- Debug/Release props -->
diff --git a/src/Version.props b/src/Version.props
index 6b54dbd99a..2042a73fbd 100644
--- a/src/Version.props
+++ b/src/Version.props
@@ -3,5 +3,8 @@
   <PropertyGroup>
     <Version>0.0.1</Version>
     <DevEnvironment>Local</DevEnvironment>
+
+    <!-- Forcing for every DLL on by default -->
+    <ChecksumAlgorithm>SHA256</ChecksumAlgorithm>
   </PropertyGroup>
 </Project>