Detect potential errors copying metadata and avoid them (#2447) (#6997)

src/modules/imageresizer/tests/ImageResizerUITest.csproj

@@ -123,6 +123,9 @@
     <Content Include="Test.png">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </Content>
+    <Content Include="TestMetadataIssue2447.jpg">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </Content>
     <Content Include="TestPortrait.png">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </Content>

src/modules/imageresizer/tests/Models/ResizeOperationTests.cs

@@ -30,6 +30,18 @@ namespace ImageResizer.Models
                 image => Assert.Equal("Test", ((BitmapMetadata)image.Frames[0].Metadata).Comment));
         }
 
+        [Fact]
+        public void ExecuteCopiesFrameMetadataExceptWhenMetadataCannotBeCloned()
+        {
+            var operation = new ResizeOperation("TestMetadataIssue2447.jpg", _directory, Settings());
+
+            operation.Execute();
+
+            AssertEx.Image(
+                _directory.File(),
+                image => Assert.Null(((BitmapMetadata)image.Frames[0].Metadata).CameraModel));
+        }
+
         [Fact]
         public void ExecuteKeepsDateModified()
         {

src/modules/imageresizer/ui/Models/ResizeOperation.cs

@@ -64,11 +64,25 @@ namespace ImageResizer.Models
 
                 foreach (var originalFrame in decoder.Frames)
                 {
+                    BitmapMetadata metadata = (BitmapMetadata)originalFrame.Metadata;
+                    if (metadata != null)
+                    {
+                        try
+                        {
+                            // Detect whether metadata can copied successfully
+                            _ = metadata.Clone();
+                        }
+                        catch (ArgumentException)
+                        {
+                            metadata = null;
+                        }
+                    }
+
                     encoder.Frames.Add(
                         BitmapFrame.Create(
                             Transform(originalFrame),
                             thumbnail: null,
-                            (BitmapMetadata)originalFrame.Metadata, // TODO: Add an option to strip any metadata that doesn't affect rendering (issue #3)
+                            metadata, // TODO: Add an option to strip any metadata that doesn't affect rendering (issue #3)
                             colorContexts: null));
                 }