Address feedback

This commit is contained in:
Sekan, Tobias
2020-11-03 21:36:11 +01:00
parent dc2751aa38
commit 36f55ae80c

View File

@@ -73,11 +73,8 @@ namespace Microsoft.PowerToys.Settings.UI.Library.ViewModels
get => _isEnabled; get => _isEnabled;
set set
{ {
if (_isEnabled == value) if (_isEnabled != value)
{ {
return;
}
_isEnabled = value; _isEnabled = value;
OnPropertyChanged(nameof(IsEnabled)); OnPropertyChanged(nameof(IsEnabled));
@@ -88,54 +85,49 @@ namespace Microsoft.PowerToys.Settings.UI.Library.ViewModels
SendConfigMSG(outgoing.ToString()); SendConfigMSG(outgoing.ToString());
} }
} }
}
public bool ChangeCursor public bool ChangeCursor
{ {
get => _colorPickerSettings.Properties.ChangeCursor; get => _colorPickerSettings.Properties.ChangeCursor;
set set
{ {
if (_colorPickerSettings.Properties.ChangeCursor == value) if (_colorPickerSettings.Properties.ChangeCursor != value)
{ {
return;
}
_colorPickerSettings.Properties.ChangeCursor = value; _colorPickerSettings.Properties.ChangeCursor = value;
OnPropertyChanged(nameof(ChangeCursor)); OnPropertyChanged(nameof(ChangeCursor));
NotifySettingsChanged(); NotifySettingsChanged();
} }
} }
}
public HotkeySettings ActivationShortcut public HotkeySettings ActivationShortcut
{ {
get => _colorPickerSettings.Properties.ActivationShortcut; get => _colorPickerSettings.Properties.ActivationShortcut;
set set
{ {
if (_colorPickerSettings.Properties.ActivationShortcut == value) if (_colorPickerSettings.Properties.ActivationShortcut != value)
{ {
return;
}
_colorPickerSettings.Properties.ActivationShortcut = value; _colorPickerSettings.Properties.ActivationShortcut = value;
OnPropertyChanged(nameof(ActivationShortcut)); OnPropertyChanged(nameof(ActivationShortcut));
NotifySettingsChanged(); NotifySettingsChanged();
} }
} }
}
public ColorRepresentationType SelectedColorRepresentationValue public ColorRepresentationType SelectedColorRepresentationValue
{ {
get => _colorPickerSettings.Properties.CopiedColorRepresentation; get => _colorPickerSettings.Properties.CopiedColorRepresentation;
set set
{ {
if (_colorPickerSettings.Properties.CopiedColorRepresentation == value) if (_colorPickerSettings.Properties.CopiedColorRepresentation != value)
{ {
return;
}
_colorPickerSettings.Properties.CopiedColorRepresentation = value; _colorPickerSettings.Properties.CopiedColorRepresentation = value;
OnPropertyChanged(nameof(SelectedColorRepresentationValue)); OnPropertyChanged(nameof(SelectedColorRepresentationValue));
NotifySettingsChanged(); NotifySettingsChanged();
} }
} }
}
private void NotifySettingsChanged() private void NotifySettingsChanged()
{ {