From 353aeb268ba454e5d5ed0408670e9e87d8a642b6 Mon Sep 17 00:00:00 2001
From: seraphima <zykovas91@gmail.com>
Date: Thu, 4 Jul 2024 11:43:12 +0200
Subject: [PATCH] localizable default project prefix

---
 .../Projects/ProjectsSnapshotTool/NameUtils.h   |   9 ++++-----
 .../ProjectsSnapshotTool.vcxproj                |  11 +++++++++--
 .../ProjectsSnapshotTool.vcxproj.filters        |  16 ++++++++++++----
 ...rc => ProjectsSnapshotToolResources.base.rc} | Bin
 .../Resource.resx                               |   2 +-
 .../{resource.h => resource.base.h}             |   0
 6 files changed, 26 insertions(+), 12 deletions(-)
 rename src/modules/Projects/ProjectsSnapshotTool/{ProjectsSnapshotTool.rc => ProjectsSnapshotToolResources.base.rc} (100%)
 rename src/modules/Projects/{ProjectsLib => ProjectsSnapshotTool}/Resource.resx (98%)
 rename src/modules/Projects/ProjectsSnapshotTool/{resource.h => resource.base.h} (100%)

diff --git a/src/modules/Projects/ProjectsSnapshotTool/NameUtils.h b/src/modules/Projects/ProjectsSnapshotTool/NameUtils.h
index 868209ec56..734c3164f0 100644
--- a/src/modules/Projects/ProjectsSnapshotTool/NameUtils.h
+++ b/src/modules/Projects/ProjectsSnapshotTool/NameUtils.h
@@ -1,16 +1,15 @@
 #pragma once
 
-#include <string>
-#include <vector>
-
 #include <projects-common/Data.h>
 
+#include <common/utils/resources.h>
+#include "Generated Files/resource.h"
+
 namespace ProjectNameUtils
 {
     inline std::wstring CreateProjectName(const std::vector<Project>& projects)
     {
-        // new project name
-        std::wstring defaultNamePrefix = L"Project"; // TODO: localizable
+        std::wstring defaultNamePrefix = GET_RESOURCE_STRING(IDS_DEFAULTPROJECTNAMEPREFIX);
         int nextProjectIndex = 0;
         for (const auto& proj : projects)
         {
diff --git a/src/modules/Projects/ProjectsSnapshotTool/ProjectsSnapshotTool.vcxproj b/src/modules/Projects/ProjectsSnapshotTool/ProjectsSnapshotTool.vcxproj
index 35396b5ada..6bfa72ecf9 100644
--- a/src/modules/Projects/ProjectsSnapshotTool/ProjectsSnapshotTool.vcxproj
+++ b/src/modules/Projects/ProjectsSnapshotTool/ProjectsSnapshotTool.vcxproj
@@ -3,6 +3,9 @@
   <!-- Project configurations -->
   <!-- Props that should be disabled while building on CI server -->
   <Import Project="..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.props')" />
+  <Target Name="GenerateResourceFiles" BeforeTargets="PrepareForBuild">
+    <Exec Command="powershell -NonInteractive -executionpolicy Unrestricted $(SolutionDir)tools\build\convert-resx-to-rc.ps1 $(MSBuildThisFileDirectory) resource.base.h resource.h ProjectsSnapshotToolResources.base.rc ProjectsSnapshotToolResources.rc" />
+  </Target>
   <!-- C++ source compile-specific things for all configurations -->
   <ItemDefinitionGroup>
     <ClCompile>
@@ -133,7 +136,7 @@
     <ClInclude Include="JsonUtils.h" />
     <ClInclude Include="NameUtils.h" />
     <ClInclude Include="pch.h" />
-    <ClInclude Include="resource.h" />
+    <ClInclude Include="resource.base.h" />
     <ClInclude Include="SnapshotUtils.h" />
   </ItemGroup>
   <ItemGroup>
@@ -151,7 +154,11 @@
     </ProjectReference>
   </ItemGroup>
   <ItemGroup>
-    <ResourceCompile Include="ProjectsSnapshotTool.rc" />
+    <ResourceCompile Include="Generated Files/ProjectsSnapshotToolResources.rc" />
+    <None Include="ProjectsSnapshotToolResources.base.rc" />
+  </ItemGroup>
+  <ItemGroup>
+    <EmbeddedResource Include="Resource.resx" />
   </ItemGroup>
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
   <Import Project="..\..\..\..\deps\spdlog.props" />
diff --git a/src/modules/Projects/ProjectsSnapshotTool/ProjectsSnapshotTool.vcxproj.filters b/src/modules/Projects/ProjectsSnapshotTool/ProjectsSnapshotTool.vcxproj.filters
index b7af4120cc..e2fe55ad94 100644
--- a/src/modules/Projects/ProjectsSnapshotTool/ProjectsSnapshotTool.vcxproj.filters
+++ b/src/modules/Projects/ProjectsSnapshotTool/ProjectsSnapshotTool.vcxproj.filters
@@ -18,9 +18,6 @@
     <ClInclude Include="pch.h">
       <Filter>Header Files</Filter>
     </ClInclude>
-    <ClInclude Include="resource.h">
-      <Filter>Header Files</Filter>
-    </ClInclude>
     <ClInclude Include="NameUtils.h">
       <Filter>Header Files</Filter>
     </ClInclude>
@@ -30,6 +27,9 @@
     <ClInclude Include="SnapshotUtils.h">
       <Filter>Header Files</Filter>
     </ClInclude>
+    <ClInclude Include="resource.base.h">
+      <Filter>Header Files</Filter>
+    </ClInclude>
   </ItemGroup>
   <ItemGroup>
     <ClCompile Include="pch.cpp">
@@ -44,9 +44,17 @@
   </ItemGroup>
   <ItemGroup>
     <None Include="packages.config" />
+    <None Include="ProjectsSnapshotToolResources.base.rc">
+      <Filter>Resource Files</Filter>
+    </None>
   </ItemGroup>
   <ItemGroup>
-    <ResourceCompile Include="ProjectsSnapshotTool.rc">
+    <EmbeddedResource Include="Resource.resx">
+      <Filter>Resource Files</Filter>
+    </EmbeddedResource>
+  </ItemGroup>
+  <ItemGroup>
+    <ResourceCompile Include="Generated Files/ProjectsSnapshotToolResources.rc">
       <Filter>Resource Files</Filter>
     </ResourceCompile>
   </ItemGroup>
diff --git a/src/modules/Projects/ProjectsSnapshotTool/ProjectsSnapshotTool.rc b/src/modules/Projects/ProjectsSnapshotTool/ProjectsSnapshotToolResources.base.rc
similarity index 100%
rename from src/modules/Projects/ProjectsSnapshotTool/ProjectsSnapshotTool.rc
rename to src/modules/Projects/ProjectsSnapshotTool/ProjectsSnapshotToolResources.base.rc
diff --git a/src/modules/Projects/ProjectsLib/Resource.resx b/src/modules/Projects/ProjectsSnapshotTool/Resource.resx
similarity index 98%
rename from src/modules/Projects/ProjectsLib/Resource.resx
rename to src/modules/Projects/ProjectsSnapshotTool/Resource.resx
index 087c56e9e9..4c8a6b3d8b 100644
--- a/src/modules/Projects/ProjectsLib/Resource.resx
+++ b/src/modules/Projects/ProjectsSnapshotTool/Resource.resx
@@ -117,7 +117,7 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
-  <data name="DefaultProjectName" xml:space="preserve">
+  <data name="DefaultProjectNamePrefix" xml:space="preserve">
     <value>Project</value>
   </data>
 </root>
\ No newline at end of file
diff --git a/src/modules/Projects/ProjectsSnapshotTool/resource.h b/src/modules/Projects/ProjectsSnapshotTool/resource.base.h
similarity index 100%
rename from src/modules/Projects/ProjectsSnapshotTool/resource.h
rename to src/modules/Projects/ProjectsSnapshotTool/resource.base.h