mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-09 04:37:30 +02:00
Fix accessibility issues related to the General Settings page (#6034)
* grouped radio buttons together * grouping radio buttons together * the word version is now read along with the version number * Information regarding the image is read * added a comment with the link to the issue in the winui repository
This commit is contained in:
@@ -360,6 +360,9 @@
|
|||||||
<data name="GeneralPage_AboutPowerToysHeader.Text" xml:space="preserve">
|
<data name="GeneralPage_AboutPowerToysHeader.Text" xml:space="preserve">
|
||||||
<value>About PowerToys</value>
|
<value>About PowerToys</value>
|
||||||
</data>
|
</data>
|
||||||
|
<data name="PowerToys_Icon.AutomationProperties.Name" xml:space="preserve">
|
||||||
|
<value>PowerToys Icon</value>
|
||||||
|
</data>
|
||||||
<data name="GeneralPage_CheckForUpdates.Content" xml:space="preserve">
|
<data name="GeneralPage_CheckForUpdates.Content" xml:space="preserve">
|
||||||
<value>Check for updates</value>
|
<value>Check for updates</value>
|
||||||
</data>
|
</data>
|
||||||
@@ -396,7 +399,7 @@
|
|||||||
<data name="PowerRename_Toggle_Enable.Header" xml:space="preserve">
|
<data name="PowerRename_Toggle_Enable.Header" xml:space="preserve">
|
||||||
<value>Enable PowerRename</value>
|
<value>Enable PowerRename</value>
|
||||||
</data>
|
</data>
|
||||||
<data name="RadioButtons_Name_Theme.Header" xml:space="preserve">
|
<data name="RadioButtons_Name_Theme.Text" xml:space="preserve">
|
||||||
<value>Settings theme</value>
|
<value>Settings theme</value>
|
||||||
</data>
|
</data>
|
||||||
<data name="PowerRename_Toggle_EnableOnContextMenu.Header" xml:space="preserve">
|
<data name="PowerRename_Toggle_EnableOnContextMenu.Header" xml:space="preserve">
|
||||||
|
|||||||
@@ -82,8 +82,12 @@
|
|||||||
<TextBlock x:Uid="ShortcutGuide_Appearance_Behavior"
|
<TextBlock x:Uid="ShortcutGuide_Appearance_Behavior"
|
||||||
Style="{StaticResource SettingsGroupTitleStyle}"/>
|
Style="{StaticResource SettingsGroupTitleStyle}"/>
|
||||||
|
|
||||||
<muxc:RadioButtons x:Uid="RadioButtons_Name_Theme"
|
<!-- Replaced the Radiobuttons parent control with a StackPanel to mitigate the Tab and Arrow key related keyboard navigation issues due to XAML Islands
|
||||||
Margin="{StaticResource SmallTopMargin}">
|
Tracking issue in the winui repository - https://github.com/microsoft/microsoft-ui-xaml/issues/3156 -->
|
||||||
|
<TextBlock Name="RadioButtons_Name_Theme"
|
||||||
|
x:Uid="RadioButtons_Name_Theme"
|
||||||
|
Margin="{StaticResource SmallTopMargin}"/>
|
||||||
|
<StackPanel AutomationProperties.LabeledBy="{Binding ElementName=RadioButtons_Name_Theme}">
|
||||||
<RadioButton x:Uid="GeneralPage_Radio_Theme_Dark"
|
<RadioButton x:Uid="GeneralPage_Radio_Theme_Dark"
|
||||||
Content="Dark"
|
Content="Dark"
|
||||||
IsChecked="{ Binding Mode=TwoWay, Path=IsDarkThemeRadioButtonChecked}"/>
|
IsChecked="{ Binding Mode=TwoWay, Path=IsDarkThemeRadioButtonChecked}"/>
|
||||||
@@ -95,7 +99,7 @@
|
|||||||
<RadioButton x:Uid="GeneralPage_Radio_Theme_Default"
|
<RadioButton x:Uid="GeneralPage_Radio_Theme_Default"
|
||||||
Content="System default"
|
Content="System default"
|
||||||
IsChecked="{ Binding Mode=TwoWay, Path=IsSystemThemeRadioButtonChecked}"/>
|
IsChecked="{ Binding Mode=TwoWay, Path=IsSystemThemeRadioButtonChecked}"/>
|
||||||
</muxc:RadioButtons>
|
</StackPanel>
|
||||||
|
|
||||||
<ToggleSwitch x:Uid="GeneralPage_ToggleSwitch_RunAtStartUp"
|
<ToggleSwitch x:Uid="GeneralPage_ToggleSwitch_RunAtStartUp"
|
||||||
Margin="{StaticResource SmallTopMargin}"
|
Margin="{StaticResource SmallTopMargin}"
|
||||||
@@ -105,7 +109,9 @@
|
|||||||
|
|
||||||
<TextBlock x:Uid="General_Updates"
|
<TextBlock x:Uid="General_Updates"
|
||||||
Style="{StaticResource SettingsGroupTitleStyle}"/>
|
Style="{StaticResource SettingsGroupTitleStyle}"/>
|
||||||
<StackPanel Orientation="Horizontal" Margin="{StaticResource SmallTopMargin}">
|
<StackPanel Orientation="Horizontal"
|
||||||
|
Margin="{StaticResource SmallTopMargin}"
|
||||||
|
AutomationProperties.LabeledBy="{Binding ElementName=General_Version}">
|
||||||
<TextBlock Text="Version: " x:Uid="General_Version" />
|
<TextBlock Text="Version: " x:Uid="General_Version" />
|
||||||
<HyperlinkButton NavigateUri="https://github.com/microsoft/PowerToys/releases" Margin="4,-6,0,0">
|
<HyperlinkButton NavigateUri="https://github.com/microsoft/PowerToys/releases" Margin="4,-6,0,0">
|
||||||
<TextBlock Text="{x:Bind ViewModel.PowerToysVersion }" />
|
<TextBlock Text="{x:Bind ViewModel.PowerToysVersion }" />
|
||||||
@@ -146,7 +152,7 @@
|
|||||||
HorizontalAlignment="Left"
|
HorizontalAlignment="Left"
|
||||||
Margin="{StaticResource SmallTopBottomMargin}"
|
Margin="{StaticResource SmallTopBottomMargin}"
|
||||||
RelativePanel.Below="DescriptionPanel">
|
RelativePanel.Below="DescriptionPanel">
|
||||||
<Image Source="ms-appx:///Assets/Modules/PT.png" />
|
<Image x:Uid="PowerToys_Icon" Source="ms-appx:///Assets/Modules/PT.png"/>
|
||||||
</Border>
|
</Border>
|
||||||
<StackPanel x:Name="LinksPanel"
|
<StackPanel x:Name="LinksPanel"
|
||||||
Margin="0,1,0,0"
|
Margin="0,1,0,0"
|
||||||
|
|||||||
Reference in New Issue
Block a user