mirror of
https://github.com/microsoft/PowerToys.git
synced 2025-12-16 11:48:06 +01:00
CmdPal: Hide RDC fallback item by default (#43994)
## Summary of the Pull Request This fixes few nits with RDC extension: - hides the RDC fallback item from the home page when there’s no query; - fixes MSTSC process working directory (must physically exists or be an empty string) <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed
This commit is contained in:
@@ -73,13 +73,11 @@ public class FallbackRemoteDesktopItemTests
|
|||||||
fallback.UpdateQuery(" ");
|
fallback.UpdateQuery(" ");
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
Assert.AreEqual(Resources.remotedesktop_command_open, fallback.Title);
|
Assert.AreEqual(string.Empty, fallback.Title);
|
||||||
Assert.AreEqual(string.Empty, fallback.Subtitle);
|
Assert.AreEqual(string.Empty, fallback.Subtitle);
|
||||||
|
|
||||||
var command = fallback.Command as OpenRemoteDesktopCommand;
|
var command = fallback.Command as OpenRemoteDesktopCommand;
|
||||||
Assert.IsNotNull(command);
|
Assert.IsNull(command);
|
||||||
Assert.AreEqual(Resources.remotedesktop_command_open, command.Name);
|
|
||||||
Assert.AreEqual(string.Empty, GetCommandHost(command));
|
|
||||||
}
|
}
|
||||||
|
|
||||||
[TestMethod]
|
[TestMethod]
|
||||||
@@ -93,13 +91,11 @@ public class FallbackRemoteDesktopItemTests
|
|||||||
fallback.UpdateQuery("not a valid host");
|
fallback.UpdateQuery("not a valid host");
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
Assert.AreEqual(Resources.remotedesktop_command_open, fallback.Title);
|
Assert.AreEqual(string.Empty, fallback.Title);
|
||||||
Assert.AreEqual(string.Empty, fallback.Subtitle);
|
Assert.AreEqual(string.Empty, fallback.Subtitle);
|
||||||
|
|
||||||
var command = fallback.Command as OpenRemoteDesktopCommand;
|
var command = fallback.Command as OpenRemoteDesktopCommand;
|
||||||
Assert.IsNotNull(command);
|
Assert.IsNull(command);
|
||||||
Assert.AreEqual(Resources.remotedesktop_command_open, command.Name);
|
|
||||||
Assert.AreEqual(string.Empty, GetCommandHost(command));
|
|
||||||
}
|
}
|
||||||
|
|
||||||
private static string GetCommandHost(OpenRemoteDesktopCommand command)
|
private static string GetCommandHost(OpenRemoteDesktopCommand command)
|
||||||
|
|||||||
@@ -23,13 +23,16 @@ internal sealed partial class FallbackRemoteDesktopItem : FallbackCommandItem
|
|||||||
];
|
];
|
||||||
|
|
||||||
private static readonly CompositeFormat RemoteDesktopOpenHostFormat = CompositeFormat.Parse(Resources.remotedesktop_open_host);
|
private static readonly CompositeFormat RemoteDesktopOpenHostFormat = CompositeFormat.Parse(Resources.remotedesktop_open_host);
|
||||||
|
|
||||||
private readonly IRdpConnectionsManager _rdpConnectionsManager;
|
private readonly IRdpConnectionsManager _rdpConnectionsManager;
|
||||||
|
private readonly NoOpCommand _emptyCommand = new NoOpCommand();
|
||||||
|
|
||||||
public FallbackRemoteDesktopItem(IRdpConnectionsManager rdpConnectionsManager)
|
public FallbackRemoteDesktopItem(IRdpConnectionsManager rdpConnectionsManager)
|
||||||
: base(new OpenRemoteDesktopCommand(string.Empty), Resources.remotedesktop_title)
|
: base(Resources.remotedesktop_title)
|
||||||
{
|
{
|
||||||
_rdpConnectionsManager = rdpConnectionsManager;
|
_rdpConnectionsManager = rdpConnectionsManager;
|
||||||
|
|
||||||
|
Command = _emptyCommand;
|
||||||
Title = string.Empty;
|
Title = string.Empty;
|
||||||
Subtitle = string.Empty;
|
Subtitle = string.Empty;
|
||||||
Icon = Icons.RDPIcon;
|
Icon = Icons.RDPIcon;
|
||||||
@@ -41,7 +44,7 @@ internal sealed partial class FallbackRemoteDesktopItem : FallbackCommandItem
|
|||||||
{
|
{
|
||||||
Title = string.Empty;
|
Title = string.Empty;
|
||||||
Subtitle = string.Empty;
|
Subtitle = string.Empty;
|
||||||
Command = new OpenRemoteDesktopCommand(string.Empty);
|
Command = _emptyCommand;
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -68,7 +71,7 @@ internal sealed partial class FallbackRemoteDesktopItem : FallbackCommandItem
|
|||||||
{
|
{
|
||||||
Title = string.Empty;
|
Title = string.Empty;
|
||||||
Subtitle = string.Empty;
|
Subtitle = string.Empty;
|
||||||
Command = new OpenRemoteDesktopCommand(string.Empty);
|
Command = _emptyCommand;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -40,7 +40,7 @@ internal sealed partial class OpenRemoteDesktopCommand : BaseObservable, IInvoka
|
|||||||
{
|
{
|
||||||
using var process = new Process();
|
using var process = new Process();
|
||||||
process.StartInfo.UseShellExecute = false;
|
process.StartInfo.UseShellExecute = false;
|
||||||
process.StartInfo.WorkingDirectory = Environment.SpecialFolder.MyDocuments.ToString();
|
process.StartInfo.WorkingDirectory = Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments);
|
||||||
process.StartInfo.FileName = "mstsc";
|
process.StartInfo.FileName = "mstsc";
|
||||||
|
|
||||||
if (!string.IsNullOrWhiteSpace(_rdpHost))
|
if (!string.IsNullOrWhiteSpace(_rdpHost))
|
||||||
|
|||||||
@@ -6,7 +6,12 @@ namespace Microsoft.CommandPalette.Extensions.Toolkit;
|
|||||||
|
|
||||||
public partial class FallbackCommandItem : CommandItem, IFallbackCommandItem, IFallbackHandler
|
public partial class FallbackCommandItem : CommandItem, IFallbackCommandItem, IFallbackHandler
|
||||||
{
|
{
|
||||||
private IFallbackHandler? _fallbackHandler;
|
private readonly IFallbackHandler? _fallbackHandler;
|
||||||
|
|
||||||
|
public FallbackCommandItem(string displayTitle)
|
||||||
|
{
|
||||||
|
DisplayTitle = displayTitle;
|
||||||
|
}
|
||||||
|
|
||||||
public FallbackCommandItem(ICommand command, string displayTitle)
|
public FallbackCommandItem(ICommand command, string displayTitle)
|
||||||
: base(command)
|
: base(command)
|
||||||
|
|||||||
Reference in New Issue
Block a user