Create unit tests for Calculator plugin (#6356)

* Refactored logic and made it unit testable

* Changes after code review

* Added to build steps, and modified bracket to new class with unittest. Validates complexer cases now.

Co-authored-by: p-storm <paul.de.man@gmail.com>

src/modules/launcher/Plugins/Microsoft.Plugin.Calculator/Main.cs

@@ -5,11 +5,6 @@
 using System;
 using System.Collections.Generic;
 using System.Globalization;
-using System.Runtime.InteropServices;
-using System.Text.RegularExpressions;
-using System.Threading;
-using System.Windows;
-using Mages.Core;
 using Wox.Infrastructure.Logger;
 using Wox.Plugin;
 
@@ -17,18 +12,7 @@ namespace Microsoft.Plugin.Calculator
 {
     public class Main : IPlugin, IPluginI18n, IDisposable
     {
-        private static readonly Regex RegValidExpressChar = new Regex(
-                        @"^(" +
-                        @"ceil|floor|exp|pi|e|max|min|det|abs|log|ln|sqrt|" +
-                        @"sin|cos|tan|arcsin|arccos|arctan|" +
-                        @"eigval|eigvec|eig|sum|polar|plot|round|sort|real|zeta|" +
-                        @"bin2dec|hex2dec|oct2dec|" +
-                        @"==|~=|&&|\|\||" +
-                        @"[ei]|[0-9]|[\+\-\*\/\^\., ""]|[\(\)\|\!\[\]]" +
-                        @")+$", RegexOptions.Compiled);
-
-        private static readonly Regex RegBrackets = new Regex(@"[\(\)\[\]]", RegexOptions.Compiled);
-        private static readonly Engine MagesEngine = new Engine();
+        private static readonly CalculateEngine CalculateEngine = new CalculateEngine();
 
         private PluginInitContext Context { get; set; }
 
@@ -43,68 +27,25 @@ namespace Microsoft.Plugin.Calculator
                 throw new ArgumentNullException(paramName: nameof(query));
             }
 
-            if (query.Search.Length <= 2 // don't affect when user only input "e" or "i" keyword
-                || !RegValidExpressChar.IsMatch(query.Search)
-                || !IsBracketComplete(query.Search))
+            if (!CalculateHelper.InputValid(query.Search))
             {
                 return new List<Result>();
             }
 
             try
             {
-                var result = MagesEngine.Interpret(query.Search);
+                var result = CalculateEngine.Interpret(query.Search, CultureInfo.CurrentUICulture);
 
                 // This could happen for some incorrect queries, like pi(2)
-                if (result == null)
+                if (result.Equals(default(CalculateResult)))
                 {
                     return new List<Result>();
                 }
 
-                if (result.ToString() == "NaN")
+                return new List<Result>
                 {
-                    result = Properties.Resources.wox_plugin_calculator_not_a_number;
-                }
-
-                if (result is Function)
-                {
-                    result = Properties.Resources.wox_plugin_calculator_expression_not_complete;
-                }
-
-                if (!string.IsNullOrEmpty(result?.ToString()))
-                {
-                    var roundedResult = Math.Round(Convert.ToDecimal(result, CultureInfo.CurrentCulture), 10, MidpointRounding.AwayFromZero);
-
-                    return new List<Result>
-                    {
-                        new Result
-                        {
-                            Title = roundedResult.ToString(CultureInfo.CurrentCulture),
-                            IcoPath = IconPath,
-                            Score = 300,
-                            SubTitle = Properties.Resources.wox_plugin_calculator_copy_number_to_clipboard,
-                            Action = c =>
-                            {
-                                var ret = false;
-                                var thread = new Thread(() =>
-                                {
-                                    try
-                                    {
-                                        Clipboard.SetText(result.ToString());
-                                        ret = true;
-                                    }
-                                    catch (ExternalException)
-                                    {
-                                        MessageBox.Show(Properties.Resources.wox_plugin_calculator_copy_failed);
-                                    }
-                                });
-                                thread.SetApartmentState(ApartmentState.STA);
-                                thread.Start();
-                                thread.Join();
-                                return ret;
-                            },
-                        },
-                    };
-                }
+                    ResultHelper.CreateResult(result.Result, result.RoundedResult, IconPath),
+                };
             } // We want to keep the process alive if any the mages library throws any exceptions.
 #pragma warning disable CA1031 // Do not catch general exception types
             catch (Exception e)
@@ -116,25 +57,6 @@ namespace Microsoft.Plugin.Calculator
             return new List<Result>();
         }
 
-        private static bool IsBracketComplete(string query)
-        {
-            var matchs = RegBrackets.Matches(query);
-            var leftBracketCount = 0;
-            foreach (Match match in matchs)
-            {
-                if (match.Value == "(" || match.Value == "[")
-                {
-                    leftBracketCount++;
-                }
-                else
-                {
-                    leftBracketCount--;
-                }
-            }
-
-            return leftBracketCount == 0;
-        }
-
         public void Init(PluginInitContext context)
         {
             Context = context ?? throw new ArgumentNullException(paramName: nameof(context));