Non localized module name (#7170)

* Added get_key to powertoysmodule interface

* Replace get_name with get_key

* Implement get_key function in modules

* Make key global constant in each module

* Update settings v1 to use key to load and save files

* Fixed fancyzones and preview pane unit tests

* Removed setings unit test as the case is not covered anymore

* Add constant files for modules and use it to reference module key

* Add constant string files to colorpicker, launcher and shortcut guide

* correct sunction signature in settings helper

* Fix powerpreview merge conflicts

* nit fix with include statement location

* add check for fields in from_json_string

* Updated preview pane tests with correct from_json_string signature

* Correct Image resizer naming

* Roll back changes for adding check for property and version

* Fix image resizer not working

src/modules/shortcut_guide/ShortcutGuideConstants.h

@@ -0,0 +1,8 @@
+#pragma once
+#include <string>
+
+namespace ShortcutGuideConstants
+{
+    // Name of the powertoy module.
+    inline const std::wstring ModuleKey = L"Shortcut Guide";
+}

src/modules/shortcut_guide/shortcut_guide.cpp

@@ -7,6 +7,7 @@
 #include <common/settings_objects.h>
 #include <common/debug_control.h>
 #include <sstream>
+#include <modules\shortcut_guide\ShortcutGuideConstants.h>
 
 extern "C" IMAGE_DOS_HEADER __ImageBase;
 
@@ -94,14 +95,22 @@ namespace
 OverlayWindow::OverlayWindow()
 {
     app_name = GET_RESOURCE_STRING(IDS_SHORTCUT_GUIDE);
+    app_key = ShortcutGuideConstants::ModuleKey;
     init_settings();
 }
 
+// Return the localized display name of the powertoy
 const wchar_t* OverlayWindow::get_name()
 {
     return app_name.c_str();
 }
 
+// Return the non localized key of the powertoy, this will be cached by the runner
+const wchar_t* OverlayWindow::get_key()
+{
+    return app_key.c_str();
+}
+
 bool OverlayWindow::get_config(wchar_t* buffer, int* buffer_size)
 {
     HINSTANCE hinstance = reinterpret_cast<HINSTANCE>(&__ImageBase);
@@ -142,7 +151,7 @@ void OverlayWindow::set_config(const wchar_t* config)
     {
         // save configuration
         PowerToysSettings::PowerToyValues _values =
-            PowerToysSettings::PowerToyValues::from_json_string(config);
+            PowerToysSettings::PowerToyValues::from_json_string(config, get_key());
         _values.save_to_settings_file();
         Trace::SettingsChanged(pressTime.value, overlayOpacity.value, theme.value);
 
@@ -331,7 +340,7 @@ void OverlayWindow::init_settings()
     try
     {
         PowerToysSettings::PowerToyValues settings =
-            PowerToysSettings::PowerToyValues::load_from_settings_file(OverlayWindow::get_name());
+            PowerToysSettings::PowerToyValues::load_from_settings_file(OverlayWindow::get_key());
         if (const auto val = settings.get_int_value(pressTime.name))
         {
             pressTime.value = *val;

src/modules/shortcut_guide/shortcut_guide.h

@@ -17,6 +17,7 @@ public:
     OverlayWindow();
 
     virtual const wchar_t* get_name() override;
+    virtual const wchar_t* get_key() override;
     virtual bool get_config(wchar_t* buffer, int* buffer_size) override;
 
     virtual void set_config(const wchar_t* config) override;
@@ -37,6 +38,8 @@ public:
 
 private:
     std::wstring app_name;
+    //contains the non localized key of the powertoy
+    std::wstring app_key;
     std::unique_ptr<TargetState> target_state;
     std::unique_ptr<D2DOverlayWindow> winkey_popup;
     bool _enabled = false;

src/modules/shortcut_guide/shortcut_guide.vcxproj

@@ -109,6 +109,7 @@
     <ClInclude Include="keyboard_state.h" />
     <ClInclude Include="Generated Files/resource.h" />
     <None Include="resource.base.h" />
+    <ClInclude Include="ShortcutGuideConstants.h" />
     <ClInclude Include="shortcut_guide.h" />
     <ClInclude Include="pch.h" />
     <ClInclude Include="target_state.h" />