mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-05 18:57:19 +02:00
Non localized module name (#7170)
* Added get_key to powertoysmodule interface * Replace get_name with get_key * Implement get_key function in modules * Make key global constant in each module * Update settings v1 to use key to load and save files * Fixed fancyzones and preview pane unit tests * Removed setings unit test as the case is not covered anymore * Add constant files for modules and use it to reference module key * Add constant string files to colorpicker, launcher and shortcut guide * correct sunction signature in settings helper * Fix powerpreview merge conflicts * nit fix with include statement location * add check for fields in from_json_string * Updated preview pane tests with correct from_json_string signature * Correct Image resizer naming * Roll back changes for adding check for property and version * Fix image resizer not working
This commit is contained in:
committed by
GitHub
parent
8b759094f7
commit
280d1907d8
11
src/modules/imageresizer/dll/ImageResizerConstants.h
Normal file
11
src/modules/imageresizer/dll/ImageResizerConstants.h
Normal file
@@ -0,0 +1,11 @@
|
||||
#pragma once
|
||||
#include <string>
|
||||
|
||||
namespace ImageResizerConstants
|
||||
{
|
||||
// Name of the powertoy module.
|
||||
inline const std::wstring ModuleKey = L"Image Resizer";
|
||||
|
||||
// Name of the ImageResizer save folder.
|
||||
inline const std::wstring ModuleSaveFolderKey = L"ImageResizer";
|
||||
}
|
||||
@@ -162,6 +162,7 @@
|
||||
<ClInclude Include="HDropIterator.h" />
|
||||
<ClInclude Include="dllmain.h" />
|
||||
<None Include="resource.base.h" />
|
||||
<ClInclude Include="ImageResizerConstants.h" />
|
||||
<ClInclude Include="Settings.h" />
|
||||
<ClInclude Include="Generated Files/resource.h" />
|
||||
<ClInclude Include="ImageResizerExt_i.h" />
|
||||
|
||||
@@ -5,6 +5,7 @@
|
||||
#include <common/settings_helpers.h>
|
||||
#include <filesystem>
|
||||
#include <commctrl.h>
|
||||
#include <imageresizer\dll\ImageResizerConstants.h>
|
||||
|
||||
namespace
|
||||
{
|
||||
@@ -44,7 +45,7 @@ namespace
|
||||
|
||||
CSettings::CSettings()
|
||||
{
|
||||
std::wstring result = PTSettingsHelper::get_module_save_folder_location(L"ImageResizer");
|
||||
std::wstring result = PTSettingsHelper::get_module_save_folder_location(ImageResizerConstants::ModuleSaveFolderKey);
|
||||
jsonFilePath = result + std::wstring(c_imageResizerDataFilePath);
|
||||
Load();
|
||||
}
|
||||
|
||||
@@ -7,6 +7,7 @@
|
||||
#include "Settings.h"
|
||||
#include "trace.h"
|
||||
#include <common/common.h>
|
||||
#include <imageresizer\dll\ImageResizerConstants.h>
|
||||
|
||||
CImageResizerExtModule _AtlModule;
|
||||
HINSTANCE g_hInst_imageResizer = 0;
|
||||
@@ -32,6 +33,8 @@ private:
|
||||
// Enabled by default
|
||||
bool m_enabled = true;
|
||||
std::wstring app_name;
|
||||
//contains the non localized key of the powertoy
|
||||
std::wstring app_key;
|
||||
|
||||
public:
|
||||
// Constructor
|
||||
@@ -39,6 +42,7 @@ public:
|
||||
{
|
||||
m_enabled = CSettingsInstance().GetEnabled();
|
||||
app_name = GET_RESOURCE_STRING(IDS_IMAGERESIZER);
|
||||
app_key = ImageResizerConstants::ModuleKey;
|
||||
};
|
||||
|
||||
// Destroy the powertoy and free memory
|
||||
@@ -47,12 +51,18 @@ public:
|
||||
delete this;
|
||||
}
|
||||
|
||||
// Return the display name of the powertoy, this will be cached by the runner
|
||||
// Return the localized display name of the powertoy
|
||||
virtual const wchar_t* get_name() override
|
||||
{
|
||||
return app_name.c_str();
|
||||
}
|
||||
|
||||
// Return the non localized key of the powertoy, this will be cached by the runner
|
||||
virtual const wchar_t* get_key() override
|
||||
{
|
||||
return app_key.c_str();
|
||||
}
|
||||
|
||||
// Return JSON with the configuration options.
|
||||
virtual bool get_config(wchar_t* buffer, int* buffer_size) override
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user