From 21d68c7998c834951223997f9ec458b292d09dc6 Mon Sep 17 00:00:00 2001 From: Niels Laute Date: Mon, 19 Apr 2021 12:42:36 +0200 Subject: [PATCH] [OOBE] Accessibility fixes (#10799) * Narrator support for all Settings buttons * Shortened welcome title * Fixes * Removed unused string * Update src/settings-ui/Microsoft.PowerToys.Settings.UI/Strings/en-us/Resources.resw Co-authored-by: Niels Laute Co-authored-by: Enrico Giordani --- .../OOBE/Views/OobeColorPicker.xaml | 10 +++++++--- .../OOBE/Views/OobeFancyZones.xaml | 10 +++++++--- .../OOBE/Views/OobeFileExplorer.xaml | 7 +++++-- .../OOBE/Views/OobeImageResizer.xaml | 8 ++++++-- .../OOBE/Views/OobeKBM.xaml | 8 ++++++-- .../OOBE/Views/OobeOverview.xaml | 16 +++++++++------- .../OOBE/Views/OobePowerRename.xaml | 8 ++++++-- .../OOBE/Views/OobeRun.xaml | 10 +++++++--- .../OOBE/Views/OobeShellPage.xaml | 1 + .../OOBE/Views/OobeShortcutGuide.xaml | 7 +++++-- .../OOBE/Views/OobeVideoConference.xaml | 7 +++++-- .../Strings/en-us/Resources.resw | 5 ++--- 12 files changed, 66 insertions(+), 31 deletions(-) diff --git a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeColorPicker.xaml b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeColorPicker.xaml index 597e67482a..8bc40337a1 100644 --- a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeColorPicker.xaml +++ b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeColorPicker.xaml @@ -25,6 +25,7 @@ VerticalAlignment="Top"> + AutomationProperties.HeadingLevel="Level3" + Style="{StaticResource OobeSubtitleStyle}"/> @@ -57,13 +60,14 @@ - diff --git a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeFancyZones.xaml b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeFancyZones.xaml index a00e44ca12..d509e58f35 100644 --- a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeFancyZones.xaml +++ b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeFancyZones.xaml @@ -24,6 +24,7 @@ Margin="{StaticResource OobePageContentMargin}" VerticalAlignment="Top"> - + @@ -51,13 +54,14 @@ - diff --git a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeFileExplorer.xaml b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeFileExplorer.xaml index 91ad457373..9d9c77ce57 100644 --- a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeFileExplorer.xaml +++ b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeFileExplorer.xaml @@ -24,6 +24,7 @@ VerticalAlignment="Top"> @@ -47,13 +49,14 @@ Spacing="4" Margin="0,32,0,0"> - diff --git a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeImageResizer.xaml b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeImageResizer.xaml index 25f6c14d6c..1a497a9474 100644 --- a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeImageResizer.xaml +++ b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeImageResizer.xaml @@ -25,6 +25,7 @@ VerticalAlignment="Top"> @@ -52,13 +55,14 @@ - diff --git a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeKBM.xaml b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeKBM.xaml index d1e5353911..37c2c7a2f2 100644 --- a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeKBM.xaml +++ b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeKBM.xaml @@ -24,6 +24,7 @@ VerticalAlignment="Top"> @@ -51,13 +54,14 @@ - diff --git a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeOverview.xaml b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeOverview.xaml index 61d9aa2c9a..e70ca06054 100644 --- a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeOverview.xaml +++ b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeOverview.xaml @@ -23,13 +23,13 @@ VerticalAlignment="Top"> - + @@ -43,13 +43,15 @@ diff --git a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobePowerRename.xaml b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobePowerRename.xaml index 17f4d5ecb9..7009860602 100644 --- a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobePowerRename.xaml +++ b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobePowerRename.xaml @@ -24,6 +24,7 @@ VerticalAlignment="Top"> - diff --git a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeRun.xaml b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeRun.xaml index 53736a5456..85861c8bda 100644 --- a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeRun.xaml +++ b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeRun.xaml @@ -25,6 +25,7 @@ VerticalAlignment="Top"> - + @@ -61,13 +64,14 @@ - diff --git a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeShellPage.xaml b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeShellPage.xaml index 9f0ee9296a..eb7c1bb039 100644 --- a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeShellPage.xaml +++ b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeShellPage.xaml @@ -58,6 +58,7 @@ diff --git a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeShortcutGuide.xaml b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeShortcutGuide.xaml index e0d2210ec6..1189789327 100644 --- a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeShortcutGuide.xaml +++ b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeShortcutGuide.xaml @@ -25,6 +25,7 @@ VerticalAlignment="Top"> @@ -54,13 +56,14 @@ - diff --git a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeVideoConference.xaml b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeVideoConference.xaml index 4e309a3fe2..9291f8aeec 100644 --- a/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeVideoConference.xaml +++ b/src/settings-ui/Microsoft.PowerToys.Settings.UI/OOBE/Views/OobeVideoConference.xaml @@ -25,6 +25,7 @@ VerticalAlignment="Top"> @@ -47,13 +49,14 @@ - diff --git a/src/settings-ui/Microsoft.PowerToys.Settings.UI/Strings/en-us/Resources.resw b/src/settings-ui/Microsoft.PowerToys.Settings.UI/Strings/en-us/Resources.resw index 90b78b431a..79f8919cf3 100644 --- a/src/settings-ui/Microsoft.PowerToys.Settings.UI/Strings/en-us/Resources.resw +++ b/src/settings-ui/Microsoft.PowerToys.Settings.UI/Strings/en-us/Resources.resw @@ -1147,8 +1147,7 @@ From there, simply click on a Markdown file or SVG icon in the File Explorer and Do not localize this string - Welcome to PowerToys - Do not localize 'PowerToys' + Welcome Settings @@ -1196,4 +1195,4 @@ From there, simply click on a Markdown file or SVG icon in the File Explorer and Quick layout switch - \ No newline at end of file +