common: refactor common library pt2 (#8588)

- remove common lib
- split settings, remove common-md
- move ipc interop/kb_layout to interop
- rename core -> settings, settings -> old_settings
- os-detect header-only; interop -> PowerToysInterop
- split notifications, move single-use headers where they're used
- winstore lib
- rename com utils
- rename Updating and Telemetry projects
- rename core -> settings-ui and remove examples folder
- rename settings-ui folder + consisent common/version include

src/settings-ui/Microsoft.PowerToys.Settings.UI.UnitTests/ViewModelTests/General.cs

@@ -0,0 +1,254 @@
+// Copyright (c) Microsoft Corporation
+// The Microsoft Corporation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using System;
+using Microsoft.PowerToys.Settings.UI.Library;
+using Microsoft.PowerToys.Settings.UI.Library.ViewModels;
+using Microsoft.PowerToys.Settings.UI.UnitTests.BackwardsCompatibility;
+using Microsoft.PowerToys.Settings.UI.UnitTests.Mocks;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+using Moq;
+using JsonSerializer = System.Text.Json.JsonSerializer;
+
+namespace ViewModelTests
+{
+    [TestClass]
+    public class General
+    {
+        public const string GeneralSettingsFileName = "Test\\GeneralSettings";
+
+        private Mock<ISettingsUtils> mockGeneralSettingsUtils;
+
+        [TestInitialize]
+        public void SetUpStubSettingUtils()
+        {
+            mockGeneralSettingsUtils = ISettingsUtilsMocks.GetStubSettingsUtils<GeneralSettings>();
+        }
+
+        [TestMethod]
+        [DataRow("v0.18.2")]
+        [DataRow("v0.19.2")]
+        [DataRow("v0.20.1")]
+        [DataRow("v0.21.1")]
+        [DataRow("v0.22.0")]
+        public void OriginalFilesModificationTest(string version)
+        {
+            var settingPathMock = new Mock<ISettingsPath>();
+            var fileMock = BackCompatTestProperties.GetGeneralSettingsIOProvider(version);
+
+            var mockGeneralSettingsUtils = new SettingsUtils(fileMock.Object, settingPathMock.Object);
+            GeneralSettings originalGeneralSettings = mockGeneralSettingsUtils.GetSettings<GeneralSettings>();
+
+            var generalSettingsRepository = new BackCompatTestProperties.MockSettingsRepository<GeneralSettings>(mockGeneralSettingsUtils);
+
+            // Initialise View Model with test Config files
+            // Arrange
+            Func<string, int> sendMockIPCConfigMSG = msg => 0;
+            Func<string, int> sendRestartAdminIPCMessage = msg => 0;
+            Func<string, int> sendCheckForUpdatesIPCMessage = msg => 0;
+            var viewModel = new GeneralViewModel(
+                settingsRepository: generalSettingsRepository,
+                runAsAdminText: "GeneralSettings_RunningAsAdminText",
+                runAsUserText: "GeneralSettings_RunningAsUserText",
+                isElevated: false,
+                isAdmin: false,
+                updateTheme: UpdateUIThemeMethod,
+                ipcMSGCallBackFunc: sendMockIPCConfigMSG,
+                ipcMSGRestartAsAdminMSGCallBackFunc: sendRestartAdminIPCMessage,
+                ipcMSGCheckForUpdatesCallBackFunc: sendCheckForUpdatesIPCMessage,
+                configFileSubfolder: string.Empty);
+
+            // Verify that the old settings persisted
+            Assert.AreEqual(originalGeneralSettings.AutoDownloadUpdates, viewModel.AutoDownloadUpdates);
+            Assert.AreEqual(originalGeneralSettings.Packaged, viewModel.Packaged);
+            Assert.AreEqual(originalGeneralSettings.PowertoysVersion, viewModel.PowerToysVersion);
+            Assert.AreEqual(originalGeneralSettings.RunElevated, viewModel.RunElevated);
+            Assert.AreEqual(originalGeneralSettings.Startup, viewModel.Startup);
+
+            // Verify that the stub file was used
+            var expectedCallCount = 2;  // once via the view model, and once by the test (GetSettings<T>)
+            BackCompatTestProperties.VerifyGeneralSettingsIOProviderWasRead(fileMock, expectedCallCount);
+        }
+
+        [TestMethod]
+        public void IsElevatedShouldUpdateRunasAdminStatusAttrsWhenSuccessful()
+        {
+            // Arrange
+            Func<string, int> sendMockIPCConfigMSG = msg => { return 0; };
+            Func<string, int> sendRestartAdminIPCMessage = msg => { return 0; };
+            Func<string, int> sendCheckForUpdatesIPCMessage = msg => { return 0; };
+            GeneralViewModel viewModel = new GeneralViewModel(
+                settingsRepository: SettingsRepository<GeneralSettings>.GetInstance(mockGeneralSettingsUtils.Object),
+                "GeneralSettings_RunningAsAdminText",
+                "GeneralSettings_RunningAsUserText",
+                false,
+                false,
+                UpdateUIThemeMethod,
+                sendMockIPCConfigMSG,
+                sendRestartAdminIPCMessage,
+                sendCheckForUpdatesIPCMessage,
+                GeneralSettingsFileName);
+
+            Assert.AreEqual(viewModel.RunningAsUserDefaultText, viewModel.RunningAsText);
+            Assert.IsFalse(viewModel.IsElevated);
+
+            // Act
+            viewModel.IsElevated = true;
+
+            // Assert
+            Assert.AreEqual(viewModel.RunningAsAdminDefaultText, viewModel.RunningAsText);
+            Assert.IsTrue(viewModel.IsElevated);
+        }
+
+        [TestMethod]
+        public void StartupShouldEnableRunOnStartUpWhenSuccessful()
+        {
+            // Assert
+            Func<string, int> sendMockIPCConfigMSG = msg =>
+            {
+                OutGoingGeneralSettings snd = JsonSerializer.Deserialize<OutGoingGeneralSettings>(msg);
+                Assert.IsTrue(snd.GeneralSettings.Startup);
+                return 0;
+            };
+
+            // Arrange
+            Func<string, int> sendRestartAdminIPCMessage = msg => { return 0; };
+            Func<string, int> sendCheckForUpdatesIPCMessage = msg => { return 0; };
+            GeneralViewModel viewModel = new GeneralViewModel(
+                settingsRepository: SettingsRepository<GeneralSettings>.GetInstance(mockGeneralSettingsUtils.Object),
+                "GeneralSettings_RunningAsAdminText",
+                "GeneralSettings_RunningAsUserText",
+                false,
+                false,
+                UpdateUIThemeMethod,
+                sendMockIPCConfigMSG,
+                sendRestartAdminIPCMessage,
+                sendCheckForUpdatesIPCMessage,
+                GeneralSettingsFileName);
+            Assert.IsFalse(viewModel.Startup);
+
+            // act
+            viewModel.Startup = true;
+        }
+
+        [TestMethod]
+        public void RunElevatedShouldEnableAlwaysRunElevatedWhenSuccessful()
+        {
+            // Assert
+            Func<string, int> sendMockIPCConfigMSG = msg =>
+            {
+                OutGoingGeneralSettings snd = JsonSerializer.Deserialize<OutGoingGeneralSettings>(msg);
+                Assert.IsTrue(snd.GeneralSettings.RunElevated);
+                return 0;
+            };
+
+            Func<string, int> sendRestartAdminIPCMessage = msg => { return 0; };
+            Func<string, int> sendCheckForUpdatesIPCMessage = msg => { return 0; };
+
+            // Arrange
+            GeneralViewModel viewModel = new GeneralViewModel(
+                settingsRepository: SettingsRepository<GeneralSettings>.GetInstance(mockGeneralSettingsUtils.Object),
+                "GeneralSettings_RunningAsAdminText",
+                "GeneralSettings_RunningAsUserText",
+                false,
+                false,
+                UpdateUIThemeMethod,
+                sendMockIPCConfigMSG,
+                sendRestartAdminIPCMessage,
+                sendCheckForUpdatesIPCMessage,
+                GeneralSettingsFileName);
+
+            Assert.IsFalse(viewModel.RunElevated);
+
+            // act
+            viewModel.RunElevated = true;
+        }
+
+        [TestMethod]
+        public void IsLightThemeRadioButtonCheckedShouldThemeToLightWhenSuccessful()
+        {
+            // Arrange
+            GeneralViewModel viewModel = null;
+
+            // Assert
+            Func<string, int> sendMockIPCConfigMSG = msg =>
+            {
+                OutGoingGeneralSettings snd = JsonSerializer.Deserialize<OutGoingGeneralSettings>(msg);
+                Assert.AreEqual("light", snd.GeneralSettings.Theme);
+                return 0;
+            };
+
+            Func<string, int> sendRestartAdminIPCMessage = msg => { return 0; };
+            Func<string, int> sendCheckForUpdatesIPCMessage = msg => { return 0; };
+            viewModel = new GeneralViewModel(
+                settingsRepository: SettingsRepository<GeneralSettings>.GetInstance(mockGeneralSettingsUtils.Object),
+                "GeneralSettings_RunningAsAdminText",
+                "GeneralSettings_RunningAsUserText",
+                false,
+                false,
+                UpdateUIThemeMethod,
+                sendMockIPCConfigMSG,
+                sendRestartAdminIPCMessage,
+                sendCheckForUpdatesIPCMessage,
+                GeneralSettingsFileName);
+            Assert.IsFalse(viewModel.IsLightThemeRadioButtonChecked);
+
+            // act
+            viewModel.IsLightThemeRadioButtonChecked = true;
+        }
+
+        [TestMethod]
+        public void IsDarkThemeRadioButtonCheckedShouldThemeToDarkWhenSuccessful()
+        {
+            // Arrange
+            // Assert
+            Func<string, int> sendMockIPCConfigMSG = msg =>
+            {
+                OutGoingGeneralSettings snd = JsonSerializer.Deserialize<OutGoingGeneralSettings>(msg);
+                Assert.AreEqual("dark", snd.GeneralSettings.Theme);
+                return 0;
+            };
+
+            Func<string, int> sendRestartAdminIPCMessage = msg => { return 0; };
+            Func<string, int> sendCheckForUpdatesIPCMessage = msg => { return 0; };
+            GeneralViewModel viewModel = new GeneralViewModel(
+                settingsRepository: SettingsRepository<GeneralSettings>.GetInstance(mockGeneralSettingsUtils.Object),
+                "GeneralSettings_RunningAsAdminText",
+                "GeneralSettings_RunningAsUserText",
+                false,
+                false,
+                UpdateUIThemeMethod,
+                sendMockIPCConfigMSG,
+                sendRestartAdminIPCMessage,
+                sendCheckForUpdatesIPCMessage,
+                GeneralSettingsFileName);
+            Assert.IsFalse(viewModel.IsDarkThemeRadioButtonChecked);
+
+            // act
+            viewModel.IsDarkThemeRadioButtonChecked = true;
+        }
+
+        [TestMethod]
+        public void AllModulesAreEnabledByDefault()
+        {
+            // arrange
+            EnabledModules modules = new EnabledModules();
+
+            // Assert
+            Assert.IsTrue(modules.FancyZones);
+            Assert.IsTrue(modules.ImageResizer);
+            Assert.IsTrue(modules.FileExplorerPreview);
+            Assert.IsTrue(modules.ShortcutGuide);
+            Assert.IsTrue(modules.PowerRename);
+            Assert.IsTrue(modules.KeyboardManager);
+            Assert.IsTrue(modules.PowerLauncher);
+            Assert.IsTrue(modules.ColorPicker);
+        }
+
+        public static int UpdateUIThemeMethod(string themeName)
+        {
+            return 0;
+        }
+    }
+}