From 2075f9fa71da5ae008f35560cb081c6a395c0668 Mon Sep 17 00:00:00 2001
From: ryanbodrug-microsoft
 <56318517+ryanbodrug-microsoft@users.noreply.github.com>
Date: Tue, 25 Aug 2020 09:07:44 -0700
Subject: [PATCH] Comparing exepected vs actual json strings.  This fixes two
 issues. (#6145)

1) the same variables are being compared against each other.
2) BasePTSettingsTest doesn't override equals to Equals compares the objects. This change compares the json strings directly.
---
 .../ModelsTests/SettingsUtilsTests.cs                         | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ModelsTests/SettingsUtilsTests.cs b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ModelsTests/SettingsUtilsTests.cs
index dcb83fcba8..1122c3845d 100644
--- a/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ModelsTests/SettingsUtilsTests.cs
+++ b/src/core/Microsoft.PowerToys.Settings.UI.UnitTests/ModelsTests/SettingsUtilsTests.cs
@@ -48,7 +48,7 @@ namespace CommonLibTest
             BasePTSettingsTest actual_json = SettingsUtils.GetSettings<BasePTSettingsTest>(file_name);
 
             // Assert
-            Assert.IsTrue(actual_json.Equals(actual_json));
+            Assert.AreEqual(expected_json.ToJsonString(), actual_json.ToJsonString());
         }
 
         [TestMethod]
@@ -70,7 +70,7 @@ namespace CommonLibTest
             BasePTSettingsTest actual_json = SettingsUtils.GetSettings<BasePTSettingsTest>(file_name);
 
             // Assert
-            Assert.IsTrue(actual_json.Equals(actual_json));
+            Assert.AreEqual(expected_json.ToJsonString(), actual_json.ToJsonString());
         }
 
         [TestMethod]