Removing unecceary EventName requirement. EventSource<T>.Write will use the type name of T if null is passed in. This saves us passing an extra string uneccesarily as the public property would be serialized into the event data as well as being specified as the EventName

This commit is contained in:
ryanbodrug-microsoft
2020-05-05 12:17:26 -07:00
parent b4d75e3240
commit 1f9c1ce8e4
19 changed files with 56 additions and 100 deletions

View File

@@ -1,16 +0,0 @@
using System;
using System.Collections.Generic;
using System.Diagnostics.Tracing;
using System.Text;
using Microsoft.PowerToys.Telemetry;
namespace Microsoft.PowerLauncher.Telemetry
{
[EventData]
public class BootEvent : IEvent
{
public string EventName { get; } = "PowerLauncher_Boot_Event";
public double BootTimeMs { get; set; }
}
}

View File

@@ -1,14 +0,0 @@
using System;
using System.Collections.Generic;
using System.Diagnostics.Tracing;
using System.Text;
using Microsoft.PowerToys.Telemetry;
namespace Microsoft.PowerLauncher.Telemetry
{
[EventData]
public class FirstDeleteEvent : IEvent
{
public string EventName { get; } = "PowerLauncher_FirstDelete_Event";
}
}

View File

@@ -1,14 +0,0 @@
using System;
using System.Collections.Generic;
using System.Diagnostics.Tracing;
using System.Text;
using Microsoft.PowerToys.Telemetry;
namespace Microsoft.PowerLauncher.Telemetry
{
[EventData]
public class HideEvent : IEvent
{
public string EventName { get; } = "PowerLauncher_Hide_Event";
}
}

View File

@@ -0,0 +1,10 @@
using System.Diagnostics.Tracing;
namespace Microsoft.PowerLauncher.Telemetry
{
[EventData]
public class LauncherBootEvent
{
public double BootTimeMs { get; set; }
}
}

View File

@@ -0,0 +1,9 @@
using System.Diagnostics.Tracing;
namespace Microsoft.PowerLauncher.Telemetry
{
[EventData]
public class LauncherFirstDeleteEvent
{
}
}

View File

@@ -0,0 +1,9 @@
using System.Diagnostics.Tracing;
namespace Microsoft.PowerLauncher.Telemetry
{
[EventData]
public class LauncherHideEvent
{
}
}

View File

@@ -1,8 +1,4 @@
using System;
using System.Collections.Generic;
using System.Diagnostics.Tracing;
using System.Text;
using Microsoft.PowerToys.Telemetry;
using System.Diagnostics.Tracing;
namespace Microsoft.PowerLauncher.Telemetry
{
@@ -10,9 +6,8 @@ namespace Microsoft.PowerLauncher.Telemetry
/// ETW Event for when the user initiates a query
/// </summary>
[EventData]
public class QueryEvent : IEvent
public class LauncherQueryEvent
{
public string EventName { get; } = "PowerLauncher_Query_Event";
public double QueryTimeMs { get; set; }
public int QueryLength { get; set; }
public int NumResults { get; set; }

View File

@@ -1,8 +1,4 @@
using System;
using System.Collections.Generic;
using System.Diagnostics.Tracing;
using System.Text;
using Microsoft.PowerToys.Telemetry;
using System.Diagnostics.Tracing;
namespace Microsoft.PowerLauncher.Telemetry
{
@@ -10,9 +6,8 @@ namespace Microsoft.PowerLauncher.Telemetry
/// ETW event for when a result is actioned.
/// </summary>
[EventData]
public class ResultActionEvent : IEvent
public class LauncherResultActionEvent
{
public string EventName { get; } = "PowerLauncher_Result_ActionEvent";
public enum TriggerType
{
@@ -20,7 +15,7 @@ namespace Microsoft.PowerLauncher.Telemetry
KeyboardShortcut
}
public TriggerType Trigger { get; set; }
public string Trigger { get; set; }
public string PluginName { get; set; }
public string ActionName { get; set; }
}

View File

@@ -0,0 +1,9 @@
using System.Diagnostics.Tracing;
namespace Microsoft.PowerLauncher.Telemetry
{
[EventData]
public class LauncherShowEvent
{
}
}

View File

@@ -1,14 +0,0 @@
using System;
using System.Collections.Generic;
using System.Diagnostics.Tracing;
using System.Text;
using Microsoft.PowerToys.Telemetry;
namespace Microsoft.PowerLauncher.Telemetry
{
[EventData]
public class ShowEvent : IEvent
{
public string EventName { get; } = "PowerLauncher_Show_Event";
}
}