Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-05 10:46:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

Removing unecceary EventName requirement. EventSource<T>.Write will use the type name of T if null is passed in. This saves us passing an extra string uneccesarily as the public property would be serialized into the event data as well as being specified as the EventName

Browse Source
This commit is contained in:
ryanbodrug-microsoft
2020-05-05 12:17:26 -07:00
parent b4d75e3240
commit 1f9c1ce8e4
19 changed files with 56 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/Microsoft.PowerToys.Settings.UI.Lib/EnabledModules.cs
View File

@@ -133,7 +133,7 @@ namespace Microsoft.PowerToys.Settings.UI.Lib
private void LogTelemetryEvent(bool value, [CallerMemberName] string moduleName = null )
{
var dataEvent = new EnabledModuleEvent()
var dataEvent = new SettingsEnabledModuleEvent()
{
Value = value,
ModuleName = moduleName,

3
src/core/Microsoft.PowerToys.Settings.UI.Lib/Telemetry/Events/EnabledModuleEvent.cs → src/core/Microsoft.PowerToys.Settings.UI.Lib/Telemetry/Events/SettingsEnabledModuleEvent.cs
View File

@@ -1,10 +1,9 @@
using System.Diagnostics.Tracing;
using Microsoft.PowerToys.Telemetry;
namespace Microsoft.PowerToys.Settings.Telemetry
{
[EventData]
public class EnabledModuleEvent : IEvent
public class SettingsEnabledModuleEvent
{
public string EventName { get; } = "Settings_EnableModule";