From 1ee300bb86111a0eb6f9e361f2e91e4d9fb5c296 Mon Sep 17 00:00:00 2001 From: "Gordon Lam (SH)" Date: Mon, 10 Nov 2025 16:03:21 +0800 Subject: [PATCH] Fix spelling --- .github/actions/spell-check/expect.txt | 7 +++++++ .github/prompts/fix-issue.prompt.md | 10 +++++----- .github/prompts/review-issue.prompt.md | 2 +- .github/prompts/review-pr.prompt.md | 2 +- 4 files changed, 14 insertions(+), 7 deletions(-) diff --git a/.github/actions/spell-check/expect.txt b/.github/actions/spell-check/expect.txt index 31dabc785a..1c46c37449 100644 --- a/.github/actions/spell-check/expect.txt +++ b/.github/actions/spell-check/expect.txt @@ -378,6 +378,7 @@ devpal dfx DIALOGEX digicert +diffs DINORMAL DISABLEASACTIONKEY DISABLENOSCROLL @@ -959,6 +960,7 @@ mdtext mdtxt mdwn meme +mcp memicmp MENUITEMINFO MENUITEMINFOW @@ -1047,6 +1049,8 @@ multizone muxc MVPs mvvm +myorg +myrepo MVVMTK MWBEx MYICON @@ -1262,6 +1266,7 @@ phwnd pici pidl PIDLIST +PII pinfo pinvoke pipename @@ -1457,6 +1462,7 @@ riid RKey RNumber rop +rollups ROUNDSMALL ROWSETEXT rpcrt @@ -2048,6 +2054,7 @@ xstyler XTimer XUP XVIRTUALSCREEN +XXL xxxxxx YAxis ycombinator diff --git a/.github/prompts/fix-issue.prompt.md b/.github/prompts/fix-issue.prompt.md index ada9a70f44..e8127d0dae 100644 --- a/.github/prompts/fix-issue.prompt.md +++ b/.github/prompts/fix-issue.prompt.md @@ -29,7 +29,7 @@ For **#{{issue_number}}**: # OUTPUT FILES 1) Generated Files/issueFix/{{issue_number}}/pr-description.md -2) Generated Files/issueFix/{{issue_number}}/manual-steps.md # only if HITL or external setup is required +2) Generated Files/issueFix/{{issue_number}}/manual-steps.md # only if human interaction or external setup is required # EXECUTION RULES 1) Read implementation-plan.md and execute: @@ -43,7 +43,7 @@ For **#{{issue_number}}**: 2) Locate affected files via `rg` or `git grep`. 3) Add/update tests to enforce the fixed behavior. 4) If any ambiguity exists, add: -// TODO(HITL): +// TODO(Human input needed): 5) Verify locally: build & tests run successfully. # pr-description.md should include: @@ -57,15 +57,15 @@ For **#{{issue_number}}**: - `Closes #{{issue_number}}` # manual-steps.md (only if needed) -- List required human actions: secrets, config, approvals, missing info, or HITL code comments. +- List required human actions: secrets, config, approvals, missing info, or code comments requiring human decisions. # IMPORTANT - Apply code and tests directly; do not produce patch files. - Follow implementation-plan.md as the source of truth. -- Insert HITL comments where a human must decide. +- Insert comments for human review where a decision or input is required. - Use repository conventions and deterministic, minimal changes. # FINALIZE - Write pr-description.md - Write manual-steps.md only if needed -- Print concise success or HITL message +- Print concise success message or note items requiring human interaction diff --git a/.github/prompts/review-issue.prompt.md b/.github/prompts/review-issue.prompt.md index 96da33ede7..c5a6a7adf7 100644 --- a/.github/prompts/review-issue.prompt.md +++ b/.github/prompts/review-issue.prompt.md @@ -150,7 +150,7 @@ Post these questions as issue comment to gather missing information: 7) **Risks & Mitigations** — flags/canary/shadow-write/config guards. 8) **Task Breakdown (agent-ready)** — table (leave a blank line before the header so Markdown renders correctly): -| Task | Intent | Files/Areas | Steps | Tests (brief) | Owner (Agent/Human) | HITL? (why) | +| Task | Intent | Files/Areas | Steps | Tests (brief) | Owner (Agent/Human) | Human interaction needed? (why) | |---|---|---|---|---|---|---| 9) **Tests to Add (only)** diff --git a/.github/prompts/review-pr.prompt.md b/.github/prompts/review-pr.prompt.md index 98db910ba9..adf2a5eb02 100644 --- a/.github/prompts/review-pr.prompt.md +++ b/.github/prompts/review-pr.prompt.md @@ -108,7 +108,7 @@ When performing incremental review, skip steps that are irrelevant based on chan - List the concrete checks for *this step only* (5–10 bullets). ## Findings -(If none, write **None**. Otherwise one or more blocks:) +(If none, write **None**. Defaults have one or more blocks:) ```mcp-review-comment {"file":"relative/path.ext","start_line":123,"end_line":125,"severity":"high|medium|low|info","tags":["","pr-tag-here"],"related_files":["optional/other/file1"],"body":"Problem → Why it matters → Concrete fix. If spans multiple files, name them here."}