[Workspaces] Handle admin windows repositioning. (#34965)

2026-02-24 04:00:02 +01:00 · 2024-09-25 12:13:38 +03:00
parent 499dc9bb7a
commit 1e18e83af6
65 changed files with 2531 additions and 891 deletions
--- a/src/modules/Workspaces/WorkspacesLauncher/WindowArrangerHelper.cpp
+++ b/src/modules/Workspaces/WorkspacesLauncher/WindowArrangerHelper.cpp
@@ -0,0 +1,71 @@
+#include "pch.h"
+#include "WindowArrangerHelper.h"
+
+#include <filesystem>
+
+#include <common/utils/OnThreadExecutor.h>
+#include <common/utils/winapi_error.h>
+
+#include <WorkspacesLib/WorkspacesData.h>
+
+#include <AppLauncher.h>
+
+WindowArrangerHelper::WindowArrangerHelper(std::function<void(const std::wstring&)> ipcCallback) :
+    m_processId{},
+    m_ipcHelper(IPCHelperStrings::LauncherArrangerPipeName, IPCHelperStrings::WindowArrangerPipeName, ipcCallback)
+{
+}
+
+WindowArrangerHelper::~WindowArrangerHelper()
+{
+    Logger::info(L"Stopping WorkspacesWindowArranger with pid {}", m_processId);
+    
+    HANDLE process = OpenProcess(PROCESS_ALL_ACCESS, false, m_processId);
+    if (process)
+    {
+        bool res = TerminateProcess(process, 0);
+        if (!res)
+        {
+            Logger::error(L"Unable to terminate PowerToys.WorkspacesWindowArranger process: {}", get_last_error_or_default(GetLastError()));
+        }
+    }
+    else
+    {
+        Logger::error(L"Unable to find PowerToys.WorkspacesWindowArranger process: {}", get_last_error_or_default(GetLastError()));
+    }
+}
+
+void WindowArrangerHelper::Launch(const std::wstring& projectId, bool elevated, std::function<bool()> keepWaitingCallback)
+{
+    Logger::trace(L"Starting WorkspacesWindowArranger");
+
+    TCHAR buffer[MAX_PATH] = { 0 };
+    GetModuleFileName(NULL, buffer, MAX_PATH);
+    std::wstring path = std::filesystem::path(buffer).parent_path();
+
+    auto res = AppLauncher::LaunchApp(path + L"\\PowerToys.WorkspacesWindowArranger.exe", projectId, elevated);
+    if (res.isOk())
+    {
+        auto value = res.value();
+        m_processId = GetProcessId(value.hProcess);
+        Logger::info(L"WorkspacesWindowArranger started with pid {}", m_processId);
+        std::atomic_bool timeoutExpired = false;
+        m_threadExecutor.submit(OnThreadExecutor::task_t{
+            [&] {
+                HANDLE process = value.hProcess;
+                while (keepWaitingCallback())
+                {
+                    WaitForSingleObject(process, 100);
+                }
+                
+                Logger::trace(L"Finished waiting WorkspacesWindowArranger");
+                CloseHandle(process);
+            }}).wait();
+
+        timeoutExpired = true;
+    }
+    else
+    {
+        Logger::error(L"Failed to launch PowerToys.WorkspacesWindowArranger: {}", res.error());
+    }
+}