diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI/Dock/DockWindow.xaml.cs b/src/modules/cmdpal/Microsoft.CmdPal.UI/Dock/DockWindow.xaml.cs index bf593b3392..41005e7f9a 100644 --- a/src/modules/cmdpal/Microsoft.CmdPal.UI/Dock/DockWindow.xaml.cs +++ b/src/modules/cmdpal/Microsoft.CmdPal.UI/Dock/DockWindow.xaml.cs @@ -5,7 +5,6 @@ using System.Runtime.InteropServices; using CommunityToolkit.Mvvm.Messaging; using ManagedCommon; -using Microsoft.CmdPal.UI.Helpers; using Microsoft.CmdPal.UI.ViewModels; using Microsoft.CmdPal.UI.ViewModels.Dock; using Microsoft.CmdPal.UI.ViewModels.Messages; @@ -27,7 +26,6 @@ using Windows.Win32.UI.WindowsAndMessaging; using WinRT; using WinRT.Interop; using WinUIEx; -using WindowExtensions = Microsoft.CmdPal.UI.Helpers.WindowExtensions; namespace Microsoft.CmdPal.UI.Dock; @@ -62,6 +60,7 @@ public sealed partial class DockWindow : WindowEx, private bool _isUpdatingBackdrop; private BackdropParameters? _lastAppliedAcrylicBackdrop; private DockSize _lastSize; + private bool _isDisposed; // Store the original WndProc private WNDPROC? _originalWndProc; @@ -671,18 +670,38 @@ public sealed partial class DockWindow : WindowEx, public void Dispose() { - DisposeAcrylic(); - _windowViewModel.Dispose(); + Cleanup(); + GC.SuppressFinalize(this); } private void DockWindow_Closed(object sender, WindowEventArgs args) { - _settingsService.SettingsChanged -= SettingsChangedHandler; + Dispose(); + } + + private void Cleanup() + { + if (_isDisposed) + { + return; + } + + _isDisposed = true; + + _settingsService?.SettingsChanged -= SettingsChangedHandler; + + Activated -= DockWindow_Activated; _themeService.ThemeChanged -= ThemeService_ThemeChanged; + WeakReferenceMessenger.Default.UnregisterAll(this); + DisposeAcrylic(); + _windowViewModel.Dispose(); // Remove our app bar registration - DestroyAppBar(_hwnd); + if (_appBarData.hWnd != IntPtr.Zero) + { + DestroyAppBar(_hwnd); + } // Unhook the window procedure ShowDesktop.RemoveHook(); diff --git a/src/modules/cmdpal/Microsoft.CmdPal.UI/Pages/ShellPage.xaml.cs b/src/modules/cmdpal/Microsoft.CmdPal.UI/Pages/ShellPage.xaml.cs index 9ee05c2402..6a33569ec0 100644 --- a/src/modules/cmdpal/Microsoft.CmdPal.UI/Pages/ShellPage.xaml.cs +++ b/src/modules/cmdpal/Microsoft.CmdPal.UI/Pages/ShellPage.xaml.cs @@ -73,6 +73,7 @@ public sealed partial class ShellPage : Microsoft.UI.Xaml.Controls.Page, private CancellationTokenSource? _focusAfterLoadedCts; private WeakReference? _lastNavigatedPageRef; + private bool _isDisposed; public ShellViewModel ViewModel { get; private set; } = App.Current.Services.GetService()!; @@ -308,6 +309,11 @@ public sealed partial class ShellPage : Microsoft.UI.Xaml.Controls.Page, { _ = DispatcherQueue.TryEnqueue(() => { + if (_isDisposed) + { + return; + } + OpenSettings(message.SettingsPageTag); }); } @@ -528,6 +534,11 @@ public sealed partial class ShellPage : Microsoft.UI.Xaml.Controls.Page, { _ = DispatcherQueue.TryEnqueue(() => { + if (_isDisposed) + { + return; + } + if (message.ShowDock) { if (_dockWindow is null) @@ -829,10 +840,33 @@ public sealed partial class ShellPage : Microsoft.UI.Xaml.Controls.Page, public void Dispose() { + if (_isDisposed) + { + return; + } + + _isDisposed = true; + WeakReferenceMessenger.Default.UnregisterAll(this); + _focusAfterLoadedCts?.Cancel(); _focusAfterLoadedCts?.Dispose(); _focusAfterLoadedCts = null; - _dockWindow?.Dispose(); + var dockWindow = _dockWindow; + _dockWindow = null; + + if (dockWindow is not null) + { + if (DispatcherQueue.HasThreadAccess) + { + dockWindow.Close(); + } + else + { + DispatcherQueue.TryEnqueue(dockWindow.Close); + } + } + + GC.SuppressFinalize(this); } }