Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-05 02:36:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

[CPP][Analyzers]Turn on warning 4244 (#22019)

Browse Source 
* Turn on warning 4244

fix one occurrence of 4100

* changes from comments

* toupper on wchar
This commit is contained in:
sosssego
2022-11-17 16:24:56 +00:00
committed by GitHub
parent 8fb93dc6ee
commit 195c265a36
9 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/common/SettingsAPI/settings_objects.h
View File

@@ -2,6 +2,8 @@
#include "../utils/json.h"
#include <cwctype>
namespace PowerToysSettings
{
class HotkeyObject;
@@ -230,7 +232,7 @@ namespace PowerToysSettings
if (output_bytes == 1 && output[0] >= 'a' && output[0] <= 'z')
{
// Make Latin letters keys capital, as it looks better
output[0] = toupper(output[0]);
output[0] = std::towupper(output[0]);
}
return output.data();
}

2
src/common/interop/HotkeyManager.cpp
View File

@@ -56,7 +56,7 @@ bool HotkeyManager::FilterKeyboardProc(KeyboardEvent ^ ev)
pressedKeys->Ctrl = GetAsyncKeyState(VK_CONTROL) & 0x8000;
pressedKeys->Alt = GetAsyncKeyState(VK_MENU) & 0x8000;
pressedKeys->Shift = GetAsyncKeyState(VK_SHIFT) & 0x8000;
pressedKeys->Key = ev->key;
pressedKeys->Key = static_cast<unsigned char>(ev->key);
// Convert to hotkey handle
auto pressedKeysHandle = GetHotkeyHandle(pressedKeys);

2
src/common/utils/package.h
View File

@@ -16,7 +16,7 @@ namespace package {
{
OSVERSIONINFOEX osvi{};
DWORDLONG dwlConditionMask = 0;
int op = VER_GREATER_EQUAL;
byte op = VER_GREATER_EQUAL;
// Initialize the OSVERSIONINFOEX structure.
osvi.dwOSVersionInfoSize = sizeof(OSVERSIONINFOEX);