Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2025-12-16 19:57:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use .First instead of where().First() (#21307)

Browse Source
This commit is contained in:
Rose
2022-10-17 19:13:59 -04:00
committed by GitHub
parent 8e4ef1a4ac
commit 17b80aa0f1
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/settings-ui/Settings.UI.Library/ViewModels/ImageResizerViewModel.cs
View File

@@ -266,7 +266,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library.ViewModels
public void DeleteImageSize(int id) public void DeleteImageSize(int id)
{ {
ImageSize size = _advancedSizes.Where<ImageSize>(x => x.Id == id).First(); ImageSize size = _advancedSizes.First(x => x.Id == id);
ObservableCollection<ImageSize> imageSizes = Sizes; ObservableCollection<ImageSize> imageSizes = Sizes;
imageSizes.Remove(size); imageSizes.Remove(size);
@@ -367,7 +367,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library.ViewModels
{ {
ImageSize modifiedSize = (ImageSize)sender; ImageSize modifiedSize = (ImageSize)sender;
ObservableCollection<ImageSize> imageSizes = Sizes; ObservableCollection<ImageSize> imageSizes = Sizes;
imageSizes.Where<ImageSize>(x => x.Id == modifiedSize.Id).First().Update(modifiedSize); imageSizes.First(x => x.Id == modifiedSize.Id).Update(modifiedSize);
_advancedSizes = imageSizes; _advancedSizes = imageSizes;
SavesImageSizes(imageSizes); SavesImageSizes(imageSizes);
} }

4
src/settings-ui/Settings.UI.UnitTests/ViewModelTests/ImageResizer.cs
View File

@@ -231,7 +231,7 @@ namespace ViewModelTests
viewModel.AddRow("New size"); viewModel.AddRow("New size");
// Assert // Assert
ImageSize newTestSize = viewModel.Sizes.Where<ImageSize>(x => x.Id == 0).First(); ImageSize newTestSize = viewModel.Sizes.First(x => x.Id == 0);
Assert.AreEqual(newTestSize.Name, "New size 1"); Assert.AreEqual(newTestSize.Name, "New size 1");
Assert.AreEqual(newTestSize.Fit, (int)ResizeFit.Fit); Assert.AreEqual(newTestSize.Fit, (int)ResizeFit.Fit);
Assert.AreEqual(newTestSize.Width, 854); Assert.AreEqual(newTestSize.Width, 854);
@@ -248,7 +248,7 @@ namespace ViewModelTests
ImageResizerViewModel viewModel = new ImageResizerViewModel(mockSettingsUtils.Object, SettingsRepository<GeneralSettings>.GetInstance(_mockGeneralSettingsUtils.Object), sendMockIPCConfigMSG, (string name) => name); ImageResizerViewModel viewModel = new ImageResizerViewModel(mockSettingsUtils.Object, SettingsRepository<GeneralSettings>.GetInstance(_mockGeneralSettingsUtils.Object), sendMockIPCConfigMSG, (string name) => name);
viewModel.AddRow("New Size"); viewModel.AddRow("New Size");
int sizeOfOriginalArray = viewModel.Sizes.Count; int sizeOfOriginalArray = viewModel.Sizes.Count;
ImageSize deleteCandidate = viewModel.Sizes.Where<ImageSize>(x => x.Id == 0).First(); ImageSize deleteCandidate = viewModel.Sizes.First(x => x.Id == 0);
// act // act
viewModel.DeleteImageSize(0); viewModel.DeleteImageSize(0);