diff --git a/CppRuleSet.ruleset b/CppRuleSet.ruleset index 118e06707e..9468ec2c36 100644 --- a/CppRuleSet.ruleset +++ b/CppRuleSet.ruleset @@ -22,7 +22,7 @@ - + diff --git a/src/modules/MeasureTool/MeasureToolCore/ScreenCapturing.cpp b/src/modules/MeasureTool/MeasureToolCore/ScreenCapturing.cpp index 6b62b2db59..d1dae37ea4 100644 --- a/src/modules/MeasureTool/MeasureToolCore/ScreenCapturing.cpp +++ b/src/modules/MeasureTool/MeasureToolCore/ScreenCapturing.cpp @@ -35,7 +35,7 @@ class D3DCaptureState final winrt::IDirect3DDevice device; winrt::com_ptr swapChain; - winrt::SizeInt32 frameSize; + winrt::SizeInt32 frameSize{}; HMONITOR monitor = {}; winrt::DirectXPixelFormat pixelFormat; diff --git a/src/modules/ShortcutGuide/ShortcutGuide/d2d_window.h b/src/modules/ShortcutGuide/ShortcutGuide/d2d_window.h index ac2f44ab06..b062962d28 100644 --- a/src/modules/ShortcutGuide/ShortcutGuide/d2d_window.h +++ b/src/modules/ShortcutGuide/ShortcutGuide/d2d_window.h @@ -49,7 +49,8 @@ protected: bool hidden = true; bool initialized = false; HWND hwnd; - UINT window_width, window_height; + UINT window_width{}; + UINT window_height{}; winrt::com_ptr d3d_device; winrt::com_ptr dxgi_device; winrt::com_ptr dxgi_factory; diff --git a/src/modules/ShortcutGuide/ShortcutGuide/shortcut_guide.h b/src/modules/ShortcutGuide/ShortcutGuide/shortcut_guide.h index 3fde8bf7a3..053e02766d 100644 --- a/src/modules/ShortcutGuide/ShortcutGuide/shortcut_guide.h +++ b/src/modules/ShortcutGuide/ShortcutGuide/shortcut_guide.h @@ -58,7 +58,7 @@ private: static inline PCWSTR name = L"overlay_opacity"; int value; int resourceId = IDS_SETTING_DESCRIPTION_OVERLAY_OPACITY; - } overlayOpacity; + } overlayOpacity{}; struct Theme { diff --git a/src/modules/ShortcutGuide/ShortcutGuide/tasklist_positions.h b/src/modules/ShortcutGuide/ShortcutGuide/tasklist_positions.h index a1160fd16a..4ac5bed8a9 100644 --- a/src/modules/ShortcutGuide/ShortcutGuide/tasklist_positions.h +++ b/src/modules/ShortcutGuide/ShortcutGuide/tasklist_positions.h @@ -8,7 +8,11 @@ struct TasklistButton { std::wstring name; - long x, y, width, height, keynum; + long x{}; + long y{}; + long width{}; + long height{}; + long keynum{}; }; class Tasklist diff --git a/src/modules/fancyzones/FancyZonesLib/EditorParameters.cpp b/src/modules/fancyzones/FancyZonesLib/EditorParameters.cpp index 92eb1d7da4..26397eb1ba 100644 --- a/src/modules/fancyzones/FancyZonesLib/EditorParameters.cpp +++ b/src/modules/fancyzones/FancyZonesLib/EditorParameters.cpp @@ -25,15 +25,15 @@ namespace JsonUtils std::wstring monitorName; std::wstring monitorInstanceId; std::wstring monitorSerialNumber; - int monitorNumber; + int monitorNumber{}; std::wstring virtualDesktop; - int dpi; - int top; - int left; - int workAreaWidth; - int workAreaHeight; - int monitorWidth; - int monitorHeight; + int dpi{}; + int top{}; + int left{}; + int workAreaWidth{}; + int workAreaHeight{}; + int monitorWidth{}; + int monitorHeight{}; bool isSelected = false; static json::JsonObject ToJson(const MonitorInfo& monitor) @@ -60,8 +60,8 @@ namespace JsonUtils struct EditorArgs { - DWORD processId; - bool spanZonesAcrossMonitors; + DWORD processId{}; + bool spanZonesAcrossMonitors{}; std::vector monitors; static json::JsonObject ToJson(const EditorArgs& args) diff --git a/src/modules/fancyzones/FancyZonesLib/FancyZonesData/CustomLayouts.cpp b/src/modules/fancyzones/FancyZonesLib/FancyZonesData/CustomLayouts.cpp index 9ad60f0044..6080c7ed8c 100644 --- a/src/modules/fancyzones/FancyZonesLib/FancyZonesData/CustomLayouts.cpp +++ b/src/modules/fancyzones/FancyZonesLib/FancyZonesData/CustomLayouts.cpp @@ -102,7 +102,7 @@ namespace JsonUtils struct CustomLayoutJSON { - GUID layoutId; + GUID layoutId{}; FancyZonesDataTypes::CustomLayoutData data; static std::optional FromJson(const json::JsonObject& json) diff --git a/src/modules/fancyzones/FancyZonesLib/FancyZonesDataTypes.h b/src/modules/fancyzones/FancyZonesLib/FancyZonesDataTypes.h index 41d26ca194..847b24547c 100644 --- a/src/modules/fancyzones/FancyZonesLib/FancyZonesDataTypes.h +++ b/src/modules/fancyzones/FancyZonesLib/FancyZonesDataTypes.h @@ -36,8 +36,8 @@ namespace FancyZonesDataTypes struct CanvasLayoutInfo { - int lastWorkAreaWidth; - int lastWorkAreaHeight; + int lastWorkAreaWidth{}; + int lastWorkAreaHeight{}; struct Rect { @@ -47,7 +47,7 @@ namespace FancyZonesDataTypes int height; }; std::vector zones; - int sensitivityRadius; + int sensitivityRadius{}; }; struct GridLayoutInfo @@ -95,29 +95,29 @@ namespace FancyZonesDataTypes std::vector m_rowsPercents; std::vector m_columnsPercents; std::vector> m_cellChildMap; - bool m_showSpacing; - int m_spacing; - int m_sensitivityRadius; + bool m_showSpacing{}; + int m_spacing{}; + int m_sensitivityRadius{}; }; struct CustomLayoutData { std::wstring name; - CustomLayoutType type; + CustomLayoutType type{}; std::variant info; }; struct ZoneSetData { std::wstring uuid; - ZoneSetLayoutType type; + ZoneSetLayoutType type{}; }; struct DeviceId { std::wstring id; std::wstring instanceId; - int number; + int number{}; bool isDefault() const noexcept; std::wstring toString() const noexcept; @@ -125,7 +125,7 @@ namespace FancyZonesDataTypes struct MonitorId { - HMONITOR monitor; + HMONITOR monitor{}; DeviceId deviceId; std::wstring serialNumber; @@ -135,7 +135,7 @@ namespace FancyZonesDataTypes struct WorkAreaId { MonitorId monitorId; - GUID virtualDesktopId; + GUID virtualDesktopId{}; std::wstring toString() const noexcept; }; @@ -152,10 +152,10 @@ namespace FancyZonesDataTypes struct DeviceInfoData { ZoneSetData activeZoneSet; - bool showSpacing; - int spacing; - int zoneCount; - int sensitivityRadius; + bool showSpacing{}; + int spacing{}; + int zoneCount{}; + int sensitivityRadius{}; }; inline bool operator==(const ZoneSetData& lhs, const ZoneSetData& rhs) diff --git a/src/modules/fancyzones/FancyZonesLib/JsonHelpers.h b/src/modules/fancyzones/FancyZonesLib/JsonHelpers.h index 56df116032..c79d27e844 100644 --- a/src/modules/fancyzones/FancyZonesLib/JsonHelpers.h +++ b/src/modules/fancyzones/FancyZonesLib/JsonHelpers.h @@ -13,9 +13,9 @@ namespace BackwardsCompatibility struct DeviceIdData { std::wstring deviceName = L"FallbackDevice"; - int width; - int height; - GUID virtualDesktopId; + int width{}; + int height{}; + GUID virtualDesktopId{}; std::wstring monitorId; static std::optional ParseDeviceId(const std::wstring& str); @@ -77,7 +77,7 @@ namespace JSONHelpers struct LayoutQuickKeyJSON { std::wstring layoutUuid; - int key; + int key{}; static std::optional FromJson(const json::JsonObject& device); }; diff --git a/src/modules/powerrename/PowerRenameUILib/ExplorerItem.h b/src/modules/powerrename/PowerRenameUILib/ExplorerItem.h index d955c161b8..293d059d7b 100644 --- a/src/modules/powerrename/PowerRenameUILib/ExplorerItem.h +++ b/src/modules/powerrename/PowerRenameUILib/ExplorerItem.h @@ -40,17 +40,16 @@ namespace winrt::PowerRenameUI::implementation private: std::wstring StateToErrorMessage(); - int32_t m_id; + int32_t m_id{}; hstring m_idStr; winrt::hstring m_original; winrt::hstring m_renamed; - uint32_t m_depth; + uint32_t m_depth{}; hstring m_imagePath; - int32_t m_type; - bool m_checked; - PowerRenameItemRenameStatus m_state; + int32_t m_type{}; + bool m_checked{}; + PowerRenameItemRenameStatus m_state{}; winrt::event m_propertyChanged; - }; } diff --git a/src/modules/videoconference/VideoConferenceModule/Toolbar.h b/src/modules/videoconference/VideoConferenceModule/Toolbar.h index c4223f3d6a..b0a9484c57 100644 --- a/src/modules/videoconference/VideoConferenceModule/Toolbar.h +++ b/src/modules/videoconference/VideoConferenceModule/Toolbar.h @@ -56,9 +56,9 @@ private: bool HideToolbarWhenUnmuted = true; - uint64_t lastTimeCamOrMicMuteStateChanged; + uint64_t lastTimeCamOrMicMuteStateChanged{}; std::atomic_bool moduleSettingsUpdateScheduled = false; std::atomic_bool generalSettingsUpdateScheduled = false; - UINT_PTR nTimerId; + UINT_PTR nTimerId{}; };