From 0f0a3f155a6252d79f6386a555de776b930c0aab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ji=C5=99=C3=AD=20Pol=C3=A1=C5=A1ek?= Date: Tue, 2 Sep 2025 19:21:43 +0200 Subject: [PATCH] CmdPal: Make LogError include HRESULT in the log (#41393) ## Summary of the Pull Request Enhances `Logger.LogError` to log the exception HRESULT in addition to the exception type and message, improving traceability and debugging efficiency. For ~bug~ fun and profit! ## PR Checklist - [ ] Closes: #xxx - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed --- src/common/ManagedCommon/Logger.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/common/ManagedCommon/Logger.cs b/src/common/ManagedCommon/Logger.cs index e926c074f4..150d6ea355 100644 --- a/src/common/ManagedCommon/Logger.cs +++ b/src/common/ManagedCommon/Logger.cs @@ -122,13 +122,13 @@ namespace ManagedCommon { var exMessage = message + Environment.NewLine + - ex.GetType() + ": " + ex.Message + Environment.NewLine; + ex.GetType() + " (" + ex.HResult + "): " + ex.Message + Environment.NewLine; if (ex.InnerException != null) { exMessage += "Inner exception: " + Environment.NewLine + - ex.InnerException.GetType() + ": " + ex.InnerException.Message + Environment.NewLine; + ex.InnerException.GetType() + " (" + ex.HResult + "): " + ex.InnerException.Message + Environment.NewLine; } exMessage +=