fixed broken log

This commit is contained in:
AT
2019-11-16 00:57:30 +02:00
parent d2ca74ecdf
commit 0c762e610f
2 changed files with 37 additions and 24 deletions

View File

@@ -40,21 +40,11 @@ namespace Wox.Plugin.Program.Logger
LogManager.Configuration = configuration; LogManager.Configuration = configuration;
} }
/// <summary>
/// Please follow exception format: |class name|calling method name|loading program path|user friendly message that explains the error
/// => Example: |Win32|LnkProgram|c:\..\chrome.exe|Permission denied on directory, but Wox should continue
/// </summary>
[MethodImpl(MethodImplOptions.Synchronized)] [MethodImpl(MethodImplOptions.Synchronized)]
internal static void LogException(string message, Exception e) internal static void LogException(string classname, string callingMethodName, string loadingProgramPath,
string interpretationMessage, Exception e)
{ {
//Index 0 is always empty. Debug.WriteLine($"ERROR{classname}|{callingMethodName}|{loadingProgramPath}|{interpretationMessage}");
var parts = message.Split('|');
var classname = parts[1];
var callingMethodName = parts[2];
var loadingProgramPath = parts[3];
var interpretationMessage = parts[4];
Debug.WriteLine($"ERROR{message}");
var logger = LogManager.GetLogger(""); var logger = LogManager.GetLogger("");
@@ -96,6 +86,29 @@ namespace Wox.Plugin.Program.Logger
logger.Error("------------- END Wox.Plugin.Program exception -------------"); logger.Error("------------- END Wox.Plugin.Program exception -------------");
} }
/// <summary>
/// Please follow exception format: |class name|calling method name|loading program path|user friendly message that explains the error
/// => Example: |Win32|LnkProgram|c:\..\chrome.exe|Permission denied on directory, but Wox should continue
/// </summary>
[MethodImpl(MethodImplOptions.Synchronized)]
internal static void LogException(string message, Exception e)
{
//Index 0 is always empty.
var parts = message.Split('|');
if (parts.Length < 4)
{
var logger = LogManager.GetLogger("");
logger.Error(e, $"fail to log exception in program logger, parts length is too small: {parts.Length}, message: {message}");
}
var classname = parts[1];
var callingMethodName = parts[2];
var loadingProgramPath = parts[3];
var interpretationMessage = parts[4];
LogException(classname, callingMethodName, loadingProgramPath, interpretationMessage, e);
}
private static bool IsKnownWinProgramError(Exception e, string callingMethodName) private static bool IsKnownWinProgramError(Exception e, string callingMethodName)
{ {
if (e.TargetSite?.Name == "GetDescription" && callingMethodName == "LnkProgram") if (e.TargetSite?.Name == "GetDescription" && callingMethodName == "LnkProgram")

View File

@@ -205,7 +205,7 @@ namespace Wox.Plugin.Program.Programs
} }
catch (Exception e) catch (Exception e)
{ {
ProgramLogger.LogException("|UWP|CurrentUserPackages|An unexpected error occured and " ProgramLogger.LogException("UWP" ,"CurrentUserPackages", $"id","An unexpected error occured and "
+ $"unable to verify if package is valid", e); + $"unable to verify if package is valid", e);
return false; return false;
} }