Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2025-12-16 11:48:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Get the error strings as static variables to speed up StateErrorMessage (#25128)

Browse Source
This commit is contained in:
sosssego
2023-03-31 09:43:27 +01:00
committed by GitHub
parent 9876695cdb
commit 07579c910a
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/modules/powerrename/PowerRenameUILib/ExplorerItem.cpp
View File

@@ -164,18 +164,20 @@ namespace winrt::PowerRenameUI::implementation
std::wstring ExplorerItem::StateToErrorMessage() std::wstring ExplorerItem::StateToErrorMessage()
{ {
auto factory = winrt::get_activation_factory<ResourceManager, IResourceManagerFactory>(); static auto factory = winrt::get_activation_factory<ResourceManager, IResourceManagerFactory>();
ResourceManager manager = factory.CreateInstance(L"resources.pri"); static ResourceManager manager = factory.CreateInstance(L"resources.pri");
static auto invalid_char_error = manager.MainResourceMap().GetValue(L"Resources/ErrorMessage_InvalidChar").ValueAsString();
static auto name_too_long_error = manager.MainResourceMap().GetValue(L"Resources/ErrorMessage_FileNameTooLong").ValueAsString();
switch (m_state) switch (m_state)
{ {
case PowerRenameItemRenameStatus::ItemNameInvalidChar: case PowerRenameItemRenameStatus::ItemNameInvalidChar:
{ {
return std::wstring{ manager.MainResourceMap().GetValue(L"Resources/ErrorMessage_InvalidChar").ValueAsString() }; return std::wstring{ invalid_char_error };
} }
case PowerRenameItemRenameStatus::ItemNameTooLong: case PowerRenameItemRenameStatus::ItemNameTooLong:
{ {
return std::wstring{ manager.MainResourceMap().GetValue(L"Resources/ErrorMessage_FileNameTooLong").ValueAsString() }; return std::wstring{ name_too_long_error };
} }
default: default:
return {}; return {};