build: Treat warnings as errors in the remaining projects (#8689)

* build: remove #pragma comment(lib

* build: treat warnings as errors for all src projects

src/settings/main.cpp

@@ -11,10 +11,6 @@
 #include "trace.h"
 #include <common/utils/elevation.h>
 
-#pragma comment(lib, "shlwapi.lib")
-#pragma comment(lib, "shcore.lib")
-#pragma comment(lib, "windowsapp")
-
 #ifdef _DEBUG
 #define _DEBUG_WITH_LOCALHOST 0
 // Define as 1 For debug purposes, to access localhost servers.

src/settings/old-settings-ui.vcxproj

@@ -30,6 +30,9 @@
     <ClCompile>
       <AdditionalIncludeDirectories>..;..\common\Telemetry;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
     </ClCompile>
+    <Link>
+      <AdditionalDependencies>Shlwapi.lib;Shcore.lib;%(AdditionalDependencies)</AdditionalDependencies>
+    </Link>
     <PostBuildEvent>
       <Command>XCOPY "$(ProjectDir)settings-html" "$(TargetDir)\settings-html\" /S /I /Y</Command>
     </PostBuildEvent>