Settings: small tweaks to VCM page (#24735)

* Remove `IsVideoConferenceBuild`

* small tweaks VCM page

* Button: Visibility --> IsEnabled

* Revert "Remove `IsVideoConferenceBuild`"

This reverts commit acae5a5f3a.

* negate IsOpen bool
This commit is contained in:
Jay
2023-03-21 13:02:28 +01:00
committed by GitHub
parent f5325f025c
commit 061d724f44

View File

@@ -15,6 +15,10 @@
x:Name="EmptyToCollapsedConverter" x:Name="EmptyToCollapsedConverter"
EmptyValue="Collapsed" EmptyValue="Collapsed"
NotEmptyValue="Visible" /> NotEmptyValue="Visible" />
<converters:StringVisibilityConverter
x:Name="EmptyToBoolConverter"
EmptyValue="False"
NotEmptyValue="True" />
</Page.Resources> </Page.Resources>
<controls:SettingsPageControl <controls:SettingsPageControl
@@ -28,7 +32,7 @@
IsClosable="False" IsClosable="False"
IsOpen="True" IsOpen="True"
IsTabStop="True" IsTabStop="True"
Severity="Error"> Severity="Informational">
<InfoBar.ActionButton> <InfoBar.ActionButton>
<HyperlinkButton <HyperlinkButton
x:Uid="VideoConference_DeprecationWarningButton" x:Uid="VideoConference_DeprecationWarningButton"
@@ -49,10 +53,9 @@
<InfoBar <InfoBar
x:Uid="VideoConference_RunAsAdminRequired" x:Uid="VideoConference_RunAsAdminRequired"
IsClosable="False" IsClosable="False"
IsOpen="True" IsOpen="{Binding Mode=OneWay, Path=IsElevated, Converter={StaticResource BoolNegationConverter}}"
IsTabStop="True" IsTabStop="True"
Severity="Warning" Severity="Informational"/>
Visibility="{Binding Mode=OneWay, Path=IsElevated, Converter={StaticResource ReverseBoolToVisibilityConverter}}" />
<InfoBar <InfoBar
x:Uid="GPO_IsSettingForced" x:Uid="GPO_IsSettingForced"
IsClosable="False" IsClosable="False"
@@ -117,15 +120,15 @@
<Button <Button
x:Uid="VideoConference_CameraOverlayImageClear" x:Uid="VideoConference_CameraOverlayImageClear"
Command="{Binding Mode=OneWay, Path=ClearOverlayImage}" Command="{Binding Mode=OneWay, Path=ClearOverlayImage}"
Visibility="{Binding Path=CameraImageOverlayPath, Mode=OneWay, Converter={StaticResource EmptyToCollapsedConverter}}" /> IsEnabled="{Binding Path=CameraImageOverlayPath, Mode=OneWay, Converter={StaticResource EmptyToBoolConverter}}" />
</StackPanel> </StackPanel>
</labs:SettingsCard> </labs:SettingsCard>
<labs:SettingsCard> <labs:SettingsCard
Visibility="{Binding Path=CameraImageOverlayPath, Mode=OneWay, Converter={StaticResource EmptyToCollapsedConverter}}">
<Border <Border
MaxHeight="100" MaxHeight="100"
HorizontalAlignment="Right" HorizontalAlignment="Right"
CornerRadius="4" CornerRadius="4">
Visibility="{Binding Path=CameraImageOverlayPath, Mode=OneWay, Converter={StaticResource EmptyToCollapsedConverter}}">
<Image <Image
x:Uid="VideoConference_CameraOverlayImageAlt" x:Uid="VideoConference_CameraOverlayImageAlt"
Source="{Binding Mode=OneWay, Path=CameraImageOverlayPath}" Source="{Binding Mode=OneWay, Path=CameraImageOverlayPath}"