Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-08 20:27:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

To catch URI Format Exception in PT Run (#6580)

Browse Source 
* add a catch block for uri format exceptions

* Added link to watson crash
This commit is contained in:
Alekhya
2020-09-11 13:04:25 -07:00
committed by GitHub
parent db9677bb4a
commit 0478d99aac
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/Win32Program.cs
View File

@@ -376,7 +376,18 @@ namespace Microsoft.Plugin.Program.Programs
if (line.StartsWith(urlPrefix, StringComparison.OrdinalIgnoreCase)) if (line.StartsWith(urlPrefix, StringComparison.OrdinalIgnoreCase))
{ {
urlPath = line.Substring(urlPrefix.Length); urlPath = line.Substring(urlPrefix.Length);
Uri uri = new Uri(urlPath);
try
{
Uri uri = new Uri(urlPath);
}
catch (UriFormatException e)
{
// To catch the exception if the uri cannot be parsed.
// Link to watson crash: https://watsonportal.microsoft.com/Failure?FailureSearchText=5f871ea7-e886-911f-1b31-131f63f6655b
ProgramLogger.LogException($"|Win32Program|InternetShortcutProgram|{urlPath}|url could not be parsed", e);
return new Win32Program() { Valid = false, Enabled = false };
}
// To filter out only those steam shortcuts which have 'run' or 'rungameid' as the hostname // To filter out only those steam shortcuts which have 'run' or 'rungameid' as the hostname
if (internetShortcutURLPrefixes.Match(urlPath).Success) if (internetShortcutURLPrefixes.Match(urlPath).Success)