[fxcop] preview handler common (#6762)

* FxCop adjustments

* initing due to change for abstract
This commit is contained in:
Clint Rutkas
2020-09-23 10:22:17 -07:00
committed by GitHub
parent 75ace74d37
commit 0148669e98
22 changed files with 241 additions and 138 deletions

View File

@@ -58,7 +58,7 @@ namespace UnitTests_PreviewHandlerCommon
using (var testFormHandlerControl = new TestFormControl())
{
// Act
var handle = testFormHandlerControl.GetHandle();
var handle = testFormHandlerControl.Handle;
// Assert
Assert.AreEqual(testFormHandlerControl.Handle, handle);

View File

@@ -19,6 +19,11 @@ namespace UnitTests_PreviewHandlerCommon
public class TestPreviewHandler : PreviewHandlerBase
{
public TestPreviewHandler()
{
Initialize();
}
public override void DoPreview()
{
throw new NotImplementedException();
@@ -291,7 +296,7 @@ namespace UnitTests_PreviewHandlerCommon
// Arrange
var previewControlHandle = new IntPtr(5);
var mockPreviewControl = new Mock<IPreviewHandlerControl>();
mockPreviewControl.Setup(x => x.GetHandle())
mockPreviewControl.Setup(x => x.GetWindowHandle())
.Returns(previewControlHandle);
previewHandlerControl = mockPreviewControl.Object;

View File

@@ -26,7 +26,7 @@ namespace UnitTests_PreviewHandlerCommon
// Act
try
{
var streamWrapper = new StreamWrapper(stream);
var streamWrapper = new ReadonlyStream(stream);
}
catch (ArgumentNullException ex)
{
@@ -44,7 +44,7 @@ namespace UnitTests_PreviewHandlerCommon
var streamMock = new Mock<IStream>();
// Act
var streamWrapper = new StreamWrapper(streamMock.Object);
var streamWrapper = new ReadonlyStream(streamMock.Object);
// Assert
Assert.AreEqual(streamWrapper.CanRead, true);
@@ -57,7 +57,7 @@ namespace UnitTests_PreviewHandlerCommon
var streamMock = new Mock<IStream>();
// Act
var streamWrapper = new StreamWrapper(streamMock.Object);
var streamWrapper = new ReadonlyStream(streamMock.Object);
// Assert
Assert.AreEqual(streamWrapper.CanSeek, true);
@@ -70,7 +70,7 @@ namespace UnitTests_PreviewHandlerCommon
var streamMock = new Mock<IStream>();
// Act
var streamWrapper = new StreamWrapper(streamMock.Object);
var streamWrapper = new ReadonlyStream(streamMock.Object);
// Assert
Assert.AreEqual(streamWrapper.CanWrite, false);
@@ -89,7 +89,7 @@ namespace UnitTests_PreviewHandlerCommon
stremMock
.Setup(x => x.Stat(out stat, It.IsAny<int>()));
var streamWrapper = new StreamWrapper(stremMock.Object);
var streamWrapper = new ReadonlyStream(stremMock.Object);
// Act
var actualLength = streamWrapper.Length;
@@ -113,7 +113,7 @@ namespace UnitTests_PreviewHandlerCommon
{
Marshal.WriteInt64(plibNewPosition, currPosition);
});
var streamWrapper = new StreamWrapper(stremMock.Object);
var streamWrapper = new ReadonlyStream(stremMock.Object);
// Act
var actualPosition = streamWrapper.Position;
@@ -131,7 +131,7 @@ namespace UnitTests_PreviewHandlerCommon
int expectedDwOrigin = 0; // STREAM_SEEK_SET
var stremMock = new Mock<IStream>();
var streamWrapper = new StreamWrapper(stremMock.Object)
var streamWrapper = new ReadonlyStream(stremMock.Object)
{
// Act
Position = positionToSet,
@@ -168,7 +168,7 @@ namespace UnitTests_PreviewHandlerCommon
}
var stremMock = new Mock<IStream>();
var streamWrapper = new StreamWrapper(stremMock.Object);
var streamWrapper = new ReadonlyStream(stremMock.Object);
// Act
streamWrapper.Seek(offset, origin);
@@ -191,7 +191,7 @@ namespace UnitTests_PreviewHandlerCommon
Marshal.WriteInt64(plibNewPosition, position);
});
var streamWrapper = new StreamWrapper(stremMock.Object);
var streamWrapper = new ReadonlyStream(stremMock.Object);
// Act
var actualPosition = streamWrapper.Seek(0, SeekOrigin.Begin);
@@ -212,7 +212,7 @@ namespace UnitTests_PreviewHandlerCommon
var stremMock = new Mock<IStream>();
ArgumentOutOfRangeException exception = null;
var streamWrapper = new StreamWrapper(stremMock.Object);
var streamWrapper = new ReadonlyStream(stremMock.Object);
// Act
try
@@ -252,7 +252,7 @@ namespace UnitTests_PreviewHandlerCommon
Marshal.WriteInt32(bytesReadPtr, count);
});
var streamWrapper = new StreamWrapper(stremMock.Object);
var streamWrapper = new ReadonlyStream(stremMock.Object);
// Act
var bytesRead = streamWrapper.Read(inputBuffer, offset, count);
@@ -267,7 +267,7 @@ namespace UnitTests_PreviewHandlerCommon
{
// Arrange
var stremMock = new Mock<IStream>();
var streamWrapper = new StreamWrapper(stremMock.Object);
var streamWrapper = new ReadonlyStream(stremMock.Object);
NotImplementedException exception = null;
// Act
@@ -289,7 +289,7 @@ namespace UnitTests_PreviewHandlerCommon
{
// Arrange
var stremMock = new Mock<IStream>();
var streamWrapper = new StreamWrapper(stremMock.Object);
var streamWrapper = new ReadonlyStream(stremMock.Object);
NotImplementedException exception = null;
// Act
@@ -311,7 +311,7 @@ namespace UnitTests_PreviewHandlerCommon
{
// Arrange
var stremMock = new Mock<IStream>();
var streamWrapper = new StreamWrapper(stremMock.Object);
var streamWrapper = new ReadonlyStream(stremMock.Object);
NotImplementedException exception = null;
// Act