src/core/Microsoft.PowerToys.Settings.UI.Lib/Utilities/IIOProvider.cs

// Copyright (c) Microsoft Corporation
// The Microsoft Corporation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

namespace Microsoft.PowerToys.Settings.UI.Lib.Utilities
{
    public interface IIOProvider
    {
        bool FileExists(string path);

        bool DirectoryExists(string path);

        bool CreateDirectory(string path);

        void DeleteDirectory(string path);

        void WriteAllText(string path, string content);

        string ReadAllText(string path);
    }
}
-												User/ryanbod/mock settings disk access (#6188)

* 1) Making Directory Methods private.
2) Removing the CreateDirectory / DeleteDirectory functionality from all Settings Unit Tests.

* Abstracting disk access via IIOProvider to be able to provide mocks for unit tests instead of writing to disk.   This also prevents developers who are running unit tests from interfering with the PowerToys settings on their local dev box.

* Dependency Injecting stub SettingsUtils for all tests

* Removing ISettingsUtils from constructors of objects that need to be deserialized (ColorPickerSettings/PowerLauncherSettings) as this breaks System.Text.Json

* Removing unused namespace reference

* Removing redifined mock

* As per PR feedback.  Stub Settings utils should work with any settings type if the intent is to compile / avoid null ref exceptions.

Strangely when implementing this fix it became apparent that a stub settings isn't enough, and disk access needed to be mocked.  I can't explain why the tests were passing previously.

* Leveraging GetMockIOProviderForSaveLoadExists
											
										
										
											2020-09-21 10:14:44 -07:00
+								// Copyright (c) Microsoft Corporation
 								// The Microsoft Corporation licenses this file to you under the MIT license.
 								// See the LICENSE file in the project root for more information.
 								namespace Microsoft.PowerToys.Settings.UI.Lib.Utilities
 								{
 								    public interface IIOProvider
 								    {
 								        bool FileExists(string path);
 								        bool DirectoryExists(string path);
 								        bool CreateDirectory(string path);
 								        void DeleteDirectory(string path);
 								        void WriteAllText(string path, string content);
 								        string ReadAllText(string path);
 								    }
 								}