2022-04-19 22:00:28 +02:00
|
|
|
|
// Copyright (c) Microsoft Corporation
|
|
|
|
|
|
// The Microsoft Corporation licenses this file to you under the MIT license.
|
|
|
|
|
|
// See the LICENSE file in the project root for more information.
|
|
|
|
|
|
|
|
|
|
|
|
using System;
|
2026-01-07 16:38:09 +08:00
|
|
|
|
using System.Threading.Tasks;
|
2022-07-01 21:52:48 +12:00
|
|
|
|
using ManagedCommon;
|
2022-04-19 22:00:28 +02:00
|
|
|
|
using Microsoft.PowerLauncher.Telemetry;
|
2022-04-20 17:08:25 +02:00
|
|
|
|
using Microsoft.PowerToys.Settings.UI.Helpers;
|
2023-01-31 00:00:11 +01:00
|
|
|
|
using Microsoft.PowerToys.Settings.UI.Library;
|
2026-01-07 16:38:09 +08:00
|
|
|
|
using Microsoft.PowerToys.Settings.UI.Library.Helpers;
|
2022-04-19 22:00:28 +02:00
|
|
|
|
using Microsoft.PowerToys.Settings.UI.Views;
|
|
|
|
|
|
using Microsoft.PowerToys.Telemetry;
|
|
|
|
|
|
using Microsoft.UI;
|
2026-02-12 03:35:58 +01:00
|
|
|
|
using Microsoft.UI.Dispatching;
|
2022-04-19 22:00:28 +02:00
|
|
|
|
using Microsoft.UI.Windowing;
|
|
|
|
|
|
using Microsoft.UI.Xaml;
|
|
|
|
|
|
using Windows.Data.Json;
|
Setting search (#41285)
<!-- Enter a brief description/summary of your PR here. What does it
fix/what does it change/how was it tested (even manually, if necessary)?
-->
## Summary of the Pull Request
<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
- [ ] Closes: #xxx
- [ ] **Communication:** I've discussed this with core contributors
already. If the work hasn't been agreed, this work might be rejected
- [x] **Tests:** Added/updated and all pass
- [ ] **Localization:** All end-user-facing strings can be localized
- [ ] **Dev docs:** Added/updated
- [ ] **New binaries:** Added on the required places
- [ ] [JSON for
signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json)
for new binaries
- [ ] [WXS for
installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs)
for new binaries and localization folder
- [ ] [YML for CI
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml)
for new test projects
- [ ] [YML for signed
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml)
- [ ] **Documentation updated:** If checked, please file a pull request
on [our docs
repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys)
and link it here: #xxx
<!-- Provide a more detailed description of the PR, other things fixed,
or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
<!-- Describe how you validated the behavior. Add automated tests
wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
Localized search:
<img width="1576" height="480" alt="image"
src="https://github.com/user-attachments/assets/dd6e5e9f-419b-40b1-b796-f0799481ecfc"
/>
## AI summary
This pull request introduces infrastructure and code to support search
functionality for PowerToys settings, including a new search index
specification, a dedicated search library, and updates to the solution
configuration. The main changes are the addition of a spec describing
how settings should be indexed and navigated, the creation of a new
`Common.Search` project with a fuzz search implementation, and updates
to the solution file to include these new components.
**Settings Search Feature Implementation**
* Documentation:
* Added a detailed specification (`settings-search.md`) describing the
structure of PowerToys settings pages, how to index settings, navigation
logic, runtime search, result grouping, build-time indexing strategy,
and corner cases.
* New Search Library:
* Added the new `Common.Search` project to the solution, including its
project file and implementation of a fuzz search service
(`FuzzSearchService<T>`), match options, match results, and search
precision scoring.
[[1]](diffhunk://#diff-ddc06fa41e4e723e54181b0cb85cdd00f57f75725d51ceefa242d4d651a9a363R1-R8)
[[2]](diffhunk://#diff-1a2ca29fc33bcccf338a7843a040ca2c31ba821e8cab7064fab0dbb1224d454cR1-R39)
[[3]](diffhunk://#diff-242764d948b795f39653a84d9b6bfcdc52730100deab2e3a0995be95bb8e7868R1-R10)
[[4]](diffhunk://#diff-61e525491ed916ebd65dabb66dd4f5dc720320d7e295ef1e0bd6d506ea0f7df6R1-R67)
[[5]](diffhunk://#diff-a775f6de2e8d42982829b4161668f49dedbbd9dcbb05ce20003de7e62275c57aR1-R12)
* Solution Configuration:
* Updated `PowerToys.sln` to include `Common.Search` and
`Settings.UI.XamlIndexBuilder` projects, and configured their build
settings for various platforms and mapped project dependencies.
[[1]](diffhunk://#diff-ca837ce490070b91656ffffe31cbad8865ba9174e0f020231f77baf35ff3f811R714-R716)
[[2]](diffhunk://#diff-ca837ce490070b91656ffffe31cbad8865ba9174e0f020231f77baf35ff3f811R2704-R2727)
[[3]](diffhunk://#diff-ca837ce490070b91656ffffe31cbad8865ba9174e0f020231f77baf35ff3f811R2889)
[[4]](diffhunk://#diff-ca837ce490070b91656ffffe31cbad8865ba9174e0f020231f77baf35ff3f811R3157-R3158)
**Spell-check Dictionary Updates**
* Added new terms related to navigation and settings UI components (such
as `Navigatable`, `NavigatablePage`, `settingscard`, `Tru`, `tweakable`)
to the spell-check dictionary to support the new search and indexing
features.
[[1]](diffhunk://#diff-5dcab162c1b233a49973ae010f2b88c7ec4844382abd705e6154685e62bd5c4dR1020-R1021)
[[2]](diffhunk://#diff-5dcab162c1b233a49973ae010f2b88c7ec4844382abd705e6154685e62bd5c4dR1498)
[[3]](diffhunk://#diff-5dcab162c1b233a49973ae010f2b88c7ec4844382abd705e6154685e62bd5c4dR1755-R1761)
---------
Co-authored-by: Niels Laute <niels.laute@live.nl>
Co-authored-by: Gordon Lam (SH) <yeelam@microsoft.com>
Co-authored-by: Gordon Lam <73506701+yeelam-gordon@users.noreply.github.com>
2025-08-25 21:23:07 +08:00
|
|
|
|
using WinRT.Interop;
|
2023-01-31 00:00:11 +01:00
|
|
|
|
using WinUIEx;
|
2022-04-19 22:00:28 +02:00
|
|
|
|
|
|
|
|
|
|
namespace Microsoft.PowerToys.Settings.UI
|
|
|
|
|
|
{
|
2023-04-21 18:59:08 +02:00
|
|
|
|
public sealed partial class MainWindow : WindowEx
|
2022-04-19 22:00:28 +02:00
|
|
|
|
{
|
2023-11-23 18:19:57 +01:00
|
|
|
|
public MainWindow(bool createHidden = false)
|
2022-04-19 22:00:28 +02:00
|
|
|
|
{
|
|
|
|
|
|
var bootTime = new System.Diagnostics.Stopwatch();
|
|
|
|
|
|
bootTime.Start();
|
|
|
|
|
|
|
2025-04-03 01:59:46 +01:00
|
|
|
|
this.Activated += Window_Activated_SetIcon;
|
|
|
|
|
|
|
2024-04-17 16:39:19 +02:00
|
|
|
|
App.ThemeService.ThemeChanged += OnThemeChanged;
|
|
|
|
|
|
App.ThemeService.ApplyTheme();
|
|
|
|
|
|
|
2026-01-15 09:37:08 +01:00
|
|
|
|
this.ExtendsContentIntoTitleBar = true;
|
|
|
|
|
|
|
2022-04-19 22:00:28 +02:00
|
|
|
|
ShellPage.SetElevationStatus(App.IsElevated);
|
|
|
|
|
|
ShellPage.SetIsUserAnAdmin(App.IsUserAnAdmin);
|
|
|
|
|
|
|
2026-01-15 09:37:08 +01:00
|
|
|
|
var hWnd = WindowNative.GetWindowHandle(this);
|
2024-04-17 16:39:19 +02:00
|
|
|
|
var placement = WindowHelper.DeserializePlacementOrDefault(hWnd);
|
2022-05-19 15:12:59 +02:00
|
|
|
|
if (createHidden)
|
|
|
|
|
|
{
|
|
|
|
|
|
placement.ShowCmd = NativeMethods.SW_HIDE;
|
2024-02-20 11:40:53 +01:00
|
|
|
|
|
|
|
|
|
|
// Restore the last known placement on the first activation
|
|
|
|
|
|
this.Activated += Window_Activated;
|
2022-05-19 15:12:59 +02:00
|
|
|
|
}
|
|
|
|
|
|
|
2022-04-20 17:08:25 +02:00
|
|
|
|
NativeMethods.SetWindowPlacement(hWnd, ref placement);
|
|
|
|
|
|
|
2023-09-12 12:11:26 +02:00
|
|
|
|
var loader = ResourceLoaderInstance.ResourceLoader;
|
|
|
|
|
|
Title = App.IsElevated ? loader.GetString("SettingsWindow_AdminTitle") : loader.GetString("SettingsWindow_Title");
|
2022-04-19 22:00:28 +02:00
|
|
|
|
|
|
|
|
|
|
// send IPC Message
|
|
|
|
|
|
ShellPage.SetDefaultSndMessageCallback(msg =>
|
|
|
|
|
|
{
|
|
|
|
|
|
// IPC Manager is null when launching runner directly
|
|
|
|
|
|
App.GetTwoWayIPCManager()?.Send(msg);
|
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
|
|
// send IPC Message
|
|
|
|
|
|
ShellPage.SetRestartAdminSndMessageCallback(msg =>
|
|
|
|
|
|
{
|
|
|
|
|
|
App.GetTwoWayIPCManager()?.Send(msg);
|
|
|
|
|
|
Environment.Exit(0); // close application
|
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
|
|
// send IPC Message
|
|
|
|
|
|
ShellPage.SetCheckForUpdatesMessageCallback(msg =>
|
|
|
|
|
|
{
|
|
|
|
|
|
App.GetTwoWayIPCManager()?.Send(msg);
|
|
|
|
|
|
});
|
|
|
|
|
|
|
2023-01-31 00:00:11 +01:00
|
|
|
|
// open main window
|
2023-05-02 13:10:54 +02:00
|
|
|
|
ShellPage.SetOpenMainWindowCallback(type =>
|
2023-01-31 00:00:11 +01:00
|
|
|
|
{
|
2026-02-12 03:35:58 +01:00
|
|
|
|
DispatcherQueue.TryEnqueue(DispatcherQueuePriority.Normal, () =>
|
2023-05-02 13:10:54 +02:00
|
|
|
|
App.OpenSettingsWindow(type));
|
2023-01-31 00:00:11 +01:00
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
|
|
// open main window
|
2023-11-07 17:38:06 +01:00
|
|
|
|
ShellPage.SetUpdatingGeneralSettingsCallback((ModuleType moduleType, bool isEnabled) =>
|
2023-01-31 00:00:11 +01:00
|
|
|
|
{
|
2025-12-08 04:55:51 +01:00
|
|
|
|
SettingsRepository<GeneralSettings> repository = SettingsRepository<GeneralSettings>.GetInstance(SettingsUtils.Default);
|
2023-01-31 00:00:11 +01:00
|
|
|
|
GeneralSettings generalSettingsConfig = repository.SettingsConfig;
|
2023-11-07 17:38:06 +01:00
|
|
|
|
bool needToUpdate = ModuleHelper.GetIsModuleEnabled(generalSettingsConfig, moduleType) != isEnabled;
|
2023-01-31 00:00:11 +01:00
|
|
|
|
|
|
|
|
|
|
if (needToUpdate)
|
|
|
|
|
|
{
|
2023-11-07 17:38:06 +01:00
|
|
|
|
ModuleHelper.SetIsModuleEnabled(generalSettingsConfig, moduleType, isEnabled);
|
2023-01-31 00:00:11 +01:00
|
|
|
|
var outgoing = new OutGoingGeneralSettings(generalSettingsConfig);
|
2026-01-07 16:38:09 +08:00
|
|
|
|
|
|
|
|
|
|
// Save settings to file
|
|
|
|
|
|
SettingsUtils.Default.SaveSettings(generalSettingsConfig.ToJsonString());
|
|
|
|
|
|
|
|
|
|
|
|
// Send IPC message asynchronously to avoid blocking UI and potential recursive calls
|
|
|
|
|
|
Task.Run(() =>
|
2023-01-31 00:00:11 +01:00
|
|
|
|
{
|
|
|
|
|
|
ShellPage.SendDefaultIPCMessage(outgoing.ToString());
|
|
|
|
|
|
});
|
2026-01-07 16:38:09 +08:00
|
|
|
|
|
|
|
|
|
|
ShellPage.ShellHandler?.SignalGeneralDataUpdate();
|
2023-01-31 00:00:11 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
return needToUpdate;
|
|
|
|
|
|
});
|
|
|
|
|
|
|
2022-04-19 22:00:28 +02:00
|
|
|
|
this.InitializeComponent();
|
2026-02-12 03:35:58 +01:00
|
|
|
|
SetTitleBar();
|
2022-04-19 22:00:28 +02:00
|
|
|
|
|
|
|
|
|
|
// receive IPC Message
|
|
|
|
|
|
App.IPCMessageReceivedCallback = (string msg) =>
|
|
|
|
|
|
{
|
|
|
|
|
|
if (ShellPage.ShellHandler.IPCResponseHandleList != null)
|
|
|
|
|
|
{
|
|
|
|
|
|
var success = JsonObject.TryParse(msg, out JsonObject json);
|
|
|
|
|
|
if (success)
|
|
|
|
|
|
{
|
|
|
|
|
|
foreach (Action<JsonObject> handle in ShellPage.ShellHandler.IPCResponseHandleList)
|
|
|
|
|
|
{
|
|
|
|
|
|
handle(json);
|
|
|
|
|
|
}
|
|
|
|
|
|
}
|
|
|
|
|
|
else
|
|
|
|
|
|
{
|
|
|
|
|
|
Logger.LogError("Failed to parse JSON from IPC message.");
|
|
|
|
|
|
}
|
|
|
|
|
|
}
|
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
|
|
bootTime.Stop();
|
|
|
|
|
|
|
|
|
|
|
|
PowerToysTelemetry.Log.WriteEvent(new SettingsBootEvent() { BootTimeMs = bootTime.ElapsedMilliseconds });
|
|
|
|
|
|
}
|
|
|
|
|
|
|
2026-02-12 03:35:58 +01:00
|
|
|
|
private void SetTitleBar()
|
Setting search (#41285)
<!-- Enter a brief description/summary of your PR here. What does it
fix/what does it change/how was it tested (even manually, if necessary)?
-->
## Summary of the Pull Request
<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
- [ ] Closes: #xxx
- [ ] **Communication:** I've discussed this with core contributors
already. If the work hasn't been agreed, this work might be rejected
- [x] **Tests:** Added/updated and all pass
- [ ] **Localization:** All end-user-facing strings can be localized
- [ ] **Dev docs:** Added/updated
- [ ] **New binaries:** Added on the required places
- [ ] [JSON for
signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json)
for new binaries
- [ ] [WXS for
installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs)
for new binaries and localization folder
- [ ] [YML for CI
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml)
for new test projects
- [ ] [YML for signed
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml)
- [ ] **Documentation updated:** If checked, please file a pull request
on [our docs
repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys)
and link it here: #xxx
<!-- Provide a more detailed description of the PR, other things fixed,
or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
<!-- Describe how you validated the behavior. Add automated tests
wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
Localized search:
<img width="1576" height="480" alt="image"
src="https://github.com/user-attachments/assets/dd6e5e9f-419b-40b1-b796-f0799481ecfc"
/>
## AI summary
This pull request introduces infrastructure and code to support search
functionality for PowerToys settings, including a new search index
specification, a dedicated search library, and updates to the solution
configuration. The main changes are the addition of a spec describing
how settings should be indexed and navigated, the creation of a new
`Common.Search` project with a fuzz search implementation, and updates
to the solution file to include these new components.
**Settings Search Feature Implementation**
* Documentation:
* Added a detailed specification (`settings-search.md`) describing the
structure of PowerToys settings pages, how to index settings, navigation
logic, runtime search, result grouping, build-time indexing strategy,
and corner cases.
* New Search Library:
* Added the new `Common.Search` project to the solution, including its
project file and implementation of a fuzz search service
(`FuzzSearchService<T>`), match options, match results, and search
precision scoring.
[[1]](diffhunk://#diff-ddc06fa41e4e723e54181b0cb85cdd00f57f75725d51ceefa242d4d651a9a363R1-R8)
[[2]](diffhunk://#diff-1a2ca29fc33bcccf338a7843a040ca2c31ba821e8cab7064fab0dbb1224d454cR1-R39)
[[3]](diffhunk://#diff-242764d948b795f39653a84d9b6bfcdc52730100deab2e3a0995be95bb8e7868R1-R10)
[[4]](diffhunk://#diff-61e525491ed916ebd65dabb66dd4f5dc720320d7e295ef1e0bd6d506ea0f7df6R1-R67)
[[5]](diffhunk://#diff-a775f6de2e8d42982829b4161668f49dedbbd9dcbb05ce20003de7e62275c57aR1-R12)
* Solution Configuration:
* Updated `PowerToys.sln` to include `Common.Search` and
`Settings.UI.XamlIndexBuilder` projects, and configured their build
settings for various platforms and mapped project dependencies.
[[1]](diffhunk://#diff-ca837ce490070b91656ffffe31cbad8865ba9174e0f020231f77baf35ff3f811R714-R716)
[[2]](diffhunk://#diff-ca837ce490070b91656ffffe31cbad8865ba9174e0f020231f77baf35ff3f811R2704-R2727)
[[3]](diffhunk://#diff-ca837ce490070b91656ffffe31cbad8865ba9174e0f020231f77baf35ff3f811R2889)
[[4]](diffhunk://#diff-ca837ce490070b91656ffffe31cbad8865ba9174e0f020231f77baf35ff3f811R3157-R3158)
**Spell-check Dictionary Updates**
* Added new terms related to navigation and settings UI components (such
as `Navigatable`, `NavigatablePage`, `settingscard`, `Tru`, `tweakable`)
to the spell-check dictionary to support the new search and indexing
features.
[[1]](diffhunk://#diff-5dcab162c1b233a49973ae010f2b88c7ec4844382abd705e6154685e62bd5c4dR1020-R1021)
[[2]](diffhunk://#diff-5dcab162c1b233a49973ae010f2b88c7ec4844382abd705e6154685e62bd5c4dR1498)
[[3]](diffhunk://#diff-5dcab162c1b233a49973ae010f2b88c7ec4844382abd705e6154685e62bd5c4dR1755-R1761)
---------
Co-authored-by: Niels Laute <niels.laute@live.nl>
Co-authored-by: Gordon Lam (SH) <yeelam@microsoft.com>
Co-authored-by: Gordon Lam <73506701+yeelam-gordon@users.noreply.github.com>
2025-08-25 21:23:07 +08:00
|
|
|
|
{
|
|
|
|
|
|
// We need to assign the window here so it can configure the custom title bar area correctly.
|
|
|
|
|
|
shellPage.TitleBar.Window = this;
|
2026-02-12 03:35:58 +01:00
|
|
|
|
this.ExtendsContentIntoTitleBar = true;
|
Setting search (#41285)
<!-- Enter a brief description/summary of your PR here. What does it
fix/what does it change/how was it tested (even manually, if necessary)?
-->
## Summary of the Pull Request
<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
- [ ] Closes: #xxx
- [ ] **Communication:** I've discussed this with core contributors
already. If the work hasn't been agreed, this work might be rejected
- [x] **Tests:** Added/updated and all pass
- [ ] **Localization:** All end-user-facing strings can be localized
- [ ] **Dev docs:** Added/updated
- [ ] **New binaries:** Added on the required places
- [ ] [JSON for
signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json)
for new binaries
- [ ] [WXS for
installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs)
for new binaries and localization folder
- [ ] [YML for CI
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml)
for new test projects
- [ ] [YML for signed
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml)
- [ ] **Documentation updated:** If checked, please file a pull request
on [our docs
repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys)
and link it here: #xxx
<!-- Provide a more detailed description of the PR, other things fixed,
or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
<!-- Describe how you validated the behavior. Add automated tests
wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
Localized search:
<img width="1576" height="480" alt="image"
src="https://github.com/user-attachments/assets/dd6e5e9f-419b-40b1-b796-f0799481ecfc"
/>
## AI summary
This pull request introduces infrastructure and code to support search
functionality for PowerToys settings, including a new search index
specification, a dedicated search library, and updates to the solution
configuration. The main changes are the addition of a spec describing
how settings should be indexed and navigated, the creation of a new
`Common.Search` project with a fuzz search implementation, and updates
to the solution file to include these new components.
**Settings Search Feature Implementation**
* Documentation:
* Added a detailed specification (`settings-search.md`) describing the
structure of PowerToys settings pages, how to index settings, navigation
logic, runtime search, result grouping, build-time indexing strategy,
and corner cases.
* New Search Library:
* Added the new `Common.Search` project to the solution, including its
project file and implementation of a fuzz search service
(`FuzzSearchService<T>`), match options, match results, and search
precision scoring.
[[1]](diffhunk://#diff-ddc06fa41e4e723e54181b0cb85cdd00f57f75725d51ceefa242d4d651a9a363R1-R8)
[[2]](diffhunk://#diff-1a2ca29fc33bcccf338a7843a040ca2c31ba821e8cab7064fab0dbb1224d454cR1-R39)
[[3]](diffhunk://#diff-242764d948b795f39653a84d9b6bfcdc52730100deab2e3a0995be95bb8e7868R1-R10)
[[4]](diffhunk://#diff-61e525491ed916ebd65dabb66dd4f5dc720320d7e295ef1e0bd6d506ea0f7df6R1-R67)
[[5]](diffhunk://#diff-a775f6de2e8d42982829b4161668f49dedbbd9dcbb05ce20003de7e62275c57aR1-R12)
* Solution Configuration:
* Updated `PowerToys.sln` to include `Common.Search` and
`Settings.UI.XamlIndexBuilder` projects, and configured their build
settings for various platforms and mapped project dependencies.
[[1]](diffhunk://#diff-ca837ce490070b91656ffffe31cbad8865ba9174e0f020231f77baf35ff3f811R714-R716)
[[2]](diffhunk://#diff-ca837ce490070b91656ffffe31cbad8865ba9174e0f020231f77baf35ff3f811R2704-R2727)
[[3]](diffhunk://#diff-ca837ce490070b91656ffffe31cbad8865ba9174e0f020231f77baf35ff3f811R2889)
[[4]](diffhunk://#diff-ca837ce490070b91656ffffe31cbad8865ba9174e0f020231f77baf35ff3f811R3157-R3158)
**Spell-check Dictionary Updates**
* Added new terms related to navigation and settings UI components (such
as `Navigatable`, `NavigatablePage`, `settingscard`, `Tru`, `tweakable`)
to the spell-check dictionary to support the new search and indexing
features.
[[1]](diffhunk://#diff-5dcab162c1b233a49973ae010f2b88c7ec4844382abd705e6154685e62bd5c4dR1020-R1021)
[[2]](diffhunk://#diff-5dcab162c1b233a49973ae010f2b88c7ec4844382abd705e6154685e62bd5c4dR1498)
[[3]](diffhunk://#diff-5dcab162c1b233a49973ae010f2b88c7ec4844382abd705e6154685e62bd5c4dR1755-R1761)
---------
Co-authored-by: Niels Laute <niels.laute@live.nl>
Co-authored-by: Gordon Lam (SH) <yeelam@microsoft.com>
Co-authored-by: Gordon Lam <73506701+yeelam-gordon@users.noreply.github.com>
2025-08-25 21:23:07 +08:00
|
|
|
|
WindowHelpers.ForceTopBorder1PixelInsetOnWindows10(WindowNative.GetWindowHandle(this));
|
|
|
|
|
|
}
|
|
|
|
|
|
|
2026-02-12 03:35:58 +01:00
|
|
|
|
public void NavigateToSection(Type type)
|
2022-04-19 22:00:28 +02:00
|
|
|
|
{
|
|
|
|
|
|
ShellPage.Navigate(type);
|
|
|
|
|
|
}
|
|
|
|
|
|
|
2022-05-19 15:12:59 +02:00
|
|
|
|
public void CloseHiddenWindow()
|
2022-04-19 22:00:28 +02:00
|
|
|
|
{
|
2026-02-12 03:35:58 +01:00
|
|
|
|
var hWnd = WindowNative.GetWindowHandle(this);
|
2022-05-19 15:12:59 +02:00
|
|
|
|
if (!NativeMethods.IsWindowVisible(hWnd))
|
|
|
|
|
|
{
|
|
|
|
|
|
Close();
|
|
|
|
|
|
}
|
|
|
|
|
|
}
|
2022-04-20 17:08:25 +02:00
|
|
|
|
|
2022-05-19 15:12:59 +02:00
|
|
|
|
private void Window_Closed(object sender, WindowEventArgs args)
|
|
|
|
|
|
{
|
2026-02-12 03:35:58 +01:00
|
|
|
|
var hWnd = WindowNative.GetWindowHandle(this);
|
2024-04-17 16:39:19 +02:00
|
|
|
|
WindowHelper.SerializePlacement(hWnd);
|
2022-05-19 15:12:59 +02:00
|
|
|
|
|
[Settings] Implement singleton pattern for ShortcutConflictWindow (#42440)
## Summary
Fixes issue where multiple ShortcutConflictWindow instances could be
opened simultaneously. The window now follows the same singleton pattern
as OobeWindow - only one instance can exist at a time, and attempting to
open another brings the existing window to the foreground.
## Changes
Implemented singleton management for `ShortcutConflictWindow` following
the established pattern used by `OobeWindow`:
### App.xaml.cs
- Added static field to store the singleton window instance
- Added `GetShortcutConflictWindow()`, `SetShortcutConflictWindow()`,
and `ClearShortcutConflictWindow()` methods for lifecycle management
### ShortcutConflictWindow.xaml.cs
- Updated `WindowEx_Closed` event handler to call
`App.ClearShortcutConflictWindow()` to properly clean up the singleton
reference when the window is closed
### Updated all three entry points that create ShortcutConflictWindow:
- **ShortcutConflictControl.xaml.cs** (Dashboard conflict warning)
- **ShortcutControl.xaml.cs** (Settings page shortcut controls)
- **OobeOverview.xaml.cs** (OOBE overview page)
Each location now checks if a window already exists using
`App.GetShortcutConflictWindow()`:
- If no window exists, creates a new one and registers it via
`App.SetShortcutConflictWindow()`
- If a window already exists, simply calls `Activate()` to bring it to
the foreground
## Testing
The fix ensures that:
- ✅ Only one ShortcutConflictWindow can be open at a time
- ✅ Clicking the shortcut conflict button when a window is already open
activates the existing window instead of creating a duplicate
- ✅ The window reference is properly cleared when closed, allowing a new
instance to be created in future interactions
Fixes #[issue_number]
> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses (expand for details)</summary>
>
> #### I tried to connect to the following addresses, but was blocked by
firewall rules:
>
> - `i1qvsblobprodcus353.vsblob.vsassets.io`
> - Triggering command: `dotnet build PowerToys.Settings.csproj
--configuration Release` (dns block)
>
> If you need me to access, download, or install something from one of
these locations, you can either:
>
> - Configure [Actions setup
steps](https://gh.io/copilot/actions-setup-steps) to set up my
environment, which run before the firewall is enabled
> - Add the appropriate URLs or hosts to the custom allowlist in this
repository's [Copilot coding agent
settings](https://github.com/microsoft/PowerToys/settings/copilot/coding_agent)
(admins only)
>
> </details>
<!-- START COPILOT CODING AGENT SUFFIX -->
<details>
<summary>Original prompt</summary>
>
> ----
>
> *This section details on the original issue you should resolve*
>
> <issue_title>[Settings] Single Shortcuts Conflicts
window</issue_title>
> <issue_description>### Microsoft PowerToys version
>
> 0.95.0
>
> ### Installation method
>
> GitHub
>
> ### Area(s) with issue?
>
> Settings
>
> ### Steps to reproduce
>
> Multiple shortcut conflicts window can be launched.
> Should have the same behavior of OOBE window.
> If shortcut conflicts window is already opened, pressing the button
should bring the window in foreground.
>
> ### ✔️ Expected Behavior
>
> Single shortcuts conflicts window
>
> ### ❌ Actual Behavior
>
> Multiple shortcut conflicts window can be launched
>
> ### Additional Information
>
> _No response_
>
> ### Other Software
>
> _No response_</issue_description>
>
> <agent_instructions>Settings ShortcutConflictWindow should have the
same behavior of OobeWindow.
> When ShortcutConflictWindow is already opened, activate that window
instead of opening another one. </agent_instructions>
>
> ## Comments on the Issue (you are @copilot in this section)
>
> <comments>
> </comments>
>
</details>
Fixes microsoft/PowerToys#42437
<!-- START COPILOT CODING AGENT TIPS -->
---
💬 Share your feedback on Copilot coding agent for the chance to win a
$200 gift card! Click
[here](https://survey3.medallia.com/?EAHeSx-AP01bZqG0Ld9QLQ) to start
the survey.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: davidegiacometti <25966642+davidegiacometti@users.noreply.github.com>
Co-authored-by: Davide Giacometti <davide.giacometti@outlook.it>
Co-authored-by: Niels Laute <niels.laute@live.nl>
Co-authored-by: vanzue <vanzue@outlook.com>
2026-02-12 17:28:21 +08:00
|
|
|
|
if (!App.IsSecondaryWindowOpen())
|
2022-05-19 15:12:59 +02:00
|
|
|
|
{
|
|
|
|
|
|
App.ClearSettingsWindow();
|
|
|
|
|
|
}
|
|
|
|
|
|
else
|
|
|
|
|
|
{
|
|
|
|
|
|
args.Handled = true;
|
|
|
|
|
|
NativeMethods.ShowWindow(hWnd, NativeMethods.SW_HIDE);
|
|
|
|
|
|
}
|
2024-04-17 16:39:19 +02:00
|
|
|
|
|
|
|
|
|
|
App.ThemeService.ThemeChanged -= OnThemeChanged;
|
2022-04-19 22:00:28 +02:00
|
|
|
|
}
|
2023-01-31 00:00:11 +01:00
|
|
|
|
|
2025-04-03 01:59:46 +01:00
|
|
|
|
private void Window_Activated_SetIcon(object sender, WindowActivatedEventArgs args)
|
|
|
|
|
|
{
|
|
|
|
|
|
// Set window icon
|
2026-02-12 03:35:58 +01:00
|
|
|
|
this.SetIcon("Assets\\Settings\\icon.ico");
|
2025-04-03 01:59:46 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
2024-02-20 11:40:53 +01:00
|
|
|
|
private void Window_Activated(object sender, WindowActivatedEventArgs args)
|
|
|
|
|
|
{
|
|
|
|
|
|
if (args.WindowActivationState != WindowActivationState.Deactivated)
|
|
|
|
|
|
{
|
|
|
|
|
|
this.Activated -= Window_Activated;
|
2026-02-12 03:35:58 +01:00
|
|
|
|
var hWnd = WindowNative.GetWindowHandle(this);
|
2024-04-17 16:39:19 +02:00
|
|
|
|
var placement = WindowHelper.DeserializePlacementOrDefault(hWnd);
|
2024-02-20 11:40:53 +01:00
|
|
|
|
NativeMethods.SetWindowPlacement(hWnd, ref placement);
|
|
|
|
|
|
}
|
|
|
|
|
|
}
|
|
|
|
|
|
|
2024-04-17 16:39:19 +02:00
|
|
|
|
private void OnThemeChanged(object sender, ElementTheme theme)
|
|
|
|
|
|
{
|
|
|
|
|
|
WindowHelper.SetTheme(this, theme);
|
|
|
|
|
|
}
|
|
|
|
|
|
|
2023-01-31 00:00:11 +01:00
|
|
|
|
internal void EnsurePageIsSelected()
|
|
|
|
|
|
{
|
|
|
|
|
|
ShellPage.EnsurePageIsSelected();
|
|
|
|
|
|
}
|
2022-04-19 22:00:28 +02:00
|
|
|
|
}
|
|
|
|
|
|
}
|